Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705641 > unrolled thread

Re: [PATCH v6] MIPS: NI 169445 board support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6] MIPS: NI 169445 board support Ralf Baechle <ralf@linux-mips.org> - 2017-08-07 17:30 +0200
    Re: [PATCH v6] MIPS: NI 169445 board support Nathan Sullivan <nathan.sullivan@ni.com> - 2017-08-07 17:40 +0200
    Re: [PATCH v6] MIPS: NI 169445 board support Paul Burton <paul.burton@imgtec.com> - 2017-08-07 19:30 +0200
      Re: [PATCH v6] MIPS: NI 169445 board support Ralf Baechle <ralf@linux-mips.org> - 2017-08-07 23:40 +0200

#1705641 — Re: [PATCH v6] MIPS: NI 169445 board support

On Tue, Jul 18, 2017 at 01:29:09PM -0500, Nathan Sullivan wrote:

> Support the National Instruments 169445 board.

Thanks, applied with minor changes:

> --- a/arch/mips/boot/dts/Makefile
> +++ b/arch/mips/boot/dts/Makefile
> @@ -4,6 +4,7 @@ dts-dirs	+= img
>  dts-dirs	+= ingenic
>  dts-dirs	+= lantiq
>  dts-dirs	+= mti
> +dts-dirs	+= ni
>  dts-dirs	+= netlogic
>  dts-dirs	+= pic32
>  dts-dirs	+= qca

Keep things in alphabetical order, so ni should go after netlogic.

> diff --git a/arch/mips/generic/vmlinux.its.S b/arch/mips/generic/vmlinux.its.S
> index f67fbf1..de851f7 100644
> --- a/arch/mips/generic/vmlinux.its.S
> +++ b/arch/mips/generic/vmlinux.its.S
> @@ -29,3 +29,28 @@
>  		};
>  	};
>  };
> +
> +#ifdef CONFIG_FIT_IMAGE_FDT_NI169445
> +/ {
> +	images {
[...]
> +	};
> +};
> +#endif

There's been a reject on this file because of a Boston #ifdefed section.
I've fixed that up but we need a cleaner solution.  Paul, any suggestions?

  Ralf

[toc] | [next] | [standalone]

#1705646

On Mon, Aug 07, 2017 at 05:26:48PM +0200, Ralf Baechle wrote:
> On Tue, Jul 18, 2017 at 01:29:09PM -0500, Nathan Sullivan wrote:
> 
> > Support the National Instruments 169445 board.
> 
> Thanks, applied with minor changes:
> 
>   Ralf

Thank you for your patience!

   Nathan

[toc] | [prev] | [next] | [standalone]

#1705729

[Multipart message — attachments visible in raw view] — view raw

Hi Ralf,

On Monday, 7 August 2017 08:26:48 PDT Ralf Baechle wrote:
> On Tue, Jul 18, 2017 at 01:29:09PM -0500, Nathan Sullivan wrote:
> > diff --git a/arch/mips/generic/vmlinux.its.S
> > b/arch/mips/generic/vmlinux.its.S index f67fbf1..de851f7 100644
> > --- a/arch/mips/generic/vmlinux.its.S
> > +++ b/arch/mips/generic/vmlinux.its.S
> > @@ -29,3 +29,28 @@
> > 
> >  		};
> >  	
> >  	};
> >  
> >  };
> > 
> > +
> > +#ifdef CONFIG_FIT_IMAGE_FDT_NI169445
> > +/ {
> > +	images {
> 
> [...]
> 
> > +	};
> > +};
> > +#endif
> 
> There's been a reject on this file because of a Boston #ifdefed section.
> I've fixed that up but we need a cleaner solution.  Paul, any suggestions?
> 
>   Ralf

One possibility would be for us to split the board portions of vmlinux.its.S 
out into a file per-board, perhaps board-boston.its.S, board-ni169445.its.S 
etc. The build process would then have to concatenate the right files to 
generate the full image tree source.

Does that sound good to you?

Thanks,
    Paul

[toc] | [prev] | [next] | [standalone]

#1705880

On Mon, Aug 07, 2017 at 10:24:05AM -0700, Paul Burton wrote:

> One possibility would be for us to split the board portions of vmlinux.its.S 
> out into a file per-board, perhaps board-boston.its.S, board-ni169445.its.S 
> etc. The build process would then have to concatenate the right files to 
> generate the full image tree source.
> 
> Does that sound good to you?

Yes, that sounds good.

  Ralf

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web