Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705735 > unrolled thread

Re: [PATCH 00/29] constify scsi pci_device_id.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 00/29] constify scsi pci_device_id. "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-07 19:40 +0200
    Re: [PATCH 00/29] constify scsi pci_device_id. Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-08 08:40 +0200

#1705735 — Re: [PATCH 00/29] constify scsi pci_device_id.

Johannes,

> Ultimately it's up to Martin and James but I don't see a hughe benefit
> in having it all in a separate patch.

Generally speaking, I prefer driver maintainers to be able to sign off
on changes to their code. So I tend to lean towards a per-driver
grouping.

However, having a bazillion identical commit messages is also really
annoying. So for automated changes like this, I'd rather just have a
single patch.

It needs to have a really good and comprehensive commit messages that
justifies the (sub) tree-wide change, though...

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [next] | [standalone]

#1706064

On Mon, Aug 07, 2017 at 01:28:18PM -0400, Martin K . Petersen wrote:
> However, having a bazillion identical commit messages is also really
> annoying. So for automated changes like this, I'd rather just have a
> single patch.

Thought so ;-)

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web