Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1705684 > unrolled thread

[RFC PATCH 0/7] mmc: Add OMAP SDHCI driver

Started byKishon Vijay Abraham I <kishon@ti.com>
First post2017-08-07 18:10 +0200
Last post2017-08-10 00:20 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [RFC PATCH 0/7] mmc: Add OMAP SDHCI driver Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-07 18:10 +0200
    [RFC PATCH 5/7] dt-bindings: ti-omap-hsmmc: Document new compatible for sdhci omap Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-07 18:10 +0200
      Re: [RFC PATCH 5/7] dt-bindings: ti-omap-hsmmc: Document new  compatible for sdhci omap Tony Lindgren <tony@atomide.com> - 2017-08-10 00:20 +0200

#1705684 — [RFC PATCH 0/7] mmc: Add OMAP SDHCI driver

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-08-07 18:10 +0200
Subject[RFC PATCH 0/7] mmc: Add OMAP SDHCI driver
Message-ID<ubSLn-2uu-5@gated-at.bofh.it>
This is the first step in deprecating omap_hsmmc driver completely
and moving to sdhci-omap driver which uses the sdhci library.

This series adds 3 new quirks to sdhci library in order to support
MMC in OMAP.
  *) to avoid CRC stripping in MMC_RSP_136
  *) to indicate controller supports ADMA2
  *) to indicate broken POWER_CONTROL (POWER_CONTROL in TI's SOC
     controls IO voltage instead of Vdd).

Apart from the above mentioned quirks, sdhci-omap has it's own callbacks
to set_clock (clock divider programming is different from generic sdhci)
, set_bus_width, set_bus_mode and platform_send_init_74_clocks. These
callback functions are implemented based on omap_hsmmc driver.

The sdhci-omap driver supports only the high speed mode and UHS/HS200
mode will be added in a later series.

It has been tested only in boards having DRA7 SoCs like dra7-evm, dra72-evm,
am571x-idk, am572x-idk, am57xx-evm. (Tested only eMMC and SD.
SDIO support will be added later). The plan is to fully convert DRA7
SoC to use SDHCI driver and then convert other legacy platforms to use
SDHCI.

dts patches will be sent as a separate series.

I've also pushed the entire series along with dependent dt patches @
https://github.com/kishon/linux-wip.git sdhci_omap_v1 (in case someone
wants to test)

Kishon Vijay Abraham I (7):
  mmc: sdhci: Add quirk to indicate no CRC stripping in MMC_RSP_136
  mmc: sdhci: Add quirk to indicate controller supports ADMA2
  mmc: sdhci: Add callback to set bus mode
  mmc: sdhci: Add quirk to indicate broken POWER_CONTROL
  dt-bindings: ti-omap-hsmmc: Document new compatible for sdhci omap
  mmc: sdhci-omap: Add OMAP SDHCI driver
  MAINTAINERS: Add TI OMAP SDHCI Maintainer

 .../devicetree/bindings/mmc/ti-omap-hsmmc.txt      |   1 +
 MAINTAINERS                                        |   6 +
 drivers/mmc/host/Kconfig                           |  12 +
 drivers/mmc/host/Makefile                          |   1 +
 drivers/mmc/host/sdhci-omap.c                      | 593 +++++++++++++++++++++
 drivers/mmc/host/sdhci.c                           |  39 +-
 drivers/mmc/host/sdhci.h                           |   7 +
 7 files changed, 650 insertions(+), 9 deletions(-)
 create mode 100644 drivers/mmc/host/sdhci-omap.c

-- 
2.11.0

[toc] | [next] | [standalone]


#1705686 — [RFC PATCH 5/7] dt-bindings: ti-omap-hsmmc: Document new compatible for sdhci omap

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-08-07 18:10 +0200
Subject[RFC PATCH 5/7] dt-bindings: ti-omap-hsmmc: Document new compatible for sdhci omap
Message-ID<ubSLq-2uu-75@gated-at.bofh.it>
In reply to#1705684
Document the new compatible string "ti,dra7-sdhci" to be used for
MMC controllers in DRA7 and DRA72 SoCs.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
index 0e026c151c1c..db80fdfd05d7 100644
--- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
+++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
@@ -13,6 +13,7 @@ Required properties:
  Should be "ti,omap3-pre-es3-hsmmc" for OMAP3 controllers pre ES3.0
  Should be "ti,omap4-hsmmc", for OMAP4 controllers
  Should be "ti,am33xx-hsmmc", for AM335x controllers
+ Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers
 - ti,hwmods: Must be "mmc<n>", n is controller instance starting 1
 
 Optional properties:
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]


#1708013 — Re: [RFC PATCH 5/7] dt-bindings: ti-omap-hsmmc: Document new compatible for sdhci omap

FromTony Lindgren <tony@atomide.com>
Date2017-08-10 00:20 +0200
SubjectRe: [RFC PATCH 5/7] dt-bindings: ti-omap-hsmmc: Document new compatible for sdhci omap
Message-ID<ucHux-4Z3-1@gated-at.bofh.it>
In reply to#1705686
* Kishon Vijay Abraham I <kishon@ti.com> [170807 09:03]:
> Document the new compatible string "ti,dra7-sdhci" to be used for
> MMC controllers in DRA7 and DRA72 SoCs.

I wonder if this should really be documented for sdhci
instead of ti-omap-hsmmc.txt?

I agree it's better to use sdhci compatible and keep the
hsmmc compatible around as the sdhci is still missing features
for runtime PM and context save and restore etc.

Regards,

Tony


> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> index 0e026c151c1c..db80fdfd05d7 100644
> --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> @@ -13,6 +13,7 @@ Required properties:
>   Should be "ti,omap3-pre-es3-hsmmc" for OMAP3 controllers pre ES3.0
>   Should be "ti,omap4-hsmmc", for OMAP4 controllers
>   Should be "ti,am33xx-hsmmc", for AM335x controllers
> + Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers
>  - ti,hwmods: Must be "mmc<n>", n is controller instance starting 1
>  
>  Optional properties:
> -- 
> 2.11.0
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web