Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1703458 > unrolled thread

[PATCH v2 0/7] enable ghes_edac on selected platforms

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/7] enable ghes_edac on selected platforms Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
    [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
      Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist()  interface Borislav Petkov <bp@alien8.de> - 2017-08-04 05:50 +0200
        Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist()  interface "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 22:40 +0200
          Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist()  interface Borislav Petkov <bp@alien8.de> - 2017-08-05 07:20 +0200
            Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist()  interface "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 16:50 +0200
    [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
      Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Borislav Petkov <bp@alien8.de> - 2017-08-04 06:10 +0200
        Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:10 +0200
          Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Borislav Petkov <bp@alien8.de> - 2017-08-05 07:20 +0200
            Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 20:00 +0200
              Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Borislav Petkov <bp@alien8.de> - 2017-08-11 11:10 +0200
    [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
      Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Borislav Petkov <bp@alien8.de> - 2017-08-04 10:40 +0200
        Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:40 +0200
          Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Borislav Petkov <bp@alien8.de> - 2017-08-05 07:50 +0200
            Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 17:00 +0200
      Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner kbuild test robot <lkp@intel.com> - 2017-08-04 15:10 +0200
        Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 17:30 +0200
    [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
      Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-04 10:40 +0200
        Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:10 +0200
          Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-05 07:40 +0200
            Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 17:00 +0200
    [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
      Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-04 05:50 +0200
        Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:00 +0200
          Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-05 07:20 +0200
            Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 17:00 +0200
    [PATCH v2 2/7] intel_pstate: convert to use acpi_match_oemlist() Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1703794 — Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac

On Thu, Aug 03, 2017 at 03:57:51PM -0600, Toshi Kani wrote:
> The ghes_edac driver was introduced in 2013 [1], but it has not
> been enabled by any distro yet.  This driver obtains error info
> from firmware interfaces, which are not properly implemented on
> many platforms, as the driver always emits the messages below:
> 
>  This EDAC driver relies on BIOS to enumerate memory and get error reports.
>  Unfortunately, not all BIOSes reflect the memory layout correctly
>  So, the end result of using this driver varies from vendor to vendor
>  If you find incorrect reports, please contact your hardware vendor
>  to correct its BIOS.
> 
> To get out from this situation, add a platform check to selectively
> enable the driver on the platforms that are known to have proper
> firmware implementation.  Platform vendors can add their platforms
> to the list when they support ghes_edac.
> 
> "ghes_edac.any_oem=1" skips this platform check.

There's that non-generic OEM thing again. NAK!

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

[toc] | [prev] | [next] | [standalone]

#1704223 — Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac

On Fri, 2017-08-04 at 10:31 +0200, Borislav Petkov wrote:
> On Thu, Aug 03, 2017 at 03:57:51PM -0600, Toshi Kani wrote:
> > The ghes_edac driver was introduced in 2013 [1], but it has not
> > been enabled by any distro yet.  This driver obtains error info
> > from firmware interfaces, which are not properly implemented on
> > many platforms, as the driver always emits the messages below:
> > 
> >  This EDAC driver relies on BIOS to enumerate memory and get error
> > reports.  Unfortunately, not all BIOSes reflect the memory layout
> > correctly  So, the end result of using this driver varies from
> > vendor to vendor  If you find incorrect reports, please contact
> > your hardware vendor to correct its BIOS.
> > 
> > To get out from this situation, add a platform check to selectively
> > enable the driver on the platforms that are known to have proper
> > firmware implementation.  Platform vendors can add their platforms
> > to the list when they support ghes_edac.
> > 
> > "ghes_edac.any_oem=1" skips this platform check.
> 
> There's that non-generic OEM thing again. NAK!

How about "ghes_edac.any_platform"?

Thanks,
-Toshi

[toc] | [prev] | [next] | [standalone]

#1704571 — Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac

On Fri, Aug 04, 2017 at 09:06:27PM +0000, Kani, Toshimitsu wrote:
> How about "ghes_edac.any_platform"?

ghes_edac.force_load

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

[toc] | [prev] | [next] | [standalone]

#1705606 — Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac

On Sat, 2017-08-05 at 07:37 +0200, Borislav Petkov wrote:
> On Fri, Aug 04, 2017 at 09:06:27PM +0000, Kani, Toshimitsu wrote:
> > How about "ghes_edac.any_platform"?
> 
> ghes_edac.force_load

Sounds good.  Will do.

Thanks,
-Toshi

[toc] | [prev] | [next] | [standalone]

#1703467 — [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac

When 'osc_sb_apei_support_acked' is set, it indicates that
the platform supports APEI, firmware-first mode, as ACPI _OSC
capability bit 4, APEI Support, was set in query.  While _OSC
is an optional method, platforms with APEI support should
implement it to inform its capability to the OS properly.

Add check to 'osc_sb_apei_support_acked' before calling
ghes_edac_register() to restrict that ghes_edac is enabled
on platforms with APEI support capability set in _OSC.

Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
---
 drivers/acpi/apei/ghes.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index d661d45..49d75eb 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -1139,9 +1139,11 @@ static int ghes_probe(struct platform_device *ghes_dev)
 		goto err;
 	}
 
-	rc = ghes_edac_register(ghes, &ghes_dev->dev);
-	if (rc < 0)
-		goto err;
+	if (osc_sb_apei_support_acked) {
+		rc = ghes_edac_register(ghes, &ghes_dev->dev);
+		if (rc < 0)
+			goto err;
+	}
 
 	switch (generic->notify.type) {
 	case ACPI_HEST_NOTIFY_POLLED:

[toc] | [prev] | [next] | [standalone]

#1703629 — Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac

On Thu, Aug 03, 2017 at 03:57:49PM -0600, Toshi Kani wrote:
> When 'osc_sb_apei_support_acked' is set, it indicates that
> the platform supports APEI, firmware-first mode, as ACPI _OSC
> capability bit 4, APEI Support, was set in query.  While _OSC
> is an optional method, platforms with APEI support should
> implement it to inform its capability to the OS properly.
> 
> Add check to 'osc_sb_apei_support_acked' before calling
> ghes_edac_register() to restrict that ghes_edac is enabled
> on platforms with APEI support capability set in _OSC.
> 
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Tony Luck <tony.luck@intel.com>
> ---
>  drivers/acpi/apei/ghes.c |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d661d45..49d75eb 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1139,9 +1139,11 @@ static int ghes_probe(struct platform_device *ghes_dev)
>  		goto err;
>  	}
>  
> -	rc = ghes_edac_register(ghes, &ghes_dev->dev);
> -	if (rc < 0)
> -		goto err;
> +	if (osc_sb_apei_support_acked) {

What for when we have the whitelist?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

[toc] | [prev] | [next] | [standalone]

#1704216 — Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac

On Fri, 2017-08-04 at 05:44 +0200, Borislav Petkov wrote:
> On Thu, Aug 03, 2017 at 03:57:49PM -0600, Toshi Kani wrote:
> > When 'osc_sb_apei_support_acked' is set, it indicates that
> > the platform supports APEI, firmware-first mode, as ACPI _OSC
> > capability bit 4, APEI Support, was set in query.  While _OSC
> > is an optional method, platforms with APEI support should
> > implement it to inform its capability to the OS properly.
> > 
> > Add check to 'osc_sb_apei_support_acked' before calling
> > ghes_edac_register() to restrict that ghes_edac is enabled
> > on platforms with APEI support capability set in _OSC.
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> > Cc: Tony Luck <tony.luck@intel.com>
> > ---
> >  drivers/acpi/apei/ghes.c |    8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > index d661d45..49d75eb 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -1139,9 +1139,11 @@ static int ghes_probe(struct platform_device
> > *ghes_dev)
> >  		goto err;
> >  	}
> >  
> > -	rc = ghes_edac_register(ghes, &ghes_dev->dev);
> > -	if (rc < 0)
> > -		goto err;
> > +	if (osc_sb_apei_support_acked) {
> 
> What for when we have the whitelist?

Some firmware features can be enabled / disabled in BIOS.  While HPE
firmware does not allow to disable FF, it's possible that other vendors
might allow such and still have the same OEM ID info.  So, this check
makes sure that FF is in fact enabled in firmware.

Thanks,
-Toshi

[toc] | [prev] | [next] | [standalone]

#1704568 — Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac

On Fri, Aug 04, 2017 at 08:49:51PM +0000, Kani, Toshimitsu wrote:
> Some firmware features can be enabled / disabled in BIOS.  While HPE
> firmware does not allow to disable FF, it's possible that other vendors
> might allow such and still have the same OEM ID info.

Yeah, we don't protect ourselves against "might allow". Either you have
an *actual* example for such platform or you don't and then you don't
need this check.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

[toc] | [prev] | [next] | [standalone]

#1705605 — Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac

On Sat, 2017-08-05 at 07:14 +0200, Borislav Petkov wrote:
> On Fri, Aug 04, 2017 at 08:49:51PM +0000, Kani, Toshimitsu wrote:
> > Some firmware features can be enabled / disabled in BIOS.  While
> > HPE firmware does not allow to disable FF, it's possible that other
> > vendors might allow such and still have the same OEM ID info.
> 
> Yeah, we don't protect ourselves against "might allow". Either you
> have an *actual* example for such platform or you don't and then you
> don't need this check.

No, I do not any actual example.  Will drop this patch.

Thanks,
-Toshi

[toc] | [prev] | [next] | [standalone]

#1703468 — [PATCH v2 2/7] intel_pstate: convert to use acpi_match_oemlist()

Convert to use acpi_match_oemlist() for the platform check.
There is no change in functionality.

Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
---
 drivers/cpufreq/intel_pstate.c |   64 ++++++++++++++++------------------------
 1 file changed, 25 insertions(+), 39 deletions(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 6cd5035..7944723 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -2475,39 +2475,31 @@ enum {
 	PPC,
 };
 
-struct hw_vendor_info {
-	u16  valid;
-	char oem_id[ACPI_OEM_ID_SIZE];
-	char oem_table_id[ACPI_OEM_TABLE_ID_SIZE];
-	int  oem_pwr_table;
-};
-
 /* Hardware vendor-specific info that has its own power management modes */
-static struct hw_vendor_info vendor_info[] __initdata = {
-	{1, "HP    ", "ProLiant", PSS},
-	{1, "ORACLE", "X4-2    ", PPC},
-	{1, "ORACLE", "X4-2L   ", PPC},
-	{1, "ORACLE", "X4-2B   ", PPC},
-	{1, "ORACLE", "X3-2    ", PPC},
-	{1, "ORACLE", "X3-2L   ", PPC},
-	{1, "ORACLE", "X3-2B   ", PPC},
-	{1, "ORACLE", "X4470M2 ", PPC},
-	{1, "ORACLE", "X4270M3 ", PPC},
-	{1, "ORACLE", "X4270M2 ", PPC},
-	{1, "ORACLE", "X4170M2 ", PPC},
-	{1, "ORACLE", "X4170 M3", PPC},
-	{1, "ORACLE", "X4275 M3", PPC},
-	{1, "ORACLE", "X6-2    ", PPC},
-	{1, "ORACLE", "Sudbury ", PPC},
-	{0, "", ""},
+static struct acpi_oemlist oemlist[] __initdata = {
+	{"HP    ", "ProLiant", 0, ACPI_SIG_FADT, all_versions, 0, PSS},
+	{"ORACLE", "X4-2    ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X4-2L   ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X4-2B   ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X3-2    ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X3-2L   ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X3-2B   ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X4470M2 ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X4270M3 ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X4270M2 ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X4170M2 ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X4170 M3", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X4275 M3", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "X6-2    ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{"ORACLE", "Sudbury ", 0, ACPI_SIG_FADT, all_versions, 0, PPC},
+	{ } /* End */
 };
 
 static bool __init intel_pstate_platform_pwr_mgmt_exists(void)
 {
-	struct acpi_table_header hdr;
-	struct hw_vendor_info *v_info;
 	const struct x86_cpu_id *id;
 	u64 misc_pwr;
+	int idx;
 
 	id = x86_match_cpu(intel_pstate_cpu_oob_ids);
 	if (id) {
@@ -2516,21 +2508,15 @@ static bool __init intel_pstate_platform_pwr_mgmt_exists(void)
 			return true;
 	}
 
-	if (acpi_disabled ||
-	    ACPI_FAILURE(acpi_get_table_header(ACPI_SIG_FADT, 0, &hdr)))
+	idx = acpi_match_oemlist(oemlist);
+	if (idx < 0)
 		return false;
 
-	for (v_info = vendor_info; v_info->valid; v_info++) {
-		if (!strncmp(hdr.oem_id, v_info->oem_id, ACPI_OEM_ID_SIZE) &&
-			!strncmp(hdr.oem_table_id, v_info->oem_table_id,
-						ACPI_OEM_TABLE_ID_SIZE))
-			switch (v_info->oem_pwr_table) {
-			case PSS:
-				return intel_pstate_no_acpi_pss();
-			case PPC:
-				return intel_pstate_has_acpi_ppc() &&
-					(!force_load);
-			}
+	switch (oemlist[idx].data) {
+	case PSS:
+		return intel_pstate_no_acpi_pss();
+	case PPC:
+		return intel_pstate_has_acpi_ppc() && !force_load;
 	}
 
 	return false;

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web