Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1704658 > unrolled thread

Re: [PATCH] platform/x86: ideapad-laptop: Expose conservation mode switch

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] platform/x86: ideapad-laptop: Expose conservation mode  switch Hao Wei Tee <angelsl@in04.sg> - 2017-08-05 17:20 +0200
    Re: [PATCH] platform/x86: ideapad-laptop: Expose conservation mode switch Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-06 20:40 +0200
      Re: [PATCH] platform/x86: ideapad-laptop: Expose conservation mode  switch Hao Wei Tee <angelsl@in04.sg> - 2017-08-07 15:30 +0200

#1704658 — Re: [PATCH] platform/x86: ideapad-laptop: Expose conservation mode switch

On 30/5/2017 21:22, Andy Shevchenko wrote:
> On Sun, May 28, 2017 at 4:47 PM, Hao Wei Tee <angelsl@angelsl.xyz> wrote:
>> On 5/27/17 3:31 PM, Hao Wei Tee wrote:
>>> This exposes the battery conservation mode present on some (?) IdeaPads.
>>> The mode is set by calling ACPI method SBMC with argument 3 (on) or
>>> 5 (off). Status is reported in bit 5 of the return value of ACPI method
>>> GBMD.
>>>
>>> This patch was written based on an IdeaPad U430p. I'm not sure if the ACPI
>>> methods are the same across all IdeaPads, so it would be great if this got more
>>> testing across other models before it's merged.
>>
>> I got someone to test on an IdeaPad Y510p. It works on that too.
> 
> Do we have any other option that expose something via sysfs?

It's been 2 months, what can I do to get this patch merged, or alternatively some other
way of exposing this switch?

-- 
Hao Wei

[toc] | [next] | [standalone]

#1704940 — Re: [PATCH] platform/x86: ideapad-laptop: Expose conservation mode switch

On Sat, Aug 5, 2017 at 6:18 PM, Hao Wei Tee <angelsl@in04.sg> wrote:
> On 30/5/2017 21:22, Andy Shevchenko wrote:
>> On Sun, May 28, 2017 at 4:47 PM, Hao Wei Tee <angelsl@angelsl.xyz> wrote:
>>> On 5/27/17 3:31 PM, Hao Wei Tee wrote:
>>>> This exposes the battery conservation mode present on some (?) IdeaPads.
>>>> The mode is set by calling ACPI method SBMC with argument 3 (on) or
>>>> 5 (off). Status is reported in bit 5 of the return value of ACPI method
>>>> GBMD.
>>>>
>>>> This patch was written based on an IdeaPad U430p. I'm not sure if the ACPI
>>>> methods are the same across all IdeaPads, so it would be great if this got more
>>>> testing across other models before it's merged.
>>>
>>> I got someone to test on an IdeaPad Y510p. It works on that too.
>>
>> Do we have any other option that expose something via sysfs?
>
> It's been 2 months, what can I do to get this patch merged, or alternatively some other
> way of exposing this switch?

Oh, sorry, I was pretty sure I have done something regarding to this
patch, but apparently not.

I'm fine with the change as long as we have no other option than sysfs here.
I'm on vacation for few more days, I will return to this after (ping
me let's say next Friday if you want to).

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1705514

On 7/8/2017 02:35, Andy Shevchenko wrote:
> On Sat, Aug 5, 2017 at 6:18 PM, Hao Wei Tee <angelsl@in04.sg> wrote:
>> On 30/5/2017 21:22, Andy Shevchenko wrote:
>>> On Sun, May 28, 2017 at 4:47 PM, Hao Wei Tee <angelsl@angelsl.xyz> wrote:
>>>> On 5/27/17 3:31 PM, Hao Wei Tee wrote:
>>>>> This exposes the battery conservation mode present on some (?) IdeaPads.
>>>>> The mode is set by calling ACPI method SBMC with argument 3 (on) or
>>>>> 5 (off). Status is reported in bit 5 of the return value of ACPI method
>>>>> GBMD.
>>>>>
>>>>> This patch was written based on an IdeaPad U430p. I'm not sure if the ACPI
>>>>> methods are the same across all IdeaPads, so it would be great if this got more
>>>>> testing across other models before it's merged.
>>>>
>>>> I got someone to test on an IdeaPad Y510p. It works on that too.
>>>
>>> Do we have any other option that expose something via sysfs?
>>
>> It's been 2 months, what can I do to get this patch merged, or alternatively some other
>> way of exposing this switch?
> 
> Oh, sorry, I was pretty sure I have done something regarding to this
> patch, but apparently not.
> 
> I'm fine with the change as long as we have no other option than sysfs here.

As far as I can tell most ACPI-related things are exposed via sysfs, and I think we only
have sysfs and ioctl to expose things like this anyway (correct me if I'm wrong, please).

> I'm on vacation for few more days, I will return to this after (ping
> me let's say next Friday if you want to).

Sorry for disturbing your vacation! Thanks again.

-- 
Hao Wei

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web