Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1701670 > unrolled thread
| Started by | NeilBrown <neilb@suse.com> |
|---|---|
| First post | 2017-08-02 05:30 +0200 |
| Last post | 2017-08-03 19:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] staging: lustre: fix minor typos in comments NeilBrown <neilb@suse.com> - 2017-08-02 05:30 +0200
Re: [lustre-devel] [PATCH] staging: lustre: fix minor typos in comments James Simmons <jsimmons@infradead.org> - 2017-08-03 19:30 +0200
| From | NeilBrown <neilb@suse.com> |
|---|---|
| Date | 2017-08-02 05:30 +0200 |
| Subject | [PATCH] staging: lustre: fix minor typos in comments |
| Message-ID | <u9Sw9-4q3-7@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Fix minor typos in comments.
Signed-off-by: NeilBrown <neilb@suse.com>
---
drivers/staging/lustre/lustre/llite/namei.c | 2 +-
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
index 8ed24ec1255d..7a1133661a65 100644
--- a/drivers/staging/lustre/lustre/llite/namei.c
+++ b/drivers/staging/lustre/lustre/llite/namei.c
@@ -488,7 +488,7 @@ static int ll_lookup_it_finish(struct ptlrpc_request *request,
*de = alias;
if (!it_disposition(it, DISP_LOOKUP_NEG)) {
- /* we have lookup look - unhide dentry */
+ /* We have the "lookup" lock, so unhide dentry */
if (bits & MDS_INODELOCK_LOOKUP)
d_lustre_revalidate(*de);
} else if (!it_disposition(it, DISP_OPEN_CREATE)) {
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
index 3eb66cea65db..ae97c6f1aeb0 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_locks.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
@@ -1030,7 +1030,7 @@ int mdc_revalidate_lock(struct obd_export *exp, struct lookup_intent *it,
* If we're performing a creation, that means that unless the creation
* failed with EEXIST, we should fake up a negative dentry.
*
- * For everything else, we want to lookup to succeed.
+ * For everything else, we want the lookup to succeed.
*
* One additional note: if CREATE or OPEN succeeded, we add an extra
* reference to the request because we need to keep it around until
@@ -1040,7 +1040,7 @@ int mdc_revalidate_lock(struct obd_export *exp, struct lookup_intent *it,
* exactly what it_status refers to.
*
* If DISP_OPEN_OPEN is set, then it_status refers to the open() call,
- * otherwise if DISP_OPEN_CREATE is set, then it status is the
+ * otherwise if DISP_OPEN_CREATE is set, then it_status is the
* creation failure mode. In either case, one of DISP_LOOKUP_NEG or
* DISP_LOOKUP_POS will be set, indicating whether the child lookup
* was successful.
--
2.12.2
[toc] | [next] | [standalone]
| From | James Simmons <jsimmons@infradead.org> |
|---|---|
| Date | 2017-08-03 19:30 +0200 |
| Subject | Re: [lustre-devel] [PATCH] staging: lustre: fix minor typos in comments |
| Message-ID | <uas6D-3bf-41@gated-at.bofh.it> |
| In reply to | #1701670 |
> Fix minor typos in comments.
Acked-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> drivers/staging/lustre/lustre/llite/namei.c | 2 +-
> drivers/staging/lustre/lustre/mdc/mdc_locks.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
> index 8ed24ec1255d..7a1133661a65 100644
> --- a/drivers/staging/lustre/lustre/llite/namei.c
> +++ b/drivers/staging/lustre/lustre/llite/namei.c
> @@ -488,7 +488,7 @@ static int ll_lookup_it_finish(struct ptlrpc_request *request,
> *de = alias;
>
> if (!it_disposition(it, DISP_LOOKUP_NEG)) {
> - /* we have lookup look - unhide dentry */
> + /* We have the "lookup" lock, so unhide dentry */
> if (bits & MDS_INODELOCK_LOOKUP)
> d_lustre_revalidate(*de);
> } else if (!it_disposition(it, DISP_OPEN_CREATE)) {
> diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
> index 3eb66cea65db..ae97c6f1aeb0 100644
> --- a/drivers/staging/lustre/lustre/mdc/mdc_locks.c
> +++ b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
> @@ -1030,7 +1030,7 @@ int mdc_revalidate_lock(struct obd_export *exp, struct lookup_intent *it,
> * If we're performing a creation, that means that unless the creation
> * failed with EEXIST, we should fake up a negative dentry.
> *
> - * For everything else, we want to lookup to succeed.
> + * For everything else, we want the lookup to succeed.
> *
> * One additional note: if CREATE or OPEN succeeded, we add an extra
> * reference to the request because we need to keep it around until
> @@ -1040,7 +1040,7 @@ int mdc_revalidate_lock(struct obd_export *exp, struct lookup_intent *it,
> * exactly what it_status refers to.
> *
> * If DISP_OPEN_OPEN is set, then it_status refers to the open() call,
> - * otherwise if DISP_OPEN_CREATE is set, then it status is the
> + * otherwise if DISP_OPEN_CREATE is set, then it_status is the
> * creation failure mode. In either case, one of DISP_LOOKUP_NEG or
> * DISP_LOOKUP_POS will be set, indicating whether the child lookup
> * was successful.
> --
> 2.12.2
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web