Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1701698 > unrolled thread

[PATCH] staging: lustre: declare fiemap_for_stripe static

Started byDavid Wittman <dwittman@gmail.com>
First post2017-08-02 06:30 +0200
Last post2017-08-03 19:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] staging: lustre: declare fiemap_for_stripe static David Wittman <dwittman@gmail.com> - 2017-08-02 06:30 +0200
    Re: [PATCH] staging: lustre: declare fiemap_for_stripe static James Simmons <jsimmons@infradead.org> - 2017-08-03 19:30 +0200

#1701698 — [PATCH] staging: lustre: declare fiemap_for_stripe static

FromDavid Wittman <dwittman@gmail.com>
Date2017-08-02 06:30 +0200
Subject[PATCH] staging: lustre: declare fiemap_for_stripe static
Message-ID<u9Tsd-55X-5@gated-at.bofh.it>
Declare fiemap_for_stripe as static to fix sparse warnings:

> warning: symbol 'fiemap_for_stripe' was not declared. Should it be
> static?

Signed-off-by: David Wittman <dwittman@gmail.com>
---
 drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
index 8fc0bcc..334ecb1 100644
--- a/drivers/staging/lustre/lustre/lov/lov_object.c
+++ b/drivers/staging/lustre/lustre/lov/lov_object.c
@@ -1141,11 +1141,11 @@ struct fiemap_state {
 	bool		fs_enough;
 };
 
-int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
-		      struct lov_stripe_md *lsm,
-		      struct fiemap *fiemap, size_t *buflen,
-		      struct ll_fiemap_info_key *fmkey, int stripeno,
-		      struct fiemap_state *fs)
+static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
+			     struct lov_stripe_md *lsm,
+			     struct fiemap *fiemap, size_t *buflen,
+			     struct ll_fiemap_info_key *fmkey, int stripeno,
+			     struct fiemap_state *fs)
 {
 	struct cl_object *subobj;
 	struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov;
-- 
2.7.4

[toc] | [next] | [standalone]


#1703302

FromJames Simmons <jsimmons@infradead.org>
Date2017-08-03 19:30 +0200
Message-ID<uas6C-3bf-27@gated-at.bofh.it>
In reply to#1701698
> Declare fiemap_for_stripe as static to fix sparse warnings:
> 
> > warning: symbol 'fiemap_for_stripe' was not declared. Should it be
> > static?

Acked-by: James Simmons <jsimmons@infradead.org>
 
> Signed-off-by: David Wittman <dwittman@gmail.com>
> ---
>  drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index 8fc0bcc..334ecb1 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -1141,11 +1141,11 @@ struct fiemap_state {
>  	bool		fs_enough;
>  };
>  
> -int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
> -		      struct lov_stripe_md *lsm,
> -		      struct fiemap *fiemap, size_t *buflen,
> -		      struct ll_fiemap_info_key *fmkey, int stripeno,
> -		      struct fiemap_state *fs)
> +static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
> +			     struct lov_stripe_md *lsm,
> +			     struct fiemap *fiemap, size_t *buflen,
> +			     struct ll_fiemap_info_key *fmkey, int stripeno,
> +			     struct fiemap_state *fs)
>  {
>  	struct cl_object *subobj;
>  	struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov;
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web