Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1702401 > unrolled thread
| Started by | Martin Kaiser <martin@kaiser.cx> |
|---|---|
| First post | 2017-08-02 22:10 +0200 |
| Last post | 2017-08-05 07:40 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM: dts: i.MX25: add ranges to tscadc Martin Kaiser <martin@kaiser.cx> - 2017-08-02 22:10 +0200
Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc Shawn Guo <shawnguo@kernel.org> - 2017-08-03 04:30 +0200
Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc Martin Kaiser <martin@kaiser.cx> - 2017-08-03 18:40 +0200
Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc Shawn Guo <shawnguo@kernel.org> - 2017-08-05 07:40 +0200
| From | Martin Kaiser <martin@kaiser.cx> |
|---|---|
| Date | 2017-08-02 22:10 +0200 |
| Subject | [PATCH] ARM: dts: i.MX25: add ranges to tscadc |
| Message-ID | <ua87U-6eM-7@gated-at.bofh.it> |
Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
the addresses used by tscadc and those in its child nodes (adc, tsc).
Without such a mapping, the reg = ... lines in the tsc and adc nodes do
not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
drivers will then fail since there's no IORESOURCE_MEM.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
arch/arm/boot/dts/imx25.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index 0d2f3a1..1e37bd3 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -297,6 +297,7 @@
#address-cells = <1>;
#size-cells = <1>;
status = "disabled";
+ ranges;
adc: adc@50030800 {
compatible = "fsl,imx25-gcq";
--
2.1.4
[toc] | [next] | [standalone]
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2017-08-03 04:30 +0200 |
| Message-ID | <uae3E-1Qv-3@gated-at.bofh.it> |
| In reply to | #1702401 |
On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> the addresses used by tscadc and those in its child nodes (adc, tsc).
>
> Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> drivers will then fail since there's no IORESOURCE_MEM.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Do we need the following Fixes tag?
Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")
@Markus, we didn't the changes when we were submitting?
Shawn
> ---
> arch/arm/boot/dts/imx25.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 0d2f3a1..1e37bd3 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -297,6 +297,7 @@
> #address-cells = <1>;
> #size-cells = <1>;
> status = "disabled";
> + ranges;
>
> adc: adc@50030800 {
> compatible = "fsl,imx25-gcq";
> --
> 2.1.4
>
[toc] | [prev] | [next] | [standalone]
| From | Martin Kaiser <martin@kaiser.cx> |
|---|---|
| Date | 2017-08-03 18:40 +0200 |
| Message-ID | <uarkd-2yP-3@gated-at.bofh.it> |
| In reply to | #1702624 |
Hi Shawn,
Thus wrote Shawn Guo (shawnguo@kernel.org):
> On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> > the addresses used by tscadc and those in its child nodes (adc, tsc).
> > Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> > drivers will then fail since there's no IORESOURCE_MEM.
> > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> Do we need the following Fixes tag?
> Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")
yes, looks like this has never worked correctly.
If you're ok with the fix, I can add the tag in v2.
> @Markus, we didn't the changes when we were submitting?
Both Markus' and Denis' mail addresses bounced...
Best regards,
Martin
[toc] | [prev] | [next] | [standalone]
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2017-08-05 07:40 +0200 |
| Message-ID | <uaZYC-xF-13@gated-at.bofh.it> |
| In reply to | #1703258 |
On Thu, Aug 03, 2017 at 06:29:48PM +0200, Martin Kaiser wrote:
> Hi Shawn,
>
> Thus wrote Shawn Guo (shawnguo@kernel.org):
>
> > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> > > the addresses used by tscadc and those in its child nodes (adc, tsc).
>
> > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> > > drivers will then fail since there's no IORESOURCE_MEM.
>
> > > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
>
> > Do we need the following Fixes tag?
>
> > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")
>
> yes, looks like this has never worked correctly.
>
> If you're ok with the fix, I can add the tag in v2.
I added the Fixes tag and applied the patch. Thanks.
Shawn
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web