Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1703290 > unrolled thread

[PATCH 5/5] PCI: hotplug: cpqphp: constify pci_device_id.

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-08-03 19:20 +0200
Last post2017-08-03 19:20 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 5/5] PCI: hotplug: cpqphp: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 19:20 +0200

#1703290 — [PATCH 5/5] PCI: hotplug: cpqphp: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-03 19:20 +0200
Subject[PATCH 5/5] PCI: hotplug: cpqphp: constify pci_device_id.
Message-ID<uarWW-37e-9@gated-at.bofh.it>
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/pci/hotplug/cpqphp_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
index 33d300d..4d06b84 100644
--- a/drivers/pci/hotplug/cpqphp_core.c
+++ b/drivers/pci/hotplug/cpqphp_core.c
@@ -1417,7 +1417,7 @@ static void __exit unload_cpqphpd(void)
 		iounmap(smbios_start);
 }
 
-static struct pci_device_id hpcd_pci_tbl[] = {
+static const struct pci_device_id hpcd_pci_tbl[] = {
 	{
 	/* handle any PCI Hotplug controller */
 	.class =        ((PCI_CLASS_SYSTEM_PCI_HOTPLUG << 8) | 0x00),
-- 
2.7.4

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web