Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1703223 > unrolled thread
| Started by | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| First post | 2017-08-03 18:10 +0200 |
| Last post | 2017-08-10 17:30 +0200 |
| Articles | 6 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] ASoC: make snd_soc_codec_driver structures const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-03 18:10 +0200
[PATCH 2/2] ASoC: sunxi: make snd_soc_codec_driver structures as const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-03 18:10 +0200
Applied "ASoC: sunxi: make snd_soc_codec_driver structures as const" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-07 14:00 +0200
Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures Bhumika Goyal <bhumirks@gmail.com> - 2017-08-10 17:30 +0200
Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures Mark Brown <broonie@kernel.org> - 2017-08-10 17:40 +0200
Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures Mark Brown <broonie@kernel.org> - 2017-08-10 17:30 +0200
| From | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| Date | 2017-08-03 18:10 +0200 |
| Subject | [PATCH 0/2] ASoC: make snd_soc_codec_driver structures const |
| Message-ID | <uaqRc-2ml-9@gated-at.bofh.it> |
Declare snd_soc_codec_driver structures as const. Bhumika Goyal (2): ASoC: codecs: add const to snd_soc_codec_driver structures ASoC: sunxi: make snd_soc_codec_driver structures as const sound/soc/codecs/88pm860x-codec.c | 2 +- sound/soc/codecs/ab8500-codec.c | 2 +- sound/soc/codecs/ac97.c | 2 +- sound/soc/codecs/ad1836.c | 2 +- sound/soc/codecs/ad193x.c | 2 +- sound/soc/codecs/ad1980.c | 2 +- sound/soc/codecs/ad73311.c | 2 +- sound/soc/codecs/adau1373.c | 2 +- sound/soc/codecs/adau1701.c | 2 +- sound/soc/codecs/adau1977.c | 2 +- sound/soc/codecs/adav80x.c | 2 +- sound/soc/codecs/ads117x.c | 2 +- sound/soc/codecs/ak4104.c | 2 +- sound/soc/codecs/ak4535.c | 2 +- sound/soc/codecs/ak4554.c | 2 +- sound/soc/codecs/ak4613.c | 2 +- sound/soc/codecs/ak4641.c | 2 +- sound/soc/codecs/ak4642.c | 2 +- sound/soc/codecs/ak4671.c | 2 +- sound/soc/codecs/ak5386.c | 2 +- sound/soc/codecs/alc5623.c | 2 +- sound/soc/codecs/bt-sco.c | 2 +- sound/soc/codecs/cq93vc.c | 2 +- sound/soc/codecs/cs35l33.c | 2 +- sound/soc/codecs/cs35l34.c | 2 +- sound/soc/codecs/cs35l35.c | 2 +- sound/soc/codecs/cs4271.c | 2 +- sound/soc/codecs/cs42l51.c | 2 +- sound/soc/codecs/cs4349.c | 2 +- sound/soc/codecs/cs47l24.c | 2 +- sound/soc/codecs/cs53l30.c | 2 +- sound/soc/codecs/cx20442.c | 2 +- sound/soc/codecs/da7210.c | 2 +- sound/soc/codecs/da7213.c | 2 +- sound/soc/codecs/da7218.c | 2 +- sound/soc/codecs/da7219.c | 2 +- sound/soc/codecs/da732x.c | 2 +- sound/soc/codecs/da9055.c | 2 +- sound/soc/codecs/dmic.c | 2 +- sound/soc/codecs/es7134.c | 2 +- sound/soc/codecs/es8316.c | 2 +- sound/soc/codecs/es8328.c | 2 +- sound/soc/codecs/hdac_hdmi.c | 2 +- sound/soc/codecs/hdmi-codec.c | 2 +- sound/soc/codecs/ics43432.c | 2 +- sound/soc/codecs/inno_rk3036.c | 2 +- sound/soc/codecs/isabelle.c | 2 +- sound/soc/codecs/jz4740.c | 2 +- sound/soc/codecs/lm49453.c | 2 +- sound/soc/codecs/max98088.c | 2 +- sound/soc/codecs/max98090.c | 2 +- sound/soc/codecs/max98095.c | 2 +- sound/soc/codecs/max98357a.c | 2 +- sound/soc/codecs/max9850.c | 2 +- sound/soc/codecs/max9860.c | 2 +- sound/soc/codecs/max9867.c | 2 +- sound/soc/codecs/max98926.c | 2 +- sound/soc/codecs/mc13783.c | 2 +- sound/soc/codecs/ml26124.c | 2 +- sound/soc/codecs/msm8916-wcd-analog.c | 2 +- sound/soc/codecs/msm8916-wcd-digital.c | 2 +- sound/soc/codecs/nau8540.c | 2 +- sound/soc/codecs/nau8810.c | 2 +- sound/soc/codecs/nau8824.c | 2 +- sound/soc/codecs/nau8825.c | 2 +- sound/soc/codecs/pcm1681.c | 2 +- sound/soc/codecs/pcm179x.c | 2 +- sound/soc/codecs/pcm3008.c | 2 +- sound/soc/codecs/pcm512x.c | 2 +- sound/soc/codecs/rt274.c | 2 +- sound/soc/codecs/rt286.c | 2 +- sound/soc/codecs/rt298.c | 2 +- sound/soc/codecs/rt5514.c | 2 +- sound/soc/codecs/rt5616.c | 2 +- sound/soc/codecs/rt5631.c | 2 +- sound/soc/codecs/rt5640.c | 2 +- sound/soc/codecs/rt5645.c | 2 +- sound/soc/codecs/rt5651.c | 2 +- sound/soc/codecs/rt5659.c | 2 +- sound/soc/codecs/rt5660.c | 2 +- sound/soc/codecs/rt5663.c | 2 +- sound/soc/codecs/rt5665.c | 2 +- sound/soc/codecs/rt5670.c | 2 +- sound/soc/codecs/rt5677.c | 2 +- sound/soc/codecs/sgtl5000.c | 2 +- sound/soc/codecs/si476x.c | 2 +- sound/soc/codecs/sirf-audio-codec.c | 2 +- sound/soc/codecs/sn95031.c | 2 +- sound/soc/codecs/spdif_receiver.c | 2 +- sound/soc/codecs/spdif_transmitter.c | 2 +- sound/soc/codecs/ssm2518.c | 2 +- sound/soc/codecs/ssm2602.c | 2 +- sound/soc/codecs/ssm4567.c | 2 +- sound/soc/codecs/stac9766.c | 2 +- sound/soc/codecs/tas2552.c | 2 +- sound/soc/codecs/tas5086.c | 2 +- sound/soc/codecs/tas5720.c | 2 +- sound/soc/codecs/tlv320aic23.c | 2 +- sound/soc/codecs/tlv320aic26.c | 2 +- sound/soc/codecs/tlv320aic31xx.c | 2 +- sound/soc/codecs/tlv320aic32x4.c | 2 +- sound/soc/codecs/tlv320aic3x.c | 2 +- sound/soc/codecs/tlv320dac33.c | 2 +- sound/soc/codecs/twl4030.c | 2 +- sound/soc/codecs/twl6040.c | 2 +- sound/soc/codecs/uda134x.c | 2 +- sound/soc/codecs/uda1380.c | 2 +- sound/soc/codecs/wl1273.c | 2 +- sound/soc/codecs/zx_aud96p22.c | 2 +- sound/soc/sunxi/sun4i-codec.c | 6 +++--- sound/soc/sunxi/sun8i-codec.c | 2 +- 111 files changed, 113 insertions(+), 113 deletions(-) -- 1.9.1
[toc] | [next] | [standalone]
| From | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| Date | 2017-08-03 18:10 +0200 |
| Subject | [PATCH 2/2] ASoC: sunxi: make snd_soc_codec_driver structures as const |
| Message-ID | <uaqRc-2ml-15@gated-at.bofh.it> |
| In reply to | #1703223 |
Declare snd_soc_codec_driver structures as const as they are either
passed as an argument to the function snd_soc_register_codec or stored as
reference in field codec of type sun4i_codec_quirks. Both the fucntion
argument and the codec field are of type const, so declare the
structures with this property as const.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
sound/soc/sunxi/sun4i-codec.c | 6 +++---
sound/soc/sunxi/sun8i-codec.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
index 73d054f..c668b8b 100644
--- a/sound/soc/sunxi/sun4i-codec.c
+++ b/sound/soc/sunxi/sun4i-codec.c
@@ -762,7 +762,7 @@ static void sun4i_codec_shutdown(struct snd_pcm_substream *substream,
{ "Mic1", NULL, "VMIC" },
};
-static struct snd_soc_codec_driver sun4i_codec_codec = {
+static const struct snd_soc_codec_driver sun4i_codec_codec = {
.component_driver = {
.controls = sun4i_codec_controls,
.num_controls = ARRAY_SIZE(sun4i_codec_controls),
@@ -1068,7 +1068,7 @@ static const DECLARE_TLV_DB_RANGE(sun6i_codec_mic_gain_scale,
{ "Right ADC", NULL, "Right ADC Mixer" },
};
-static struct snd_soc_codec_driver sun6i_codec_codec = {
+static const struct snd_soc_codec_driver sun6i_codec_codec = {
.component_driver = {
.controls = sun6i_codec_codec_widgets,
.num_controls = ARRAY_SIZE(sun6i_codec_codec_widgets),
@@ -1096,7 +1096,7 @@ static const DECLARE_TLV_DB_RANGE(sun6i_codec_mic_gain_scale,
};
-static struct snd_soc_codec_driver sun8i_a23_codec_codec = {
+static const struct snd_soc_codec_driver sun8i_a23_codec_codec = {
.component_driver = {
.controls = sun8i_a23_codec_codec_controls,
.num_controls = ARRAY_SIZE(sun8i_a23_codec_codec_controls),
diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi/sun8i-codec.c
index 253ae0b..abfb710 100644
--- a/sound/soc/sunxi/sun8i-codec.c
+++ b/sound/soc/sunxi/sun8i-codec.c
@@ -360,7 +360,7 @@ static int sun8i_codec_hw_params(struct snd_pcm_substream *substream,
.ops = &sun8i_codec_dai_ops,
};
-static struct snd_soc_codec_driver sun8i_soc_codec = {
+static const struct snd_soc_codec_driver sun8i_soc_codec = {
.component_driver = {
.dapm_widgets = sun8i_codec_dapm_widgets,
.num_dapm_widgets = ARRAY_SIZE(sun8i_codec_dapm_widgets),
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-08-07 14:00 +0200 |
| Subject | Applied "ASoC: sunxi: make snd_soc_codec_driver structures as const" to the asoc tree |
| Message-ID | <ubORt-7Id-51@gated-at.bofh.it> |
| In reply to | #1703225 |
The patch
ASoC: sunxi: make snd_soc_codec_driver structures as const
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 92ff5d085ecc8255600551055262bf98a8f3f1d0 Mon Sep 17 00:00:00 2001
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Thu, 3 Aug 2017 21:30:20 +0530
Subject: [PATCH] ASoC: sunxi: make snd_soc_codec_driver structures as const
Declare snd_soc_codec_driver structures as const as they are either
passed as an argument to the function snd_soc_register_codec or stored as
reference in field codec of type sun4i_codec_quirks. Both the fucntion
argument and the codec field are of type const, so declare the
structures with this property as const.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/sunxi/sun4i-codec.c | 6 +++---
sound/soc/sunxi/sun8i-codec.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
index 73d054f466c2..c668b8b08b38 100644
--- a/sound/soc/sunxi/sun4i-codec.c
+++ b/sound/soc/sunxi/sun4i-codec.c
@@ -762,7 +762,7 @@ static const struct snd_soc_dapm_route sun4i_codec_codec_dapm_routes[] = {
{ "Mic1", NULL, "VMIC" },
};
-static struct snd_soc_codec_driver sun4i_codec_codec = {
+static const struct snd_soc_codec_driver sun4i_codec_codec = {
.component_driver = {
.controls = sun4i_codec_controls,
.num_controls = ARRAY_SIZE(sun4i_codec_controls),
@@ -1068,7 +1068,7 @@ static const struct snd_soc_dapm_route sun6i_codec_codec_dapm_routes[] = {
{ "Right ADC", NULL, "Right ADC Mixer" },
};
-static struct snd_soc_codec_driver sun6i_codec_codec = {
+static const struct snd_soc_codec_driver sun6i_codec_codec = {
.component_driver = {
.controls = sun6i_codec_codec_widgets,
.num_controls = ARRAY_SIZE(sun6i_codec_codec_widgets),
@@ -1096,7 +1096,7 @@ static const struct snd_soc_dapm_widget sun8i_a23_codec_codec_widgets[] = {
};
-static struct snd_soc_codec_driver sun8i_a23_codec_codec = {
+static const struct snd_soc_codec_driver sun8i_a23_codec_codec = {
.component_driver = {
.controls = sun8i_a23_codec_codec_controls,
.num_controls = ARRAY_SIZE(sun8i_a23_codec_codec_controls),
diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi/sun8i-codec.c
index 253ae0b5a4d4..abfb710df7cb 100644
--- a/sound/soc/sunxi/sun8i-codec.c
+++ b/sound/soc/sunxi/sun8i-codec.c
@@ -360,7 +360,7 @@ static struct snd_soc_dai_driver sun8i_codec_dai = {
.ops = &sun8i_codec_dai_ops,
};
-static struct snd_soc_codec_driver sun8i_soc_codec = {
+static const struct snd_soc_codec_driver sun8i_soc_codec = {
.component_driver = {
.dapm_widgets = sun8i_codec_dapm_widgets,
.num_dapm_widgets = ARRAY_SIZE(sun8i_codec_dapm_widgets),
--
2.13.3
[toc] | [prev] | [next] | [standalone]
| From | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| Date | 2017-08-10 17:30 +0200 |
| Subject | Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures |
| Message-ID | <ucXzk-7tV-17@gated-at.bofh.it> |
| In reply to | #1703223 |
On Thu, Aug 10, 2017 at 8:50 PM, Mark Brown <broonie@kernel.org> wrote: > On Thu, Aug 03, 2017 at 09:30:19PM +0530, Bhumika Goyal wrote: > >> sound/soc/codecs/88pm860x-codec.c | 2 +- >> sound/soc/codecs/ab8500-codec.c | 2 +- >> sound/soc/codecs/ac97.c | 2 +- >> sound/soc/codecs/ad1836.c | 2 +- >> sound/soc/codecs/ad193x.c | 2 +- >> sound/soc/codecs/ad1980.c | 2 +- >> sound/soc/codecs/ad73311.c | 2 +- >> sound/soc/codecs/adau1373.c | 2 +- >> sound/soc/codecs/adau1701.c | 2 +- > > This is difficult to apply against current code as it is a single commit > over lots of files but the ASoC tree has lots of branches. I've figured > out the dependencies but it's easier to split things up (and avoids > collisions with other changes causing the whole thing to not apply). Thanks for the response. Should I make separate patches for each file or is there another way to split this patch? Thanks, Bhumika
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-08-10 17:40 +0200 |
| Subject | Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures |
| Message-ID | <ucXJ0-7xc-3@gated-at.bofh.it> |
| In reply to | #1708729 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Aug 10, 2017 at 08:56:35PM +0530, Bhumika Goyal wrote: > On Thu, Aug 10, 2017 at 8:50 PM, Mark Brown <broonie@kernel.org> wrote: > > This is difficult to apply against current code as it is a single commit > > over lots of files but the ASoC tree has lots of branches. I've figured > > out the dependencies but it's easier to split things up (and avoids > > collisions with other changes causing the whole thing to not apply). > Thanks for the response. > Should I make separate patches for each file or is there another way > to split this patch? Splitting per driver would've been easier, or saying exactly where it applies if you don't split it. Like I say I figured it out for this one.
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-08-10 17:30 +0200 |
| Subject | Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures |
| Message-ID | <ucXzk-7tV-19@gated-at.bofh.it> |
| In reply to | #1703223 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Aug 03, 2017 at 09:30:19PM +0530, Bhumika Goyal wrote: > sound/soc/codecs/88pm860x-codec.c | 2 +- > sound/soc/codecs/ab8500-codec.c | 2 +- > sound/soc/codecs/ac97.c | 2 +- > sound/soc/codecs/ad1836.c | 2 +- > sound/soc/codecs/ad193x.c | 2 +- > sound/soc/codecs/ad1980.c | 2 +- > sound/soc/codecs/ad73311.c | 2 +- > sound/soc/codecs/adau1373.c | 2 +- > sound/soc/codecs/adau1701.c | 2 +- This is difficult to apply against current code as it is a single commit over lots of files but the ASoC tree has lots of branches. I've figured out the dependencies but it's easier to split things up (and avoids collisions with other changes causing the whole thing to not apply).
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web