Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702726 > unrolled thread

Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C controller documentation

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C  controller documentation Baolin Wang <baolin.wang@linaro.org> - 2017-08-03 09:30 +0200
    Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C  controller documentation Baolin Wang <baolin.wang@linaro.org> - 2017-08-03 10:50 +0200
      Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C  controller documentation Baolin Wang <baolin.wang@linaro.org> - 2017-08-03 11:10 +0200
      Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C  controller documentation Wolfram Sang <wsa@the-dreams.de> - 2017-08-03 11:10 +0200

#1702726 — Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C controller documentation

Hi Wolfram,

On 27 July 2017 at 17:29, Baolin Wang <baolin.wang@linaro.org> wrote:
> Hi Wolfram,
>
> On 24 July 2017 at 14:51, Baolin Wang <baolin.wang@spreadtrum.com> wrote:
>> Hi Wolfram,
>>
>> On 五,  7月 14, 2017 at 05:01:10下午 +0800, Baolin Wang wrote:
>>> This patch adds the binding documentation for Spreadtrum I2C
>>> controller device.
>>>
>>> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> ---
>>> Changes since v3:
>>>  - Add Ack from RobH.
>>>
>>> Changes since v2:
>>>  - Change compatible strings to be SoC specific.
>>>
>>> Changes since v1:
>>>  - No updates.
>>> ---
>>
>> Could you apply this patchset if there are no other comments?
>> It is a long time since the v4 was send out. Thanks.
>
> Ping?

Since this patchset has waited for a long time, could you pick up this
patchset into your branch? Thanks.

>
>>
>>>  Documentation/devicetree/bindings/i2c/i2c-sprd.txt |   31 ++++++++++++++++++++
>>>  1 file changed, 31 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-sprd.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-sprd.txt b/Documentation/devicetree/bindings/i2c/i2c-sprd.txt
>>> new file mode 100644
>>> index 0000000..60b7cda
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/i2c/i2c-sprd.txt
>>> @@ -0,0 +1,31 @@
>>> +I2C for Spreadtrum platforms
>>> +
>>> +Required properties:
>>> +- compatible: Should be "sprd,sc9860-i2c".
>>> +- reg: Specify the physical base address of the controller and length
>>> +  of memory mapped region.
>>> +- interrupts: Should contain I2C interrupt.
>>> +- clock-names: Should contain following entries:
>>> +  "i2c" for I2C clock,
>>> +  "source" for I2C source (parent) clock,
>>> +  "enable" for I2C module enable clock.
>>> +- clocks: Should contain a clock specifier for each entry in clock-names.
>>> +- clock-frequency: Constains desired I2C bus clock frequency in Hz.
>>> +- #address-cells: Should be 1 to describe address cells for I2C device address.
>>> +- #size-cells: Should be 0 means no size cell for I2C device address.
>>> +
>>> +Optional properties:
>>> +- Child nodes conforming to I2C bus binding
>>> +
>>> +Examples:
>>> +i2c0: i2c@70500000 {
>>> +     compatible = "sprd,sc9860-i2c";
>>> +     reg = <0 0x70500000 0 0x1000>;
>>> +     interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
>>> +     clock-names = "i2c", "source", "enable";
>>> +     clocks = <&clk_i2c3>, <&ext_26m>, <&clk_ap_apb_gates 11>;
>>> +     clock-frequency = <400000>;
>>> +     #address-cells = <1>;
>>> +     #size-cells = <0>;
>>> +};
>>> +
>>> --
>>> 1.7.9.5
>>>
>
>
>
> --
> Baolin.wang
> Best Regards



-- 
Baolin.wang
Best Regards

[toc] | [next] | [standalone]

#1702794

On 3 August 2017 at 16:26, Peter Rosin <peda@axentia.se> wrote:
> On 2017-08-03 09:29, Baolin Wang wrote:
>> Hi Wolfram,
>>
>> On 27 July 2017 at 17:29, Baolin Wang <baolin.wang@linaro.org> wrote:
>>> Hi Wolfram,
>>>
>>> On 24 July 2017 at 14:51, Baolin Wang <baolin.wang@spreadtrum.com> wrote:
>>>> Hi Wolfram,
>>>>
>>>> On 五,  7月 14, 2017 at 05:01:10下午 +0800, Baolin Wang wrote:
>>>>> This patch adds the binding documentation for Spreadtrum I2C
>>>>> controller device.
>>>>>
>>>>> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
>>>>> Acked-by: Rob Herring <robh@kernel.org>
>>>>> ---
>>>>> Changes since v3:
>>>>>  - Add Ack from RobH.
>>>>>
>>>>> Changes since v2:
>>>>>  - Change compatible strings to be SoC specific.
>>>>>
>>>>> Changes since v1:
>>>>>  - No updates.
>>>>> ---
>>>>
>>>> Could you apply this patchset if there are no other comments?
>>>> It is a long time since the v4 was send out. Thanks.
>>>
>>> Ping?
>>
>> Since this patchset has waited for a long time, could you pick up this
>> patchset into your branch? Thanks.
>
> Please calm down. You first sent v4 4 weeks ago in the beginning of the
> merge window when everybody are supposedly looking at the integration of
> the work from the previous cycle. You have managed to send remainders
> four times in those few weeks.
>
> Four weeks is not a "long time", and it's not like you didn't get any
> feedback. Part of that feedback was that there was room for improvement.
> Have you looked into that? Or have you been busy sending pings? I'm sure
> Wolfram will pick the series in time for the next merge window if he's
> happy with it, there was that thing about room for improvement...

Sorry for noise. I just afraid Wolfram missed this patchset since I
did not get any comments from V4.

Yes, I've looked at  how to improve, one thing is we can change
readb/writeb to readsb/writesb. I will submit one patch to fix this
after Andy's patches which fixing the readsb/writesb issue on x86
platform were merged. Anyway I will be keep patient and wait for
comments. Thanks.

-- 
Baolin.wang
Best Regards

[toc] | [prev] | [next] | [standalone]

#1702805

Hi Wolfram,

On 3 August 2017 at 17:00, Wolfram Sang <wsa@the-dreams.de> wrote:
> Hi,
>
>> Sorry for noise. I just afraid Wolfram missed this patchset since I
>> did not get any comments from V4.
>
> I use patchwork. Patches don't get lost :)
>
> Anyway, I nearly finished a document I can point people to when they
> wonder what happened about their patches.
>
> I hope this will help because I don't have the bandwidth to reply to
> ping mails individually and explain the situation.

That's great. I can understand and thanks for your feedback. I will
keep calm down and wit for comments.

-- 
Baolin.wang
Best Regards

[toc] | [prev] | [next] | [standalone]

#1702808

[Multipart message — attachments visible in raw view] — view raw

Hi,

> Sorry for noise. I just afraid Wolfram missed this patchset since I
> did not get any comments from V4.

I use patchwork. Patches don't get lost :)

Anyway, I nearly finished a document I can point people to when they
wonder what happened about their patches.

I hope this will help because I don't have the bandwidth to reply to
ping mails individually and explain the situation.

Regards,

   Wolfram

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web