Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1704229 > unrolled thread
| Started by | Icenowy Zheng <icenowy@aosc.io> |
|---|---|
| First post | 2017-08-04 23:40 +0200 |
| Last post | 2017-08-06 04:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] mmc: sunxi: fix support for new timings mode only SoCs Icenowy Zheng <icenowy@aosc.io> - 2017-08-04 23:40 +0200
Re: [linux-sunxi] [PATCH 1/2] mmc: sunxi: fix support for new timings mode only SoCs Chen-Yu Tsai <wens@csie.org> - 2017-08-06 04:10 +0200
| From | Icenowy Zheng <icenowy@aosc.io> |
|---|---|
| Date | 2017-08-04 23:40 +0200 |
| Subject | [PATCH 1/2] mmc: sunxi: fix support for new timings mode only SoCs |
| Message-ID | <uaSu6-40A-5@gated-at.bofh.it> |
The A83T MMC support code introduces the timings mode switch, however
such a switch doesn't exist on new SoCs with only new timings mode.
Only execute the switch if the SoC really have the timings mode switch,
to fix the regression shown on new timings mode only SoCs (A64, H5,
etc).
Fixes: b0600daebf31 ("mmc: sunxi: Support controllers that can use both
old and new timings")
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
drivers/mmc/host/sunxi-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 3777517982dd..59aba93beffb 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -784,7 +784,7 @@ static int sunxi_mmc_clk_set_rate(struct sunxi_mmc_host *host,
clock <<= 1;
}
- if (host->use_new_timings) {
+ if (host->use_new_timings && host->cfg->has_timings_switch) {
ret = sunxi_ccu_set_mmc_timing_mode(host->clk_mmc, true);
if (ret) {
dev_err(mmc_dev(mmc),
--
2.13.0
[toc] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-08-06 04:10 +0200 |
| Subject | Re: [linux-sunxi] [PATCH 1/2] mmc: sunxi: fix support for new timings mode only SoCs |
| Message-ID | <ubjaV-4yq-3@gated-at.bofh.it> |
| In reply to | #1704229 |
On Sat, Aug 5, 2017 at 5:35 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> The A83T MMC support code introduces the timings mode switch, however
> such a switch doesn't exist on new SoCs with only new timings mode.
>
> Only execute the switch if the SoC really have the timings mode switch,
> to fix the regression shown on new timings mode only SoCs (A64, H5,
> etc).
>
> Fixes: b0600daebf31 ("mmc: sunxi: Support controllers that can use both
> old and new timings")
You could make it easier to read by aligning the wrapped line with
opening parenthesis and double quote.
And you don't need the newline here.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
This must have slipped through when I reworked the mmc quirks.
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web