Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702081 > unrolled thread

Re: [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO Eric Schwarz <eas@sw-optimization.com> - 2017-08-02 14:40 +0200
    Re: [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO Alan Tull <atull@kernel.org> - 2017-08-02 16:20 +0200
      Re: [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO Eric Schwarz <eas@sw-optimization.com> - 2017-08-02 17:40 +0200
        Re: [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO Greg KH <greg@kroah.com> - 2017-08-02 18:10 +0200

#1702081 — Re: [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO

Dear all,

DENX Software Engineering develops and brings this driver to mainline on 
behalf of us (ARRI*).

Since there was a lot of discussion around this patch series I would 
highly appreciate if someone could sum up what needs to be changed in 
detail in order to get this driver into the mainline as I am used it 
from the other "line-by-line" reviews. I understood that the approach is 
not generic enough - please correct me if I am wrong on that point. We 
somehow need a commitment that if we change it to another way that the 
whole discussion does not start from scratch.

Many thanks
Eric

* I am just writing from my private e-mail address since Outlook 
obviously renders all my mails as HTML despite what I am configuring.

[1]... http://www.arri.com

Am 06.07.2017 22:49, schrieb Anatolij Gustschin:

> This series adds support for fast passive parallel (FPP) Altera
> FPGA configuration using FTDI FT232H chip in FT245-FIFO mode.
> It has been used to configure Arria 10 FPGAs.
> 
> Patch 1 adds an FT232H MFD driver with common functions that
> can be used for FT232H USB-GPIO/I2C/SPI master adapter drivers.
> Currently it is used for FT232H GPIO support (in patch 2) and
> for FT245 FIFO transfers in FPP FPGA manager driver in patch 3.
> Driver support for FT232H USB-I2C/SPI master adapters can be
> added later.
> 
> Patch 2 adds a simple GPIO driver supporting four FT232H CBUS GPIOs.
> 
> Patch 3 adds an FPGA Manager driver for Altera FPP FPGA configuration
> via FT232H FT245-FIFO interface.
> 
> Anatolij Gustschin (3):
> mfd: Add support for FTDI FT232H devices
> gpio: Add FT232H CBUS GPIO driver
> fpga manager: Add FT232H driver for Altera FPP
> 
> drivers/fpga/Kconfig          |   7 +
> drivers/fpga/Makefile         |   1 +
> drivers/fpga/ftdi-fifo-fpp.c  | 569 
> ++++++++++++++++++++++++++++++++++++++++++
> drivers/gpio/Kconfig          |  11 +
> drivers/gpio/Makefile         |   1 +
> drivers/gpio/gpio-ftdi-cbus.c | 251 +++++++++++++++++++
> drivers/mfd/Kconfig           |   9 +
> drivers/mfd/Makefile          |   1 +
> drivers/mfd/ftdi-ft232h.c     | 470 ++++++++++++++++++++++++++++++++++
> include/linux/mfd/ftdi/ftdi.h |  71 ++++++
> 10 files changed, 1391 insertions(+)
> create mode 100644 drivers/fpga/ftdi-fifo-fpp.c
> create mode 100644 drivers/gpio/gpio-ftdi-cbus.c
> create mode 100644 drivers/mfd/ftdi-ft232h.c
> create mode 100644 include/linux/mfd/ftdi/ftdi.h

[toc] | [next] | [standalone]

#1702156

On Wed, Aug 2, 2017 at 6:36 AM, Eric Schwarz <eas@sw-optimization.com> wrote:
> Dear all,
>
> DENX Software Engineering develops and brings this driver to mainline on
> behalf of us (ARRI*).
>
> Since there was a lot of discussion around this patch series I would highly
> appreciate if someone could sum up what needs to be changed in detail in
> order to get this driver into the mainline as I am used it from the other
> "line-by-line" reviews. I understood that the approach is not generic enough
> - please correct me if I am wrong on that point. We somehow need a
> commitment that if we change it to another way that the whole discussion
> does not start from scratch.
>
> Many thanks
> Eric

Hi Eric,

Patchwork collects all email response to patchsets posted on this
mailing list [1] so that could be helpful for you here.

Alan

[1] https://patchwork.kernel.org/project/linux-fpga/list/?submitter=769


>
> * I am just writing from my private e-mail address since Outlook obviously
> renders all my mails as HTML despite what I am configuring.
>
> [1]... http://www.arri.com
>
> Am 06.07.2017 22:49, schrieb Anatolij Gustschin:
>
>> This series adds support for fast passive parallel (FPP) Altera
>> FPGA configuration using FTDI FT232H chip in FT245-FIFO mode.
>> It has been used to configure Arria 10 FPGAs.
>>
>> Patch 1 adds an FT232H MFD driver with common functions that
>> can be used for FT232H USB-GPIO/I2C/SPI master adapter drivers.
>> Currently it is used for FT232H GPIO support (in patch 2) and
>> for FT245 FIFO transfers in FPP FPGA manager driver in patch 3.
>> Driver support for FT232H USB-I2C/SPI master adapters can be
>> added later.
>>
>> Patch 2 adds a simple GPIO driver supporting four FT232H CBUS GPIOs.
>>
>> Patch 3 adds an FPGA Manager driver for Altera FPP FPGA configuration
>> via FT232H FT245-FIFO interface.
>>
>> Anatolij Gustschin (3):
>> mfd: Add support for FTDI FT232H devices
>> gpio: Add FT232H CBUS GPIO driver
>> fpga manager: Add FT232H driver for Altera FPP
>>
>> drivers/fpga/Kconfig          |   7 +
>> drivers/fpga/Makefile         |   1 +
>> drivers/fpga/ftdi-fifo-fpp.c  | 569
>> ++++++++++++++++++++++++++++++++++++++++++
>> drivers/gpio/Kconfig          |  11 +
>> drivers/gpio/Makefile         |   1 +
>> drivers/gpio/gpio-ftdi-cbus.c | 251 +++++++++++++++++++
>> drivers/mfd/Kconfig           |   9 +
>> drivers/mfd/Makefile          |   1 +
>> drivers/mfd/ftdi-ft232h.c     | 470 ++++++++++++++++++++++++++++++++++
>> include/linux/mfd/ftdi/ftdi.h |  71 ++++++
>> 10 files changed, 1391 insertions(+)
>> create mode 100644 drivers/fpga/ftdi-fifo-fpp.c
>> create mode 100644 drivers/gpio/gpio-ftdi-cbus.c
>> create mode 100644 drivers/mfd/ftdi-ft232h.c
>> create mode 100644 include/linux/mfd/ftdi/ftdi.h

[toc] | [prev] | [next] | [standalone]

#1702196

Hello Alan,

many thanks for your response.
Well, I am following the whole discussion from the very start and for my 
taste it is too superficial - don't know whether this is the right 
wording. Please get me right. We need some kind of implementation 
specification or a sample way on how to implement stuff. At some point I 
honestly lost track, thus I was asking for a summary so in the end the 
result is what we want. If it is clear to everyone what shall be done it 
should not be kind of a big deal to quickly sum it up which I/we would 
highly appreciate.

Many thanks
Eric

Am 02.08.2017 16:16, schrieb Alan Tull:

> On Wed, Aug 2, 2017 at 6:36 AM, Eric Schwarz <eas@sw-optimization.com> 
> wrote:
> 
>> Dear all,
>> 
>> DENX Software Engineering develops and brings this driver to mainline 
>> on
>> behalf of us (ARRI*).
>> 
>> Since there was a lot of discussion around this patch series I would 
>> highly
>> appreciate if someone could sum up what needs to be changed in detail 
>> in
>> order to get this driver into the mainline as I am used it from the 
>> other
>> "line-by-line" reviews. I understood that the approach is not generic 
>> enough
>> - please correct me if I am wrong on that point. We somehow need a
>> commitment that if we change it to another way that the whole 
>> discussion
>> does not start from scratch.
>> 
>> Many thanks
>> Eric
> 
> Hi Eric,
> 
> Patchwork collects all email response to patchsets posted on this
> mailing list [1] so that could be helpful for you here.
> 
> Alan
> 
> [1] https://patchwork.kernel.org/project/linux-fpga/list/?submitter=769
> 
> * I am just writing from my private e-mail address since Outlook 
> obviously
> renders all my mails as HTML despite what I am configuring.
> 
> [1]... http://www.arri.com
> 
> Am 06.07.2017 22:49, schrieb Anatolij Gustschin:
> 
> This series adds support for fast passive parallel (FPP) Altera
> FPGA configuration using FTDI FT232H chip in FT245-FIFO mode.
> It has been used to configure Arria 10 FPGAs.
> 
> Patch 1 adds an FT232H MFD driver with common functions that
> can be used for FT232H USB-GPIO/I2C/SPI master adapter drivers.
> Currently it is used for FT232H GPIO support (in patch 2) and
> for FT245 FIFO transfers in FPP FPGA manager driver in patch 3.
> Driver support for FT232H USB-I2C/SPI master adapters can be
> added later.
> 
> Patch 2 adds a simple GPIO driver supporting four FT232H CBUS GPIOs.
> 
> Patch 3 adds an FPGA Manager driver for Altera FPP FPGA configuration
> via FT232H FT245-FIFO interface.
> 
> Anatolij Gustschin (3):
> mfd: Add support for FTDI FT232H devices
> gpio: Add FT232H CBUS GPIO driver
> fpga manager: Add FT232H driver for Altera FPP
> 
> drivers/fpga/Kconfig          |   7 +
> drivers/fpga/Makefile         |   1 +
> drivers/fpga/ftdi-fifo-fpp.c  | 569
> ++++++++++++++++++++++++++++++++++++++++++
> drivers/gpio/Kconfig          |  11 +
> drivers/gpio/Makefile         |   1 +
> drivers/gpio/gpio-ftdi-cbus.c | 251 +++++++++++++++++++
> drivers/mfd/Kconfig           |   9 +
> drivers/mfd/Makefile          |   1 +
> drivers/mfd/ftdi-ft232h.c     | 470 ++++++++++++++++++++++++++++++++++
> include/linux/mfd/ftdi/ftdi.h |  71 ++++++
> 10 files changed, 1391 insertions(+)
> create mode 100644 drivers/fpga/ftdi-fifo-fpp.c
> create mode 100644 drivers/gpio/gpio-ftdi-cbus.c
> create mode 100644 drivers/mfd/ftdi-ft232h.c
> create mode 100644 include/linux/mfd/ftdi/ftdi.h

[toc] | [prev] | [next] | [standalone]

#1702230

On Wed, Aug 02, 2017 at 05:30:36PM +0200, Eric Schwarz wrote:
> Hello Alan,
> 
> many thanks for your response.
> Well, I am following the whole discussion from the very start and for my
> taste it is too superficial - don't know whether this is the right wording.
> Please get me right. We need some kind of implementation specification or a
> sample way on how to implement stuff. At some point I honestly lost track,
> thus I was asking for a summary so in the end the result is what we want. If
> it is clear to everyone what shall be done it should not be kind of a big
> deal to quickly sum it up which I/we would highly appreciate.

That's up to the patch submitter to deal with, it's not our job to
provide summaries of each patch review for everyone, otherwise that
would be all that we would ever be writing :)

good luck!

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web