Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1700699 > unrolled thread

Re: [PATCH] printk: Clean up do_syslog() error handling

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] printk: Clean up do_syslog() error handling Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-08-01 09:40 +0200

#1700699 — Re: [PATCH] printk: Clean up do_syslog() error handling

On (07/29/17 20:36), Nikitas Angelinas wrote:
> The error variable in do_syslog() is preemptively set to the error code
> before the error condition is checked, and then set to 0 if the error
> condition is not encountered. This is not necessary, as it is likely
> simpler to return immediately upon encountering the error condition. A
> redundant set of the error variable to 0 is also removed.
> 
> This patch has been build-tested on x86_64, but not tested for
> functionality.
> 
> Signed-off-by: Nikitas Angelinas <nikitas.angelinas@gmail.com>

looks good to me,

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>



// p.s. Petr is on vacation now

	-ss

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web