Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1699336 > unrolled thread

[PATCH] md: replace seq_release_private with seq_release

Back to article view | Back to linux.kernel

Contents

  [PATCH] md: replace seq_release_private with seq_release Cihangir Akturk <cakturk@gmail.com> - 2017-07-29 19:00 +0200
    Re: [PATCH] md: replace seq_release_private with seq_release Shaohua Li <shli@kernel.org> - 2017-07-31 18:50 +0200

#1699336 — [PATCH] md: replace seq_release_private with seq_release

Since commit f15146380d28 ("fs: seq_file - add event counter to simplify
poll() support"), md.c code has been no longer used the private field of
the struct seq_file, but seq_release_private() has been continued to be
used to release the allocated seq_file. This seems to have been
forgotten. So convert it to use seq_release() instead of
seq_release_private().

Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
---
 drivers/md/md.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 8cdca029..6174360 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -7836,7 +7836,7 @@ static const struct file_operations md_seq_fops = {
 	.open           = md_seq_open,
 	.read           = seq_read,
 	.llseek         = seq_lseek,
-	.release	= seq_release_private,
+	.release	= seq_release,
 	.poll		= mdstat_poll,
 };
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1700200

On Sat, Jul 29, 2017 at 07:52:45PM +0300, Cihangir Akturk wrote:
> Since commit f15146380d28 ("fs: seq_file - add event counter to simplify
> poll() support"), md.c code has been no longer used the private field of
> the struct seq_file, but seq_release_private() has been continued to be
> used to release the allocated seq_file. This seems to have been
> forgotten. So convert it to use seq_release() instead of
> seq_release_private().
> 
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>

applied, thanks!
> ---
>  drivers/md/md.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 8cdca029..6174360 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7836,7 +7836,7 @@ static const struct file_operations md_seq_fops = {
>  	.open           = md_seq_open,
>  	.read           = seq_read,
>  	.llseek         = seq_lseek,
> -	.release	= seq_release_private,
> +	.release	= seq_release,
>  	.poll		= mdstat_poll,
>  };
>  
> -- 
> 2.7.4
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web