Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1699974 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2017-07-31 14:10 +0200 |
| Last post | 2017-08-04 15:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mmc: mmci_qcom_dml: include mmci_qcom_dml.h to fix sparse warnings Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-31 14:10 +0200
Re: [PATCH] mmc: mmci_qcom_dml: include mmci_qcom_dml.h to fix sparse warnings Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-03 13:00 +0200
Re: [PATCH] mmc: mmci_qcom_dml: include mmci_qcom_dml.h to fix sparse warnings Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-04 15:10 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-07-31 14:10 +0200 |
| Subject | [PATCH] mmc: mmci_qcom_dml: include mmci_qcom_dml.h to fix sparse warnings |
| Message-ID | <u9hGh-686-7@gated-at.bofh.it> |
This fixes the following sparse warnings: CHECK drivers/mmc/host/mmci_qcom_dml.c drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static? drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol 'dml_hw_init' was not declared. Should it be static? Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/mmc/host/mmci_qcom_dml.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c index 00750c9d3514..95de699853d2 100644 --- a/drivers/mmc/host/mmci_qcom_dml.c +++ b/drivers/mmc/host/mmci_qcom_dml.c @@ -18,6 +18,7 @@ #include <linux/mmc/host.h> #include <linux/mmc/card.h> #include "mmci.h" +#include "mmci_qcom_dml.h" /* Registers */ #define DML_CONFIG 0x00 -- 2.7.4
[toc] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2017-08-03 13:00 +0200 |
| Message-ID | <uam1b-7ff-7@gated-at.bofh.it> |
| In reply to | #1699974 |
On 31 July 2017 at 13:59, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > This fixes the following sparse warnings: > > CHECK drivers/mmc/host/mmci_qcom_dml.c > drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static? > drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol 'dml_hw_init' was not declared. Should it be static? > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Thanks, applied for next! Kind regards Uffe > --- > > drivers/mmc/host/mmci_qcom_dml.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c > index 00750c9d3514..95de699853d2 100644 > --- a/drivers/mmc/host/mmci_qcom_dml.c > +++ b/drivers/mmc/host/mmci_qcom_dml.c > @@ -18,6 +18,7 @@ > #include <linux/mmc/host.h> > #include <linux/mmc/card.h> > #include "mmci.h" > +#include "mmci_qcom_dml.h" > > /* Registers */ > #define DML_CONFIG 0x00 > -- > 2.7.4 >
[toc] | [prev] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-08-04 15:10 +0200 |
| Message-ID | <uaKwx-7py-3@gated-at.bofh.it> |
| In reply to | #1702935 |
Hi Ulf, 2017-08-03 19:51 GMT+09:00 Ulf Hansson <ulf.hansson@linaro.org>: > On 31 July 2017 at 13:59, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: >> This fixes the following sparse warnings: >> >> CHECK drivers/mmc/host/mmci_qcom_dml.c >> drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static? >> drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol 'dml_hw_init' was not declared. Should it be static? >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Thanks, applied for next! > > Kind regards > Uffe > >> --- >> >> drivers/mmc/host/mmci_qcom_dml.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c >> index 00750c9d3514..95de699853d2 100644 >> --- a/drivers/mmc/host/mmci_qcom_dml.c >> +++ b/drivers/mmc/host/mmci_qcom_dml.c >> @@ -18,6 +18,7 @@ >> #include <linux/mmc/host.h> >> #include <linux/mmc/card.h> >> #include "mmci.h" >> +#include "mmci_qcom_dml.h" >> >> /* Registers */ >> #define DML_CONFIG 0x00 Please drop this. Kbuild test robot reported a build error and it revealed another problem for this driver. (#ifdef CONFIG_MMC_QCOM_DML must be #if IS_ENABLED(CONFIG_MMC_QCOM_DML) because this driver is tristate) I will send v2 soon. -- Best Regards Masahiro Yamada
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web