Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1699925 > unrolled thread

Re: [PATCH 1/7] sched/fair: use reweight_entity to reweight tasks

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/7] sched/fair: use reweight_entity to reweight tasks Peter Zijlstra <peterz@infradead.org> - 2017-07-31 12:50 +0200

#1699925 — Re: [PATCH 1/7] sched/fair: use reweight_entity to reweight tasks

On Fri, Jul 14, 2017 at 01:20:58PM +0000, Josef Bacik wrote:
> From: Josef Bacik <jbacik@fb.com>
> 
> reweight_task only accounts for the load average change in the cfs_rq, but
> doesn't account for the runnable_average change in the cfs_rq.  We need to do
> everything reweight_entity does, and then we just set our inv_weight
> appropriately.

The difference is in the calling convention. If you look at the
callsite:

	set_user_nice()
	  set_load_weight()
	    reweight_task()

You'll see that ->on_rq will always be false. That said, I think you're
right in that we're missing a se->runnable_weight update, because while
__update_load_avg*() doesn't use it (and will in fact (re)set it), there
are other users that could come before that.

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web