Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1691468 > unrolled thread
| Started by | Hans Verkuil <hverkuil@xs4all.nl> |
|---|---|
| First post | 2017-07-19 13:00 +0200 |
| Last post | 2017-07-31 11:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver Hans Verkuil <hverkuil@xs4all.nl> - 2017-07-19 13:00 +0200
Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver Todor Tomov <todor.tomov@linaro.org> - 2017-07-21 09:40 +0200
Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver Hans Verkuil <hverkuil@xs4all.nl> - 2017-07-31 11:30 +0200
| From | Hans Verkuil <hverkuil@xs4all.nl> |
|---|---|
| Date | 2017-07-19 13:00 +0200 |
| Subject | Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver |
| Message-ID | <u4URX-7qy-1@gated-at.bofh.it> |
On 17/07/17 12:33, Todor Tomov wrote: > This patchset adds basic support for the Qualcomm Camera Subsystem found > on Qualcomm MSM8916 and APQ8016 processors. > > The driver implements V4L2, Media controller and V4L2 subdev interfaces. > Camera sensor using V4L2 subdev interface in the kernel is supported. > > The driver is implemented using as a reference the Qualcomm Camera > Subsystem driver for Android as found in Code Aurora [1]. > > The driver is tested on Dragonboard 410C (APQ8016) with one and two > OV5645 camera sensors. media-ctl [2] and yavta [3] applications were > used for testing. Also Gstreamer 1.10.4 with v4l2src plugin is supported. > > More information is present in the document added by the third patch. OK, so this looks pretty good. I have one comment for patch 12/23, and the dt-bindings need to be acked. I suggest you make a v3.1 for patch 12/23 and then I'll wait for the binding ack. Once that's in (and there are no other comments) I will merge this. Regards, Hans
[toc] | [next] | [standalone]
| From | Todor Tomov <todor.tomov@linaro.org> |
|---|---|
| Date | 2017-07-21 09:40 +0200 |
| Message-ID | <u5AHw-1QX-19@gated-at.bofh.it> |
| In reply to | #1691468 |
Hello Hans, On 19.07.2017 13:54, Hans Verkuil wrote: > On 17/07/17 12:33, Todor Tomov wrote: >> This patchset adds basic support for the Qualcomm Camera Subsystem found >> on Qualcomm MSM8916 and APQ8016 processors. >> >> The driver implements V4L2, Media controller and V4L2 subdev interfaces. >> Camera sensor using V4L2 subdev interface in the kernel is supported. >> >> The driver is implemented using as a reference the Qualcomm Camera >> Subsystem driver for Android as found in Code Aurora [1]. >> >> The driver is tested on Dragonboard 410C (APQ8016) with one and two >> OV5645 camera sensors. media-ctl [2] and yavta [3] applications were >> used for testing. Also Gstreamer 1.10.4 with v4l2src plugin is supported. >> >> More information is present in the document added by the third patch. > > OK, so this looks pretty good. I have one comment for patch 12/23, and the > dt-bindings need to be acked. > > I suggest you make a v3.1 for patch 12/23 and then I'll wait for the binding > ack. Once that's in (and there are no other comments) I will merge this. Thank you for the review! I'll update patch 12/23 and will send in the next version along with the rest of the fixes from the review. > > Regards, > > Hans > -- Best regards, Todor Tomov
[toc] | [prev] | [next] | [standalone]
| From | Hans Verkuil <hverkuil@xs4all.nl> |
|---|---|
| Date | 2017-07-31 11:30 +0200 |
| Message-ID | <u9fbr-4uw-3@gated-at.bofh.it> |
| In reply to | #1691468 |
On 07/19/2017 12:54 PM, Hans Verkuil wrote: > On 17/07/17 12:33, Todor Tomov wrote: >> This patchset adds basic support for the Qualcomm Camera Subsystem found >> on Qualcomm MSM8916 and APQ8016 processors. >> >> The driver implements V4L2, Media controller and V4L2 subdev interfaces. >> Camera sensor using V4L2 subdev interface in the kernel is supported. >> >> The driver is implemented using as a reference the Qualcomm Camera >> Subsystem driver for Android as found in Code Aurora [1]. >> >> The driver is tested on Dragonboard 410C (APQ8016) with one and two >> OV5645 camera sensors. media-ctl [2] and yavta [3] applications were >> used for testing. Also Gstreamer 1.10.4 with v4l2src plugin is supported. >> >> More information is present in the document added by the third patch. > > OK, so this looks pretty good. I have one comment for patch 12/23, and the > dt-bindings need to be acked. > > I suggest you make a v3.1 for patch 12/23 and then I'll wait for the binding > ack. Once that's in (and there are no other comments) I will merge this. Since Sakari had a bunch of comments I'll mark this series as 'Changes Requested' and wait for a v4. Regards, Hans
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web