Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1701596 > unrolled thread

[PATCH 2/2] atm: solos-pci: constify attribute_group structures

Back to article view | Back to linux.kernel

Contents

  [PATCH 2/2] atm: solos-pci: constify attribute_group structures Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2017-08-02 02:00 +0200
    Re: [PATCH 2/2] atm: solos-pci: constify attribute_group structures David Miller <davem@davemloft.net> - 2017-08-03 02:00 +0200

#1701596 — [PATCH 2/2] atm: solos-pci: constify attribute_group structures

Functions working with attribute_groups provided by <linux/sysfs.h>
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.

File size before:
 text      data     bss     dec     hex filename
 35740    28424     832   64996    fde4 drivers/atm/solos-pci.o

File size after:
 text      data     bss     dec     hex filename
 35932    28232     832   64996    fde4 drivers/atm/solos-pci.o

This change was made with the help of Coccinelle.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/atm/solos-pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index c8f2ca6..3f9c37d 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -611,7 +611,7 @@ static struct attribute *solos_attrs[] = {
 	NULL
 };
 
-static struct attribute_group solos_attr_group = {
+static const struct attribute_group solos_attr_group = {
 	.attrs = solos_attrs,
 	.name = "parameters",
 };
@@ -628,7 +628,7 @@ static struct attribute *gpio_attrs[] = {
 	NULL
 };
 
-static struct attribute_group gpio_attr_group = {
+static const struct attribute_group gpio_attr_group = {
 	.attrs = gpio_attrs,
 	.name = "gpio",
 };
-- 
2.7.4

[toc] | [next] | [standalone]

#1702579

From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Date: Tue, 1 Aug 2017 19:57:47 -0400

> Functions working with attribute_groups provided by <linux/sysfs.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
> 
> File size before:
>  text      data     bss     dec     hex filename
>  35740    28424     832   64996    fde4 drivers/atm/solos-pci.o
> 
> File size after:
>  text      data     bss     dec     hex filename
>  35932    28232     832   64996    fde4 drivers/atm/solos-pci.o
> 
> This change was made with the help of Coccinelle.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web