Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1700662 > unrolled thread

linux-next: build failure after merge of the akpm tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2017-08-01 08:30 +0200
Last post2017-08-01 22:50 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  linux-next: build failure after merge of the akpm tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-01 08:30 +0200
    Re: linux-next: build failure after merge of the akpm tree Kees Cook <keescook@chromium.org> - 2017-08-01 20:50 +0200
      Re: linux-next: build failure after merge of the akpm tree Arnd Bergmann <arnd@arndb.de> - 2017-08-01 22:50 +0200

#1700662 — linux-next: build failure after merge of the akpm tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2017-08-01 08:30 +0200
Subjectlinux-next: build failure after merge of the akpm tree
Message-ID<u9yQN-88D-1@gated-at.bofh.it>
Hi Andrew,

After merging the akpm tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from arch/powerpc/include/asm/paca.h:19:0,
                 from arch/powerpc/include/asm/hw_irq.h:42,
                 from arch/powerpc/include/asm/irqflags.h:11,
                 from include/linux/irqflags.h:15,
                 from include/linux/spinlock.h:53,
                 from include/linux/wait.h:8,
                 from include/linux/wait_bit.h:7,
                 from include/linux/fs.h:5,
                 from include/linux/buffer_head.h:11,
                 from fs/adfs/dir_f.c:12:
In function 'memcpy',
    inlined from '__adfs_dir_put' at fs/adfs/dir_f.c:318:2,
    inlined from 'adfs_f_update' at fs/adfs/dir_f.c:403:2:
include/linux/string.h:305:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
    __read_overflow2();
    ^

I don't know why this has turned up now.  I have just left it broken
for now and would appreciate any fix.

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]


#1701339

FromKees Cook <keescook@chromium.org>
Date2017-08-01 20:50 +0200
Message-ID<u9KoW-7AC-13@gated-at.bofh.it>
In reply to#1700662
On Mon, Jul 31, 2017 at 11:25 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Andrew,
>
> After merging the akpm tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> In file included from arch/powerpc/include/asm/paca.h:19:0,
>                  from arch/powerpc/include/asm/hw_irq.h:42,
>                  from arch/powerpc/include/asm/irqflags.h:11,
>                  from include/linux/irqflags.h:15,
>                  from include/linux/spinlock.h:53,
>                  from include/linux/wait.h:8,
>                  from include/linux/wait_bit.h:7,
>                  from include/linux/fs.h:5,
>                  from include/linux/buffer_head.h:11,
>                  from fs/adfs/dir_f.c:12:
> In function 'memcpy',
>     inlined from '__adfs_dir_put' at fs/adfs/dir_f.c:318:2,
>     inlined from 'adfs_f_update' at fs/adfs/dir_f.c:403:2:
> include/linux/string.h:305:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
>     __read_overflow2();
>     ^
>
> I don't know why this has turned up now.  I have just left it broken
> for now and would appreciate any fix.

Thanks for the heads-up! I'm not sure why this suddenly appeared
either, but Arnd has sent a patch for this now.

-Kees

-- 
Kees Cook
Pixel Security

[toc] | [prev] | [next] | [standalone]


#1701462

FromArnd Bergmann <arnd@arndb.de>
Date2017-08-01 22:50 +0200
Message-ID<u9Mh5-jv-29@gated-at.bofh.it>
In reply to#1701339
On Tue, Aug 1, 2017 at 8:40 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>> I don't know why this has turned up now.  I have just left it broken
>> for now and would appreciate any fix.
>
> Thanks for the heads-up! I'm not sure why this suddenly appeared
> either, but Arnd has sent a patch for this now.

The main difference I see that can impact gcc's optimization steps is the
unreachable() that was there in BUG() but is absent in WARN().

It's possible that the compiler decided that the entire code path leading
up to the unreachable() couldn't happen, so it dropped the
__read_overflow2() call as well.

      Arnd

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web