Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1701364 > unrolled thread

[PATCH net 2/7] i40e: Initialize 64-bit statistics TX ring seqcount

Started byFlorian Fainelli <f.fainelli@gmail.com>
First post2017-08-01 21:20 +0200
Last post2017-08-01 21:20 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH net 2/7] i40e: Initialize 64-bit statistics TX ring seqcount Florian Fainelli <f.fainelli@gmail.com> - 2017-08-01 21:20 +0200

#1701364 — [PATCH net 2/7] i40e: Initialize 64-bit statistics TX ring seqcount

FromFlorian Fainelli <f.fainelli@gmail.com>
Date2017-08-01 21:20 +0200
Subject[PATCH net 2/7] i40e: Initialize 64-bit statistics TX ring seqcount
Message-ID<u9KRZ-82o-45@gated-at.bofh.it>
On 32-bit hosts and with CONFIG_DEBUG_LOCK_ALLOC we should be seeing a
lockdep splat indicating this seqcount is not correctly initialized, fix
that.

Fixes: 980e9b118642 ("i40e: Add support for 64 bit netstats")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index b936febc315a..2194960d5855 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -1113,6 +1113,8 @@ int i40e_setup_tx_descriptors(struct i40e_ring *tx_ring)
 	if (!tx_ring->tx_bi)
 		goto err;
 
+	u64_stats_init(&tx_ring->syncp);
+
 	/* round up to nearest 4K */
 	tx_ring->size = tx_ring->count * sizeof(struct i40e_tx_desc);
 	/* add u32 for head writeback, align after this takes care of
-- 
2.9.3

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web