Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1701316 > unrolled thread

Re: [PATCH 4.4 07/83] NFC: fix broken device allocation

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 4.4 07/83] NFC: fix broken device allocation Ben Hutchings <ben.hutchings@codethink.co.uk> - 2017-08-01 20:20 +0200
    Re: [PATCH 4.4 07/83] NFC: fix broken device allocation Johan Hovold <johan@kernel.org> - 2017-08-01 21:20 +0200

#1701316 — Re: [PATCH 4.4 07/83] NFC: fix broken device allocation

On Tue, 2017-07-25 at 12:18 -0700, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Johan Hovold <johan@kernel.org>
> 
> commit 20777bc57c346b6994f465e0d8261a7fbf213a09 upstream.
[...]
> --- a/net/nfc/core.c
> +++ b/net/nfc/core.c
[...]
> @@ -1077,6 +1089,11 @@ struct nfc_dev *nfc_allocate_device(stru
>  	}
>  
>  	return dev;
> +
> +err_free_dev:
> +	kfree(dev);
> +
> +	return ERR_PTR(rc);
>  }
>  EXPORT_SYMBOL(nfc_allocate_device);
[...]

But the callers expect a null pointer on error, not an error pointer.
This looks broken in mainline too.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.

[toc] | [next] | [standalone]

#1701352

On Tue, Aug 01, 2017 at 07:15:55PM +0100, Ben Hutchings wrote:
> On Tue, 2017-07-25 at 12:18 -0700, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Johan Hovold <johan@kernel.org>
> > 
> > commit 20777bc57c346b6994f465e0d8261a7fbf213a09 upstream.
> [...]
> > --- a/net/nfc/core.c
> > +++ b/net/nfc/core.c
> [...]
> > @@ -1077,6 +1089,11 @@ struct nfc_dev *nfc_allocate_device(stru
> >  	}
> >  
> >  	return dev;
> > +
> > +err_free_dev:
> > +	kfree(dev);
> > +
> > +	return ERR_PTR(rc);
> >  }
> >  EXPORT_SYMBOL(nfc_allocate_device);
> [...]
> 
> But the callers expect a null pointer on error, not an error pointer.
> This looks broken in mainline too.

Indeed. Dan's checkers found this one quickly and I posted a fix on the
9th of July:

	https://lkml.kernel.org/r/20170709110858.20331-1-johan@kernel.org

but it has unfortunately not been applied yet despite a reminder sent to
Samuel and Dave when Greg picked it up for stable ten days ago.

Perhaps it can go in through Andrew's tree if there's going to be
further delays (e.g. due to vacations)?

Thanks,
Johan

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web