Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1701295 > unrolled thread

[PATCH] staging: vboxvideo: select DRM_TTM

Started byCihangir Akturk <cakturk@gmail.com>
First post2017-08-01 20:10 +0200
Last post2017-08-03 12:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] staging: vboxvideo: select DRM_TTM Cihangir Akturk <cakturk@gmail.com> - 2017-08-01 20:10 +0200
    Re: [PATCH] staging: vboxvideo: select DRM_TTM Hans de Goede <hdegoede@redhat.com> - 2017-08-03 12:50 +0200

#1701295 — [PATCH] staging: vboxvideo: select DRM_TTM

FromCihangir Akturk <cakturk@gmail.com>
Date2017-08-01 20:10 +0200
Subject[PATCH] staging: vboxvideo: select DRM_TTM
Message-ID<u9JMd-7ne-5@gated-at.bofh.it>
vboxvideo code uses various ttm_* functions, so it needs
"drivers/gpu/drm/ttm/*" to be built. In order to build these objects
select DRM_TTM.

This commit fixes "ttm_*" undefined build errors.

Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
---
 drivers/staging/vboxvideo/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
index f89f931..1f4182e 100644
--- a/drivers/staging/vboxvideo/Kconfig
+++ b/drivers/staging/vboxvideo/Kconfig
@@ -2,6 +2,7 @@ config DRM_VBOXVIDEO
 	tristate "Virtual Box Graphics Card"
 	depends on DRM && X86 && PCI
 	select DRM_KMS_HELPER
+	select DRM_TTM
 	select GENERIC_ALLOCATOR
 	help
 	  This is a KMS driver for the virtual Graphics Card used in
-- 
2.7.4

[toc] | [next] | [standalone]


#1702929

FromHans de Goede <hdegoede@redhat.com>
Date2017-08-03 12:50 +0200
Message-ID<ualRx-7bw-21@gated-at.bofh.it>
In reply to#1701295
Hi,

On 01-08-17 20:05, Cihangir Akturk wrote:
> vboxvideo code uses various ttm_* functions, so it needs
> "drivers/gpu/drm/ttm/*" to be built. In order to build these objects
> select DRM_TTM.
> 
> This commit fixes "ttm_*" undefined build errors.
> 
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>

Thank you for doing this, I had this on my todo list but I was
travelling:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/staging/vboxvideo/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
> index f89f931..1f4182e 100644
> --- a/drivers/staging/vboxvideo/Kconfig
> +++ b/drivers/staging/vboxvideo/Kconfig
> @@ -2,6 +2,7 @@ config DRM_VBOXVIDEO
>   	tristate "Virtual Box Graphics Card"
>   	depends on DRM && X86 && PCI
>   	select DRM_KMS_HELPER
> +	select DRM_TTM
>   	select GENERIC_ALLOCATOR
>   	help
>   	  This is a KMS driver for the virtual Graphics Card used in
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web