Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1700645 > unrolled thread

linux-next: build warning after merge of the akpm-current tree

Back to article view | Back to linux.kernel

Contents

  linux-next: build warning after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-01 07:30 +0200
    [PATCH] fs, proc: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2017-08-01 14:10 +0200
      Re: [PATCH] fs, proc: remove unused variable Michal Hocko <mhocko@kernel.org> - 2017-08-01 14:20 +0200

#1700645 — linux-next: build warning after merge of the akpm-current tree

Hi Andrew,

After merging the akpm-current tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/proc/task_mmu.c: In function 'show_map_vma':
fs/proc/task_mmu.c:285:28: warning: unused variable 'priv' [-Wunused-variable]
  struct proc_maps_private *priv = m->private;
                            ^

Introduced by commit

  14ccc3193225 ("fs, proc: remove priv argument from is_stack")

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1700948 — [PATCH] fs, proc: remove unused variable

The last cleanup can go a little further, as shown by this warning:

fs/proc/task_mmu.c: In function 'show_map_vma':
fs/proc/task_mmu.c:285:28: error: unused variable 'priv' [-Werror=unused-variable]

Fixes: 14ccc3193225 ("fs, proc: remove priv argument from is_stack")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 fs/proc/task_mmu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 9782dedeead7..186e907187ab 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -282,7 +282,6 @@ show_map_vma(struct seq_file *m, struct vm_area_struct *vma, int is_pid)
 {
 	struct mm_struct *mm = vma->vm_mm;
 	struct file *file = vma->vm_file;
-	struct proc_maps_private *priv = m->private;
 	vm_flags_t flags = vma->vm_flags;
 	unsigned long ino = 0;
 	unsigned long long pgoff = 0;
-- 
2.9.0

[toc] | [prev] | [next] | [standalone]

#1700949 — Re: [PATCH] fs, proc: remove unused variable

On Tue 01-08-17 14:01:20, Arnd Bergmann wrote:
> The last cleanup can go a little further, as shown by this warning:
> 
> fs/proc/task_mmu.c: In function 'show_map_vma':
> fs/proc/task_mmu.c:285:28: error: unused variable 'priv' [-Werror=unused-variable]
> 
> Fixes: 14ccc3193225 ("fs, proc: remove priv argument from is_stack")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks Arnd! Andrew, could you fold this into
fs-proc-remove-priv-argument-from-is_stack.patch please?

> ---
>  fs/proc/task_mmu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 9782dedeead7..186e907187ab 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -282,7 +282,6 @@ show_map_vma(struct seq_file *m, struct vm_area_struct *vma, int is_pid)
>  {
>  	struct mm_struct *mm = vma->vm_mm;
>  	struct file *file = vma->vm_file;
> -	struct proc_maps_private *priv = m->private;
>  	vm_flags_t flags = vma->vm_flags;
>  	unsigned long ino = 0;
>  	unsigned long long pgoff = 0;
> -- 
> 2.9.0
> 

-- 
Michal Hocko
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web