Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1700747 > unrolled thread
| Started by | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| First post | 2017-08-01 10:30 +0200 |
| Last post | 2017-08-01 10:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] usb: xhci: fix call_kern.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2017-08-01 10:30 +0200
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-08-01 10:30 +0200 |
| Subject | [PATCH] usb: xhci: fix call_kern.cocci warnings |
| Message-ID | <u9AIW-P3-7@gated-at.bofh.it> |
GFP_KERNEL used when a lock is held. Convert to GFP_ATOMIC to avoid
the possibility of deadlock.
Fixes: 725d53536473 ("usb: xhci: Add DbC support in xHCI driver")
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
I don't have access to any more of the context than what is shown so I
don't know if this is a real bug.
You may want to see if it is instead possible to pull the call out of the
lock.
tree: baolu/usb/xhci/dbc/beta-v2
head: 671cb76fa0644a2f72a78fe6aac58c3c3347bc38
commit: 725d53536473cb05cdcf2b81a727ded8875a2a2f [3/4] usb: xhci: Add DbC
support in xHCI driver
xhci-dbgcap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/host/xhci-dbgcap.c
+++ b/drivers/usb/host/xhci-dbgcap.c
@@ -595,7 +595,7 @@ static int __xhci_dbc_start(struct xhci_
if (ret)
return ret;
- ret = xhci_dbc_mem_init(xhci, GFP_KERNEL);
+ ret = xhci_dbc_mem_init(xhci, GFP_ATOMIC);
if (ret)
return ret;
Back to top | Article view | linux.kernel
csiph-web