Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1700146 > unrolled thread

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: linux-next: build failure in the staging tree (Was: kisskb:  FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24) Greg KH <gregkh@linuxfoundation.org> - 2017-07-31 18:00 +0200
    Re: linux-next: build failure in the staging tree (Was: kisskb:  FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24) Laurentiu Tudor <laurentiu.tudor@nxp.com> - 2017-08-01 10:30 +0200
      Re: linux-next: build failure in the staging tree (Was: kisskb:  FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24) Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-07 02:30 +0200
        Re: linux-next: build failure in the staging tree (Was: kisskb:  FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24) Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-11 01:50 +0200
          Re: linux-next: build failure in the staging tree (Was: kisskb:  FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24) Greg KH <gregkh@linuxfoundation.org> - 2017-08-11 01:50 +0200
            Re: linux-next: build failure in the staging tree (Was: kisskb:  FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24) Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-11 02:10 +0200

#1700146 — Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote:
> Hi Stephen,
> 
> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not 
> all arches implement the support for the option. I can submit a patch 
> that adds explicit dependencies on arches that it was build-tested (x86, 
> arm, powerpc, all both 32 and 64 bits) similar to how it's done here 
> [1]. Let me know if you're ok with this fix and i'll submit the fix to 
> staging.

Ugh, you should not be selecting that option, but rather depending on
the option, right?

thanks,

greg k-h

[toc] | [next] | [standalone]

#1700749

On 07/31/2017 06:58 PM, Greg KH wrote:
> On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote:
>> Hi Stephen,
>>
>> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not
>> all arches implement the support for the option. I can submit a patch
>> that adds explicit dependencies on arches that it was build-tested (x86,
>> arm, powerpc, all both 32 and 64 bits) similar to how it's done here
>> [1]. Let me know if you're ok with this fix and i'll submit the fix to
>> staging.
>
> Ugh, you should not be selecting that option, but rather depending on
> the option, right?

All users in the kernel use "select", so i don't think so. An 
interesting use that adds explicit dependencies on architectures can be
seen here [1], in the generic code. I've proposed a patch [2] that does 
a similar thing for mc-bus. I think it's a good approach as it keeps 
things under control by explicitly specifying the architectures on which
the driver was compile-tested.

---
Best Regards, Laurentiu

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/Kconfig#n28
[2] https://patchwork.kernel.org/patch/9871861/

[toc] | [prev] | [next] | [standalone]

#1705030

Hi all,

On Tue, 1 Aug 2017 08:29:31 +0000 Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote:
>
> On 07/31/2017 06:58 PM, Greg KH wrote:
> > On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote:  
> >> Hi Stephen,
> >>
> >> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not
> >> all arches implement the support for the option. I can submit a patch
> >> that adds explicit dependencies on arches that it was build-tested (x86,
> >> arm, powerpc, all both 32 and 64 bits) similar to how it's done here
> >> [1]. Let me know if you're ok with this fix and i'll submit the fix to
> >> staging.  
> >
> > Ugh, you should not be selecting that option, but rather depending on
> > the option, right?  
> 
> All users in the kernel use "select", so i don't think so. An 
> interesting use that adds explicit dependencies on architectures can be
> seen here [1], in the generic code. I've proposed a patch [2] that does 
> a similar thing for mc-bus. I think it's a good approach as it keeps 
> things under control by explicitly specifying the architectures on which
> the driver was compile-tested.
> 
> ---
> Best Regards, Laurentiu
> 
> [1] 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/Kconfig#n28
> [2] https://patchwork.kernel.org/patch/9871861/

Any resolution of this?
-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]

#1709106

Hi all,

On Mon, 7 Aug 2017 10:22:08 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 1 Aug 2017 08:29:31 +0000 Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote:
> >
> > On 07/31/2017 06:58 PM, Greg KH wrote:  
> > > On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote:    
> > >>
> > >> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not
> > >> all arches implement the support for the option. I can submit a patch
> > >> that adds explicit dependencies on arches that it was build-tested (x86,
> > >> arm, powerpc, all both 32 and 64 bits) similar to how it's done here
> > >> [1]. Let me know if you're ok with this fix and i'll submit the fix to
> > >> staging.    
> > >
> > > Ugh, you should not be selecting that option, but rather depending on
> > > the option, right?    
> > 
> > All users in the kernel use "select", so i don't think so. An 
> > interesting use that adds explicit dependencies on architectures can be
> > seen here [1], in the generic code. I've proposed a patch [2] that does 
> > a similar thing for mc-bus. I think it's a good approach as it keeps 
> > things under control by explicitly specifying the architectures on which
> > the driver was compile-tested.
> > 
> > ---
> > Best Regards, Laurentiu
> > 
> > [1] 
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/Kconfig#n28
> > [2] https://patchwork.kernel.org/patch/9871861/  
> 
> Any resolution of this?

Ping?
-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]

#1709117

On Fri, Aug 11, 2017 at 09:41:09AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 7 Aug 2017 10:22:08 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Tue, 1 Aug 2017 08:29:31 +0000 Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote:
> > >
> > > On 07/31/2017 06:58 PM, Greg KH wrote:  
> > > > On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote:    
> > > >>
> > > >> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not
> > > >> all arches implement the support for the option. I can submit a patch
> > > >> that adds explicit dependencies on arches that it was build-tested (x86,
> > > >> arm, powerpc, all both 32 and 64 bits) similar to how it's done here
> > > >> [1]. Let me know if you're ok with this fix and i'll submit the fix to
> > > >> staging.    
> > > >
> > > > Ugh, you should not be selecting that option, but rather depending on
> > > > the option, right?    
> > > 
> > > All users in the kernel use "select", so i don't think so. An 
> > > interesting use that adds explicit dependencies on architectures can be
> > > seen here [1], in the generic code. I've proposed a patch [2] that does 
> > > a similar thing for mc-bus. I think it's a good approach as it keeps 
> > > things under control by explicitly specifying the architectures on which
> > > the driver was compile-tested.
> > > 
> > > ---
> > > Best Regards, Laurentiu
> > > 
> > > [1] 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/Kconfig#n28
> > > [2] https://patchwork.kernel.org/patch/9871861/  
> > 
> > Any resolution of this?
> 
> Ping?

I have a patch in my queue, somewhere, that should resolve this, I
think.  I have 600+ staging patches in my todo queue right now, that's
what I get for trying to have a vacation...

I'll get to it soon, it's not lost, thanks.

greg k-h

[toc] | [prev] | [next] | [standalone]

#1709135

Hi Greg,

On Thu, 10 Aug 2017 16:48:42 -0700 Greg KH <gregkh@linuxfoundation.org> wrote:
>
> I have a patch in my queue, somewhere, that should resolve this, I
> think.  I have 600+ staging patches in my todo queue right now, that's
> what I get for trying to have a vacation...
> 
> I'll get to it soon, it's not lost, thanks.

No worries, just checking.

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web