Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1698784 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-07-28 15:30 +0200 |
| Last post | 2017-07-29 02:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR Arnd Bergmann <arnd@arndb.de> - 2017-07-28 15:30 +0200
Re: [PATCH] staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-29 02:10 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-07-28 15:30 +0200 |
| Subject | [PATCH] staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR |
| Message-ID | <u8dv3-4hd-3@gated-at.bofh.it> |
vboxvideo fails to link without genalloc:
drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_alloc':
vbox_hgsmi.c:(.text+0x1e): undefined reference to `gen_pool_dma_alloc'
drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_free':
vbox_hgsmi.c:(.text+0xf2): undefined reference to `gen_pool_free'
This adds a Kconfig select statement, mirroring what all the other
users have.
Fixes: dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/vboxvideo/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
index a52746f9a670..cfabe3ce4bab 100644
--- a/drivers/staging/vboxvideo/Kconfig
+++ b/drivers/staging/vboxvideo/Kconfig
@@ -2,6 +2,7 @@ config DRM_VBOXVIDEO
tristate "Virtual Box Graphics Card"
depends on DRM && X86 && PCI
select DRM_KMS_HELPER
+ select GENERIC_ALLOCATOR
help
This is a KMS driver for the virtual Graphics Card used in
Virtual Box virtual machines.
--
2.9.0
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-07-29 02:10 +0200 |
| Message-ID | <u8nuq-2Ax-15@gated-at.bofh.it> |
| In reply to | #1698784 |
On Fri, Jul 28, 2017 at 03:21:01PM +0200, Arnd Bergmann wrote:
> vboxvideo fails to link without genalloc:
>
> drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_alloc':
> vbox_hgsmi.c:(.text+0x1e): undefined reference to `gen_pool_dma_alloc'
> drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_free':
> vbox_hgsmi.c:(.text+0xf2): undefined reference to `gen_pool_free'
>
> This adds a Kconfig select statement, mirroring what all the other
> users have.
>
> Fixes: dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/vboxvideo/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Hans sent this same patch 2 days ago, sorry, just applied it now.
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web