Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1694302 > unrolled thread

[PATCH] staging: comedi: ni_mio_common.c: fix coding style issue

Started byChristopher Mårtensson <cribalik@gmail.com>
First post2017-07-23 14:20 +0200
Last post2017-07-28 16:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] staging: comedi: ni_mio_common.c: fix coding style issue Christopher Mårtensson <cribalik@gmail.com> - 2017-07-23 14:20 +0200
    Re: [PATCH] staging: comedi: ni_mio_common.c: fix coding style issue Ian Abbott <abbotti@mev.co.uk> - 2017-07-28 16:20 +0200

#1694302 — [PATCH] staging: comedi: ni_mio_common.c: fix coding style issue

FromChristopher Mårtensson <cribalik@gmail.com>
Date2017-07-23 14:20 +0200
Subject[PATCH] staging: comedi: ni_mio_common.c: fix coding style issue
Message-ID<u6o1A-7p5-23@gated-at.bofh.it>
From 3e90ab52ad9b437d7c09cc667161cdb855c0cc7b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christopher=20M=C3=A5rtensson?= <cribalik@gmail.com>
Date: Sun, 23 Jul 2017 13:05:09 +0200
Subject: [PATCH] staging: comedi: ni_mio_common.c: fix coding style issue

"checkpatch.pl -f ..." gave
ERROR: open brace '{' following function definitions go on the next line

Signed-off-by: Christopher Mårtensson <cribalik@gmail.com>
---
 drivers/staging/comedi/drivers/ni_mio_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index 2f7bfc1..398347f 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -1962,7 +1962,8 @@ static unsigned int ni_timer_to_ns(const struct comedi_device *dev, int timer)
 static void ni_cmd_set_mite_transfer(struct mite_ring *ring,
 				     struct comedi_subdevice *sdev,
 				     const struct comedi_cmd *cmd,
-				     unsigned int max_count) {
+				     unsigned int max_count)
+{
 #ifdef PCIDMA
 	unsigned int nbytes = max_count;
 
-- 
2.7.4

[toc] | [next] | [standalone]


#1698829

FromIan Abbott <abbotti@mev.co.uk>
Date2017-07-28 16:20 +0200
Message-ID<u8ehr-4NW-1@gated-at.bofh.it>
In reply to#1694302
On 23/07/17 13:14, Christopher Mårtensson wrote:
>  From 3e90ab52ad9b437d7c09cc667161cdb855c0cc7b Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Christopher=20M=C3=A5rtensson?= <cribalik@gmail.com>
> Date: Sun, 23 Jul 2017 13:05:09 +0200
> Subject: [PATCH] staging: comedi: ni_mio_common.c: fix coding style issue
> 
> "checkpatch.pl -f ..." gave
> ERROR: open brace '{' following function definitions go on the next line
> 
> Signed-off-by: Christopher Mårtensson <cribalik@gmail.com>
> ---
>   drivers/staging/comedi/drivers/ni_mio_common.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> index 2f7bfc1..398347f 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> @@ -1962,7 +1962,8 @@ static unsigned int ni_timer_to_ns(const struct comedi_device *dev, int timer)
>   static void ni_cmd_set_mite_transfer(struct mite_ring *ring,
>   				     struct comedi_subdevice *sdev,
>   				     const struct comedi_cmd *cmd,
> -				     unsigned int max_count) {
> +				     unsigned int max_count)
> +{
>   #ifdef PCIDMA
>   	unsigned int nbytes = max_count;
>   
> 

Thanks for the fix.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web