Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698773 > unrolled thread

[PATCH V2] lightnvm: pblk fix for 4.13

Back to article view | Back to linux.kernel

Contents

  [PATCH V2] lightnvm: pblk fix for 4.13 "Javier González" <jg@lightnvm.io> - 2017-07-28 15:20 +0200
    Re: [PATCH V2] lightnvm: pblk fix for 4.13 Jens Axboe <axboe@kernel.dk> - 2017-07-28 16:10 +0200
      Re: [PATCH V2] lightnvm: pblk fix for 4.13 Javier González <javier@javigon.com> - 2017-07-28 16:10 +0200

#1698773 — [PATCH V2] lightnvm: pblk fix for 4.13

Hi Jens,

Can you pick up this fix for 4.13? It is a fix to a read corruption in
pblk that has been there form the beginning. It is due to a bad bio
manipulation in the case that an I/O containing lbas that are invalid,
point to data in the host cache and point to data on the device, all
three in a single bio.

The patch applies on top of you for-4.13/block and is available too at:
  - https://github.com/OpenChannelSSD/linux/tree/pblk.for-4.13

I marked the patch to fix the original pblk commit, but it does not
apply anymore on the original 4.12 code. How do we handle these
situations? We make a backport when Greg makes 4.12 stable?

Changes since V1:
 - Make advanced_bio a bool to improve readability, as suggested by Jens

Thanks,
Javier


Javier González (1):
  lightnvm: pblk: advance bio according to lba index

 drivers/lightnvm/pblk-rb.c   |  4 ++--
 rivers/lightnvm/pblk-read.c | 23 ++++++++++++++++-------
 drivers/lightnvm/pblk.h      |  2 +-
 3 files changed, 19 insertions(+), 10 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1698824

On 07/28/2017 07:13 AM, Javier González wrote:
> Hi Jens,
> 
> Can you pick up this fix for 4.13? It is a fix to a read corruption in
> pblk that has been there form the beginning. It is due to a bad bio
> manipulation in the case that an I/O containing lbas that are invalid,
> point to data in the host cache and point to data on the device, all
> three in a single bio.
> 
> The patch applies on top of you for-4.13/block and is available too at:
>   - https://github.com/OpenChannelSSD/linux/tree/pblk.for-4.13
> 
> I marked the patch to fix the original pblk commit, but it does not
> apply anymore on the original 4.12 code. How do we handle these
> situations? We make a backport when Greg makes 4.12 stable?

Greg will email you if it doesn't apply, then you can reply back
with a version that does apply against 4.12.

Applied for 4.13.

-- 
Jens Axboe

[toc] | [prev] | [next] | [standalone]

#1698825

[Multipart message — attachments visible in raw view] — view raw

> On 28 Jul 2017, at 16.06, Jens Axboe <axboe@kernel.dk> wrote:
> 
> On 07/28/2017 07:13 AM, Javier González wrote:
>> Hi Jens,
>> 
>> Can you pick up this fix for 4.13? It is a fix to a read corruption in
>> pblk that has been there form the beginning. It is due to a bad bio
>> manipulation in the case that an I/O containing lbas that are invalid,
>> point to data in the host cache and point to data on the device, all
>> three in a single bio.
>> 
>> The patch applies on top of you for-4.13/block and is available too at:
>>  - https://github.com/OpenChannelSSD/linux/tree/pblk.for-4.13
>> 
>> I marked the patch to fix the original pblk commit, but it does not
>> apply anymore on the original 4.12 code. How do we handle these
>> situations? We make a backport when Greg makes 4.12 stable?
> 
> Greg will email you if it doesn't apply, then you can reply back
> with a version that does apply against 4.12.

Makes sense. Thanks for explaining :)

Javier

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web