Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1694866 > unrolled thread
| Started by | Fabrice Gasnier <fabrice.gasnier@st.com> |
|---|---|
| First post | 2017-07-24 18:20 +0200 |
| Last post | 2017-08-09 15:20 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 2/3] dt-bindings: iio: adc: stm32: add optional st,min-sample-time-nsecs Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-07-24 18:20 +0200
Re: [PATCH v2 2/3] dt-bindings: iio: adc: stm32: add optional st,min-sample-time-nsecs Jonathan Cameron <jic23@kernel.org> - 2017-07-30 18:30 +0200
Re: [PATCH v2 2/3] dt-bindings: iio: adc: stm32: add optional st,min-sample-time-nsecs Rob Herring <robh@kernel.org> - 2017-08-03 19:10 +0200
Re: [PATCH v2 2/3] dt-bindings: iio: adc: stm32: add optional st,min-sample-time-nsecs Jonathan Cameron <jic23@kernel.org> - 2017-08-09 15:20 +0200
| From | Fabrice Gasnier <fabrice.gasnier@st.com> |
|---|---|
| Date | 2017-07-24 18:20 +0200 |
| Subject | [PATCH v2 2/3] dt-bindings: iio: adc: stm32: add optional st,min-sample-time-nsecs |
| Message-ID | <u6Ofn-7i4-7@gated-at.bofh.it> |
STM32 ADC allows each channel to be sampled with a different sampling
time. There's an application note that deals with this: 'How to get
the best ADC accuracy in STM32...' It basically depends on analog input
signal electrical properties (depends on board).
Add optional 'st,min-sample-time-nsecs' property so this can be tuned
in dt.
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
Changes in v2:
- Use 'st,min-sample-time-nsecs' instead of 'min-sample-time'.
---
Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt
index 8310073..48bfcaa3 100644
--- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt
@@ -74,6 +74,11 @@ Optional properties:
* can be 6, 8, 10 or 12 on stm32f4
* can be 8, 10, 12, 14 or 16 on stm32h7
Default is maximum resolution if unset.
+- st,min-sample-time-nsecs: Minimum sampling time in nanoseconds.
+ Depending on hardware (board) e.g. high/low analog input source impedance,
+ fine tune of ADC sampling time may be recommended.
+ This can be either one value or an array that matches 'st,adc-channels' list,
+ to set sample time resp. for all channels, or independently for each channel.
Example:
adc: adc@40012000 {
--
1.9.1
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-07-30 18:30 +0200 |
| Subject | Re: [PATCH v2 2/3] dt-bindings: iio: adc: stm32: add optional st,min-sample-time-nsecs |
| Message-ID | <u8Zgl-2EJ-1@gated-at.bofh.it> |
| In reply to | #1694866 |
On Mon, 24 Jul 2017 18:10:39 +0200
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:
> STM32 ADC allows each channel to be sampled with a different sampling
> time. There's an application note that deals with this: 'How to get
> the best ADC accuracy in STM32...' It basically depends on analog input
> signal electrical properties (depends on board).
>
> Add optional 'st,min-sample-time-nsecs' property so this can be tuned
> in dt.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
This ideally wants a devicetree review so I'm going to sit on
it for a few days longer.
Looks fine to me as does the implementation patch.
Give me a kick in a week or so if we have seen no progress on
this. I will be travelling from next weekend and access may
be a little intermittent for up to two weeks.
Thanks,
Jonathan
> ---
> Changes in v2:
> - Use 'st,min-sample-time-nsecs' instead of 'min-sample-time'.
> ---
> Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt
> index 8310073..48bfcaa3 100644
> --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt
> @@ -74,6 +74,11 @@ Optional properties:
> * can be 6, 8, 10 or 12 on stm32f4
> * can be 8, 10, 12, 14 or 16 on stm32h7
> Default is maximum resolution if unset.
> +- st,min-sample-time-nsecs: Minimum sampling time in nanoseconds.
> + Depending on hardware (board) e.g. high/low analog input source impedance,
> + fine tune of ADC sampling time may be recommended.
> + This can be either one value or an array that matches 'st,adc-channels' list,
> + to set sample time resp. for all channels, or independently for each channel.
>
> Example:
> adc: adc@40012000 {
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-08-03 19:10 +0200 |
| Subject | Re: [PATCH v2 2/3] dt-bindings: iio: adc: stm32: add optional st,min-sample-time-nsecs |
| Message-ID | <uarNf-32O-7@gated-at.bofh.it> |
| In reply to | #1694866 |
On Mon, Jul 24, 2017 at 06:10:39PM +0200, Fabrice Gasnier wrote: > STM32 ADC allows each channel to be sampled with a different sampling > time. There's an application note that deals with this: 'How to get > the best ADC accuracy in STM32...' It basically depends on analog input > signal electrical properties (depends on board). > > Add optional 'st,min-sample-time-nsecs' property so this can be tuned > in dt. > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > --- > Changes in v2: > - Use 'st,min-sample-time-nsecs' instead of 'min-sample-time'. > --- > Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt | 5 +++++ > 1 file changed, 5 insertions(+) Acked-by: Rob Herring <robh@kernel.org>
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-08-09 15:20 +0200 |
| Subject | Re: [PATCH v2 2/3] dt-bindings: iio: adc: stm32: add optional st,min-sample-time-nsecs |
| Message-ID | <ucz3X-7wj-1@gated-at.bofh.it> |
| In reply to | #1703279 |
On Thu, 3 Aug 2017 12:01:54 -0500 Rob Herring <robh@kernel.org> wrote: > On Mon, Jul 24, 2017 at 06:10:39PM +0200, Fabrice Gasnier wrote: > > STM32 ADC allows each channel to be sampled with a different sampling > > time. There's an application note that deals with this: 'How to get > > the best ADC accuracy in STM32...' It basically depends on analog input > > signal electrical properties (depends on board). > > > > Add optional 'st,min-sample-time-nsecs' property so this can be tuned > > in dt. > > > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > > --- > > Changes in v2: > > - Use 'st,min-sample-time-nsecs' instead of 'min-sample-time'. > > --- > > Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > Acked-by: Rob Herring <robh@kernel.org> Applied to the togreg branch of iio.git and pushed out as testings. Thanks for review Rob and thanks for the patch Fabrice. Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web