Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1693832 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-07-21 18:20 +0200 |
| Last post | 2017-07-29 21:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies Arnd Bergmann <arnd@arndb.de> - 2017-07-21 18:20 +0200
Re: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com> - 2017-07-29 21:30 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-07-21 18:20 +0200 |
| Subject | [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies |
| Message-ID | <u5IOK-73n-25@gated-at.bofh.it> |
We get a Kconfig warning when selecting this without also enabling
CONFIG_PCI:
warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE && SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects IOSF_MBI which has unmet direct dependencies (PCI)
This adds a new depedency.
Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common APIs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/thermal/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index b5b5facb8747..ac2a53823576 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL
config INTEL_SOC_DTS_IOSF_CORE
tristate
- depends on X86
+ depends on X86 && PCI
select IOSF_MBI
help
This is becoming a common feature for Intel SoCs to expose the additional
@@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE
config INTEL_SOC_DTS_THERMAL
tristate "Intel SoCs DTS thermal driver"
- depends on X86
+ depends on X86 && PCI
select INTEL_SOC_DTS_IOSF_CORE
select THERMAL_WRITABLE_TRIPS
help
--
2.9.0
[toc] | [next] | [standalone]
| From | "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com> |
|---|---|
| Date | 2017-07-29 21:30 +0200 |
| Message-ID | <u8FAZ-6JR-1@gated-at.bofh.it> |
| In reply to | #1693832 |
On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote:
> We get a Kconfig warning when selecting this without also enabling
> CONFIG_PCI:
>
> warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE &&
> SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects
> IOSF_MBI which has unmet direct dependencies (PCI)
>
> This adds a new depedency.
>
> Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common
> APIs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/thermal/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index b5b5facb8747..ac2a53823576 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL
>
> config INTEL_SOC_DTS_IOSF_CORE
> tristate
> - depends on X86
> + depends on X86 && PCI
> select IOSF_MBI
> help
> This is becoming a common feature for Intel SoCs to expose
> the additional
> @@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE
>
> config INTEL_SOC_DTS_THERMAL
> tristate "Intel SoCs DTS thermal driver"
> - depends on X86
> + depends on X86 && PCI
> select INTEL_SOC_DTS_IOSF_CORE
> select THERMAL_WRITABLE_TRIPS
> help
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web