Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1698492 > unrolled thread

Re: [PATCH v2] qe: fix compile issue for arm64

Started byMichael Ellerman <mpe@ellerman.id.au>
First post2017-07-28 08:20 +0200
Last post2017-07-31 12:40 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v2] qe: fix compile issue for arm64 Michael Ellerman <mpe@ellerman.id.au> - 2017-07-28 08:20 +0200
    RE: [PATCH v2] qe: fix compile issue for arm64 Qiang Zhao <qiang.zhao@nxp.com> - 2017-07-28 09:20 +0200
      RE: [PATCH v2] qe: fix compile issue for arm64 Michael Ellerman <mpe@ellerman.id.au> - 2017-07-31 12:40 +0200

#1698492 — Re: [PATCH v2] qe: fix compile issue for arm64

FromMichael Ellerman <mpe@ellerman.id.au>
Date2017-07-28 08:20 +0200
SubjectRe: [PATCH v2] qe: fix compile issue for arm64
Message-ID<u86MW-8s7-5@gated-at.bofh.it>
Zhao Qiang <qiang.zhao@nxp.com> writes:

> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2:
> 	- include all Errata QE_General4 in #ifdef
>
>  drivers/soc/fsl/qe/qe.c | 2 ++
>  1 file changed, 2 insertions(+)

AFAICS this driver can only be built on PPC, what am I missing?

config QUICC_ENGINE
        bool "Freescale QUICC Engine (QE) Support"
        depends on FSL_SOC && PPC32

cheers

[toc] | [next] | [standalone]


#1698556

FromQiang Zhao <qiang.zhao@nxp.com>
Date2017-07-28 09:20 +0200
Message-ID<u87J2-CM-39@gated-at.bofh.it>
In reply to#1698492
Fri 7/28/2017 2:14 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:

> -----Original Message-----
> From: Michael Ellerman [mailto:mpe@ellerman.id.au]
> Sent: Friday, July 28, 2017 2:14 PM
> To: Qiang Zhao <qiang.zhao@nxp.com>; oss@buserror.net
> Cc: valentin.longchamp@keymile.com; linuxppc-dev@lists.ozlabs.org; linux-
> kernel@vger.kernel.org; Qiang Zhao <qiang.zhao@nxp.com>
> Subject: Re: [PATCH v2] qe: fix compile issue for arm64
> 
> Zhao Qiang <qiang.zhao@nxp.com> writes:
> 
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2:
> > 	- include all Errata QE_General4 in #ifdef
> >
> >  drivers/soc/fsl/qe/qe.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> AFAICS this driver can only be built on PPC, what am I missing?
> 
> config QUICC_ENGINE
>         bool "Freescale QUICC Engine (QE) Support"
>         depends on FSL_SOC && PPC32
> 
> cheers

I sent another patchset to support it on arm64.
Thank you! 

Best Regards
Qiang Zhao

[toc] | [prev] | [next] | [standalone]


#1699918

FromMichael Ellerman <mpe@ellerman.id.au>
Date2017-07-31 12:40 +0200
Message-ID<u9ghb-57H-15@gated-at.bofh.it>
In reply to#1698556
Qiang Zhao <qiang.zhao@nxp.com> writes:

> Fri 7/28/2017 2:14 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> -----Original Message-----
>> From: Michael Ellerman [mailto:mpe@ellerman.id.au]
>> Sent: Friday, July 28, 2017 2:14 PM
>> To: Qiang Zhao <qiang.zhao@nxp.com>; oss@buserror.net
>> Cc: valentin.longchamp@keymile.com; linuxppc-dev@lists.ozlabs.org; linux-
>> kernel@vger.kernel.org; Qiang Zhao <qiang.zhao@nxp.com>
>> Subject: Re: [PATCH v2] qe: fix compile issue for arm64
>> 
>> Zhao Qiang <qiang.zhao@nxp.com> writes:
>> 
>> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
>> > ---
>> > Changes for v2:
>> > 	- include all Errata QE_General4 in #ifdef
>> >
>> >  drivers/soc/fsl/qe/qe.c | 2 ++
>> >  1 file changed, 2 insertions(+)
>> 
>> AFAICS this driver can only be built on PPC, what am I missing?
>> 
>> config QUICC_ENGINE
>>         bool "Freescale QUICC Engine (QE) Support"
>>         depends on FSL_SOC && PPC32
>> 
>> cheers
>
> I sent another patchset to support it on arm64.

Where? I don't see it.

Shouldn't this patch be part of that series? Otherwise when that series
is merged the build will break on arm64.

cheers

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web