Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1694093 > unrolled thread

[PATCH 0/3] Add ethernet0 alias for several A64 boards

Started byIcenowy Zheng <icenowy@aosc.io>
First post2017-07-22 04:30 +0200
Last post2017-07-26 06:20 +0200
Articles 8 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] Add ethernet0 alias for several A64 boards Icenowy Zheng <icenowy@aosc.io> - 2017-07-22 04:30 +0200
    [PATCH 3/3] arm64: allwinner: a64: add ethernet0 alias for SoPine EMAC node Icenowy Zheng <icenowy@aosc.io> - 2017-07-22 04:30 +0200
    Re: [PATCH 0/3] Add ethernet0 alias for several A64 boards Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-24 10:00 +0200
      Re: [PATCH 0/3] Add ethernet0 alias for several A64 boards icenowy@aosc.io - 2017-07-25 05:10 +0200
        Re: [PATCH 0/3] Add ethernet0 alias for several A64 boards Adam Borowski <kilobyte@angband.pl> - 2017-07-25 05:30 +0200
          Re: [PATCH 0/3] Add ethernet0 alias for several A64 boards Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-25 16:40 +0200
            Re: [PATCH 0/3] Add ethernet0 alias for several A64 boards Icenowy Zheng <icenowy@aosc.io> - 2017-07-26 02:00 +0200
              Re: [linux-sunxi] Re: [PATCH 0/3] Add ethernet0 alias for several A64 boards Chen-Yu Tsai <wens@csie.org> - 2017-07-26 06:20 +0200

#1694093 — [PATCH 0/3] Add ethernet0 alias for several A64 boards

FromIcenowy Zheng <icenowy@aosc.io>
Date2017-07-22 04:30 +0200
Subject[PATCH 0/3] Add ethernet0 alias for several A64 boards
Message-ID<u5Sl3-4u2-3@gated-at.bofh.it>
Allwinner A64 SoC has an EMAC which is used to provide Ethernet
function on several boards.

The EMAC itself doesn't have a fixed MAC address, but the sunxi
mainline U-Boot have the ability to generate one based on the eFUSE
SID in the chip, and add the generated MAC address to the device
tree when booting.

The MAC address setting step is based on the device tree's aliases,
and device tree nodes prefixed "ethernet" will get the MAC address
added. However, in several A64 boards' device tree, the alias is not
set up, so that the U-Boot won't set the MAC address.

Add the ethernet0 aliases to these boards.

I hope this patchset can be queued in 4.13, otherwise 4.13 kernels
won't get non-volatile MAC addresses, and will use random ones
instead, which is annoying to many users.

Icenowy Zheng (3):
  arm64: allwinner: a64: add ethernet0 alias for BPi M64 EMAC node
  arm64: allwinner: a64: add ethernet0 alias for Pine64 EMAC node
  arm64: allwinner: a64: add ethernet0 alias for SoPine EMAC node

 arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts     | 1 +
 arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts           | 1 +
 arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 1 +
 3 files changed, 3 insertions(+)

-- 
2.13.0

[toc] | [next] | [standalone]

#1694094 — [PATCH 3/3] arm64: allwinner: a64: add ethernet0 alias for SoPine EMAC node

FromIcenowy Zheng <icenowy@aosc.io>
Date2017-07-22 04:30 +0200
Subject[PATCH 3/3] arm64: allwinner: a64: add ethernet0 alias for SoPine EMAC node
Message-ID<u5Sl3-4u2-7@gated-at.bofh.it>
In reply to#1694093
The SoPine official baseboard uses the A64 chip's EMAC to provide an
Ethernet link.

Add the ethernet0 alias in the device tree, in order to let U-Boot
generate a MAC address from the chip's SID.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
index 17eb1cc5bf6b..216e3a5dafae 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
@@ -53,6 +53,7 @@
 		     "allwinner,sun50i-a64";
 
 	aliases {
+		ethernet0 = &emac;
 		serial0 = &uart0;
 	};
 
-- 
2.13.0

[toc] | [prev] | [next] | [standalone]

#1694520

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-07-24 10:00 +0200
Message-ID<u6Grw-1RH-17@gated-at.bofh.it>
In reply to#1694093

[Multipart message — attachments visible in raw view] — view raw

On Sat, Jul 22, 2017 at 10:28:49AM +0800, Icenowy Zheng wrote:
> Allwinner A64 SoC has an EMAC which is used to provide Ethernet
> function on several boards.
> 
> The EMAC itself doesn't have a fixed MAC address, but the sunxi
> mainline U-Boot have the ability to generate one based on the eFUSE
> SID in the chip, and add the generated MAC address to the device
> tree when booting.
> 
> The MAC address setting step is based on the device tree's aliases,
> and device tree nodes prefixed "ethernet" will get the MAC address
> added. However, in several A64 boards' device tree, the alias is not
> set up, so that the U-Boot won't set the MAC address.
> 
> Add the ethernet0 aliases to these boards.
> 
> I hope this patchset can be queued in 4.13, otherwise 4.13 kernels
> won't get non-volatile MAC addresses, and will use random ones
> instead, which is annoying to many users.
> 
> Icenowy Zheng (3):
>   arm64: allwinner: a64: add ethernet0 alias for BPi M64 EMAC node
>   arm64: allwinner: a64: add ethernet0 alias for Pine64 EMAC node
>   arm64: allwinner: a64: add ethernet0 alias for SoPine EMAC node

Applied all three, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1695360

Fromicenowy@aosc.io
Date2017-07-25 05:10 +0200
Message-ID<u6Yop-5Rw-1@gated-at.bofh.it>
In reply to#1694520
在 2017-07-24 15:58，Maxime Ripard 写道：
> On Sat, Jul 22, 2017 at 10:28:49AM +0800, Icenowy Zheng wrote:
>> Allwinner A64 SoC has an EMAC which is used to provide Ethernet
>> function on several boards.
>> 
>> The EMAC itself doesn't have a fixed MAC address, but the sunxi
>> mainline U-Boot have the ability to generate one based on the eFUSE
>> SID in the chip, and add the generated MAC address to the device
>> tree when booting.
>> 
>> The MAC address setting step is based on the device tree's aliases,
>> and device tree nodes prefixed "ethernet" will get the MAC address
>> added. However, in several A64 boards' device tree, the alias is not
>> set up, so that the U-Boot won't set the MAC address.
>> 
>> Add the ethernet0 aliases to these boards.
>> 
>> I hope this patchset can be queued in 4.13, otherwise 4.13 kernels
>> won't get non-volatile MAC addresses, and will use random ones
>> instead, which is annoying to many users.
>> 
>> Icenowy Zheng (3):
>>   arm64: allwinner: a64: add ethernet0 alias for BPi M64 EMAC node
>>   arm64: allwinner: a64: add ethernet0 alias for Pine64 EMAC node
>>   arm64: allwinner: a64: add ethernet0 alias for SoPine EMAC node
> 
> Applied all three, thanks!

Sorry, but could you queue them to 4.13?

Otherwise 4.13 kernel release will have annoying random MAC problem,
which heavily affects headless usages.

> Maxime
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[toc] | [prev] | [next] | [standalone]

#1695361

FromAdam Borowski <kilobyte@angband.pl>
Date2017-07-25 05:30 +0200
Message-ID<u6YHM-5XO-3@gated-at.bofh.it>
In reply to#1695360
On Tue, Jul 25, 2017 at 11:04:24AM +0800, icenowy@aosc.io wrote:
> 在 2017-07-24 15:58，Maxime Ripard 写道：
> > On Sat, Jul 22, 2017 at 10:28:49AM +0800, Icenowy Zheng wrote:
> > > Allwinner A64 SoC has an EMAC which is used to provide Ethernet
> > > function on several boards.
> > > 
> > > The EMAC itself doesn't have a fixed MAC address, but the sunxi
> > > mainline U-Boot have the ability to generate one based on the eFUSE
> > > SID in the chip, and add the generated MAC address to the device
> > > tree when booting.
> > > 
> > > The MAC address setting step is based on the device tree's aliases,
> > > and device tree nodes prefixed "ethernet" will get the MAC address
> > > added. However, in several A64 boards' device tree, the alias is not
> > > set up, so that the U-Boot won't set the MAC address.
> > > 
> > > Add the ethernet0 aliases to these boards.
> > > 
> > > I hope this patchset can be queued in 4.13, otherwise 4.13 kernels
> > > won't get non-volatile MAC addresses, and will use random ones
> > > instead, which is annoying to many users.
> > > 
> > > Icenowy Zheng (3):
> > >   arm64: allwinner: a64: add ethernet0 alias for BPi M64 EMAC node
> > >   arm64: allwinner: a64: add ethernet0 alias for Pine64 EMAC node
> > >   arm64: allwinner: a64: add ethernet0 alias for SoPine EMAC node
> > 
> > Applied all three, thanks!
> 
> Sorry, but could you queue them to 4.13?
> 
> Otherwise 4.13 kernel release will have annoying random MAC problem,
> which heavily affects headless usages.

Perhaps it would be better to reword the commit subject as "fix missing
ethernet0 alias ..."?  That'd convey that the previous behaviour is a defect
that needs these patches as a fix.


Meow!
-- 
// If you believe in so-called "intellectual property", please immediately
// cease using counterfeit alphabets.  Instead, contact the nearest temple
// of Amon, whose priests will provide you with scribal services for all
// your writing needs, for Reasonable and Non-Discriminatory prices.

[toc] | [prev] | [next] | [standalone]

#1695788

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-07-25 16:40 +0200
Message-ID<u79a9-3YE-11@gated-at.bofh.it>
In reply to#1695361

[Multipart message — attachments visible in raw view] — view raw

On Tue, Jul 25, 2017 at 05:18:19AM +0200, Adam Borowski wrote:
> On Tue, Jul 25, 2017 at 11:04:24AM +0800, icenowy@aosc.io wrote:
> > 在 2017-07-24 15:58，Maxime Ripard 写道：
> > > On Sat, Jul 22, 2017 at 10:28:49AM +0800, Icenowy Zheng wrote:
> > > > Allwinner A64 SoC has an EMAC which is used to provide Ethernet
> > > > function on several boards.
> > > > 
> > > > The EMAC itself doesn't have a fixed MAC address, but the sunxi
> > > > mainline U-Boot have the ability to generate one based on the eFUSE
> > > > SID in the chip, and add the generated MAC address to the device
> > > > tree when booting.
> > > > 
> > > > The MAC address setting step is based on the device tree's aliases,
> > > > and device tree nodes prefixed "ethernet" will get the MAC address
> > > > added. However, in several A64 boards' device tree, the alias is not
> > > > set up, so that the U-Boot won't set the MAC address.
> > > > 
> > > > Add the ethernet0 aliases to these boards.
> > > > 
> > > > I hope this patchset can be queued in 4.13, otherwise 4.13 kernels
> > > > won't get non-volatile MAC addresses, and will use random ones
> > > > instead, which is annoying to many users.
> > > > 
> > > > Icenowy Zheng (3):
> > > >   arm64: allwinner: a64: add ethernet0 alias for BPi M64 EMAC node
> > > >   arm64: allwinner: a64: add ethernet0 alias for Pine64 EMAC node
> > > >   arm64: allwinner: a64: add ethernet0 alias for SoPine EMAC node
> > > 
> > > Applied all three, thanks!
> > 
> > Sorry, but could you queue them to 4.13?
> > 
> > Otherwise 4.13 kernel release will have annoying random MAC problem,
> > which heavily affects headless usages.
> 
> Perhaps it would be better to reword the commit subject as "fix missing
> ethernet0 alias ..."?  That'd convey that the previous behaviour is a defect
> that needs these patches as a fix.

Yes, definitely.

That and having a fixes: tag.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1696670

FromIcenowy Zheng <icenowy@aosc.io>
Date2017-07-26 02:00 +0200
Message-ID<u7hU6-15V-5@gated-at.bofh.it>
In reply to#1695788

于 2017年7月25日 GMT+08:00 下午10:31:27, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
>On Tue, Jul 25, 2017 at 05:18:19AM +0200, Adam Borowski wrote:
>> On Tue, Jul 25, 2017 at 11:04:24AM +0800, icenowy@aosc.io wrote:
>> > 在 2017-07-24 15:58，Maxime Ripard 写道：
>> > > On Sat, Jul 22, 2017 at 10:28:49AM +0800, Icenowy Zheng wrote:
>> > > > Allwinner A64 SoC has an EMAC which is used to provide Ethernet
>> > > > function on several boards.
>> > > > 
>> > > > The EMAC itself doesn't have a fixed MAC address, but the sunxi
>> > > > mainline U-Boot have the ability to generate one based on the
>eFUSE
>> > > > SID in the chip, and add the generated MAC address to the
>device
>> > > > tree when booting.
>> > > > 
>> > > > The MAC address setting step is based on the device tree's
>aliases,
>> > > > and device tree nodes prefixed "ethernet" will get the MAC
>address
>> > > > added. However, in several A64 boards' device tree, the alias
>is not
>> > > > set up, so that the U-Boot won't set the MAC address.
>> > > > 
>> > > > Add the ethernet0 aliases to these boards.
>> > > > 
>> > > > I hope this patchset can be queued in 4.13, otherwise 4.13
>kernels
>> > > > won't get non-volatile MAC addresses, and will use random ones
>> > > > instead, which is annoying to many users.
>> > > > 
>> > > > Icenowy Zheng (3):
>> > > >   arm64: allwinner: a64: add ethernet0 alias for BPi M64 EMAC
>node
>> > > >   arm64: allwinner: a64: add ethernet0 alias for Pine64 EMAC
>node
>> > > >   arm64: allwinner: a64: add ethernet0 alias for SoPine EMAC
>node
>> > > 
>> > > Applied all three, thanks!
>> > 
>> > Sorry, but could you queue them to 4.13?
>> > 
>> > Otherwise 4.13 kernel release will have annoying random MAC
>problem,
>> > which heavily affects headless usages.
>> 
>> Perhaps it would be better to reword the commit subject as "fix
>missing
>> ethernet0 alias ..."?  That'd convey that the previous behaviour is a
>defect
>> that needs these patches as a fix.
>
>Yes, definitely.
>
>That and having a fixes: tag.

Should I resend them with different commit message?

>
>Maxime

[toc] | [prev] | [next] | [standalone]

#1696767 — Re: [linux-sunxi] Re: [PATCH 0/3] Add ethernet0 alias for several A64 boards

FromChen-Yu Tsai <wens@csie.org>
Date2017-07-26 06:20 +0200
SubjectRe: [linux-sunxi] Re: [PATCH 0/3] Add ethernet0 alias for several A64 boards
Message-ID<u7lXH-3Sd-3@gated-at.bofh.it>
In reply to#1696670
On Wed, Jul 26, 2017 at 7:54 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>
>
> 于 2017年7月25日 GMT+08:00 下午10:31:27, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
>>On Tue, Jul 25, 2017 at 05:18:19AM +0200, Adam Borowski wrote:
>>> On Tue, Jul 25, 2017 at 11:04:24AM +0800, icenowy@aosc.io wrote:
>>> > 在 2017-07-24 15:58，Maxime Ripard 写道：
>>> > > On Sat, Jul 22, 2017 at 10:28:49AM +0800, Icenowy Zheng wrote:
>>> > > > Allwinner A64 SoC has an EMAC which is used to provide Ethernet
>>> > > > function on several boards.
>>> > > >
>>> > > > The EMAC itself doesn't have a fixed MAC address, but the sunxi
>>> > > > mainline U-Boot have the ability to generate one based on the
>>eFUSE
>>> > > > SID in the chip, and add the generated MAC address to the
>>device
>>> > > > tree when booting.
>>> > > >
>>> > > > The MAC address setting step is based on the device tree's
>>aliases,
>>> > > > and device tree nodes prefixed "ethernet" will get the MAC
>>address
>>> > > > added. However, in several A64 boards' device tree, the alias
>>is not
>>> > > > set up, so that the U-Boot won't set the MAC address.
>>> > > >
>>> > > > Add the ethernet0 aliases to these boards.
>>> > > >
>>> > > > I hope this patchset can be queued in 4.13, otherwise 4.13
>>kernels
>>> > > > won't get non-volatile MAC addresses, and will use random ones
>>> > > > instead, which is annoying to many users.
>>> > > >
>>> > > > Icenowy Zheng (3):
>>> > > >   arm64: allwinner: a64: add ethernet0 alias for BPi M64 EMAC
>>node
>>> > > >   arm64: allwinner: a64: add ethernet0 alias for Pine64 EMAC
>>node
>>> > > >   arm64: allwinner: a64: add ethernet0 alias for SoPine EMAC
>>node
>>> > >
>>> > > Applied all three, thanks!
>>> >
>>> > Sorry, but could you queue them to 4.13?
>>> >
>>> > Otherwise 4.13 kernel release will have annoying random MAC
>>problem,
>>> > which heavily affects headless usages.
>>>
>>> Perhaps it would be better to reword the commit subject as "fix
>>missing
>>> ethernet0 alias ..."?  That'd convey that the previous behaviour is a
>>defect
>>> that needs these patches as a fix.
>>
>>Yes, definitely.
>>
>>That and having a fixes: tag.
>
> Should I resend them with different commit message?

Yes please. And add the "Fixes:" tag.

ChenYu

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web