Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1695849 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-07-25 17:40 +0200 |
| Last post | 2017-07-26 09:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] device property: export irqchip_fwnode_ops Arnd Bergmann <arnd@arndb.de> - 2017-07-25 17:40 +0200
Re: [PATCH] device property: export irqchip_fwnode_ops "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-26 02:30 +0200
Re: [PATCH] device property: export irqchip_fwnode_ops Arnd Bergmann <arnd@arndb.de> - 2017-07-26 09:10 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-07-25 17:40 +0200 |
| Subject | [PATCH] device property: export irqchip_fwnode_ops |
| Message-ID | <u7a6d-4Ah-1@gated-at.bofh.it> |
The newly added irqchip_fwnode_ops structure is not exported, which can
lead to link errors:
ERROR: "irqchip_fwnode_ops" [drivers/gpio/gpio-xgene-sb.ko] undefined!
I checked that all other such symbols that were introduced are
exported if they need to be, this is the only missing one.
Fixes: db3e50f3234b ("device property: Get rid of struct fwnode_handle type field")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/irq/irqdomain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index e064fd1390f1..9e8a075117a3 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -42,6 +42,7 @@ static inline void debugfs_remove_domain_dir(struct irq_domain *d) { }
#endif
const struct fwnode_operations irqchip_fwnode_ops;
+EXPORT_SYMBOL_GPL(irqchip_fwnode_ops);
/**
* irq_domain_alloc_fwnode - Allocate a fwnode_handle suitable for
--
2.9.0
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2017-07-26 02:30 +0200 |
| Message-ID | <u7in7-1wt-1@gated-at.bofh.it> |
| In reply to | #1695849 |
On Tuesday, July 25, 2017 05:32:31 PM Arnd Bergmann wrote:
> The newly added irqchip_fwnode_ops structure is not exported, which can
> lead to link errors:
>
> ERROR: "irqchip_fwnode_ops" [drivers/gpio/gpio-xgene-sb.ko] undefined!
>
> I checked that all other such symbols that were introduced are
> exported if they need to be, this is the only missing one.
>
> Fixes: db3e50f3234b ("device property: Get rid of struct fwnode_handle type field")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the fix.
It is linux-next only at this point, isn't it?
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-07-26 09:10 +0200 |
| Message-ID | <u7oCd-5E8-3@gated-at.bofh.it> |
| In reply to | #1696680 |
On Wed, Jul 26, 2017 at 2:13 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, July 25, 2017 05:32:31 PM Arnd Bergmann wrote:
>> The newly added irqchip_fwnode_ops structure is not exported, which can
>> lead to link errors:
>>
>> ERROR: "irqchip_fwnode_ops" [drivers/gpio/gpio-xgene-sb.ko] undefined!
>>
>> I checked that all other such symbols that were introduced are
>> exported if they need to be, this is the only missing one.
>>
>> Fixes: db3e50f3234b ("device property: Get rid of struct fwnode_handle type field")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks for the fix.
>
> It is linux-next only at this point, isn't it?
Correct, this is how I decided to send it to you rather than the
irqchip maintainers:
$ git log --oneline --ancestry-path --merges
db3e50f3234b..next/master | tail -n 5
cd8d05edc1ca Merge remote-tracking branch 'idle/next'
db7be21c3bad Merge remote-tracking branch 'pm/linux-next'
e2e9e06e4bb2 Merge branch 'acpi-numa' into linux-next
ed1d633e4584 Merge branches 'pm-tools' and 'pm-sleep' into linux-next
796cbe7125c1 Merge branch 'device-properties' into linux-next
Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web