Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1698137 > unrolled thread
| Started by | Taeung Song <treeze.taeung@gmail.com> |
|---|---|
| First post | 2017-07-27 18:20 +0200 |
| Last post | 2017-07-27 19:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v4 2/9] perf annotate: Initialize proper width for first column Taeung Song <treeze.taeung@gmail.com> - 2017-07-27 18:20 +0200
Re: [PATCH v4 2/9] perf annotate: Initialize proper width for first column Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-27 19:00 +0200
| From | Taeung Song <treeze.taeung@gmail.com> |
|---|---|
| Date | 2017-07-27 18:20 +0200 |
| Subject | [PATCH v4 2/9] perf annotate: Initialize proper width for first column |
| Message-ID | <u7TG2-8lQ-17@gated-at.bofh.it> |
When using --show-total-period or not,
set the width value for first column.
Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
tools/perf/util/annotate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 5963764..5125c2b 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1165,7 +1165,7 @@ static int disasm_line__print(struct disasm_line *dl, struct symbol *sym, u64 st
} else if (max_lines && printed >= max_lines)
return 1;
else {
- int width = 8;
+ int width = symbol_conf.show_total_period ? 12 : 8;
if (queue)
return -1;
@@ -1806,7 +1806,7 @@ int symbol__annotate_printf(struct symbol *sym, struct map *map,
int printed = 2, queue_len = 0;
int more = 0;
u64 len;
- int width = 8;
+ int width = symbol_conf.show_total_period ? 12 : 8;
int graph_dotted_len;
filename = strdup(dso->long_name);
--
2.7.4
[toc] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2017-07-27 19:00 +0200 |
| Subject | Re: [PATCH v4 2/9] perf annotate: Initialize proper width for first column |
| Message-ID | <u7UiK-6K-27@gated-at.bofh.it> |
| In reply to | #1698137 |
Em Fri, Jul 28, 2017 at 01:15:56AM +0900, Taeung Song escreveu:
> When using --show-total-period or not,
> set the width value for first column.
>
> Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
> tools/perf/util/annotate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 5963764..5125c2b 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -1165,7 +1165,7 @@ static int disasm_line__print(struct disasm_line *dl, struct symbol *sym, u64 st
> } else if (max_lines && printed >= max_lines)
> return 1;
> else {
> - int width = 8;
> + int width = symbol_conf.show_total_period ? 12 : 8;
>
> if (queue)
> return -1;
> @@ -1806,7 +1806,7 @@ int symbol__annotate_printf(struct symbol *sym, struct map *map,
> int printed = 2, queue_len = 0;
> int more = 0;
> u64 len;
> - int width = 8;
> + int width = symbol_conf.show_total_period ? 12 : 8;
> int graph_dotted_len;
Already at:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=ce9ee4a2de20062a97ad50ecc11ebda7e7618fd1
- Arnaldo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web