Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1697689 > unrolled thread
| Started by | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| First post | 2017-07-27 05:20 +0200 |
| Last post | 2017-07-27 07:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: greybus: Remove unnecessary platform_set_drvdata Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2017-07-27 05:20 +0200
Re: [greybus-dev] [PATCH] staging: greybus: Remove unnecessary platform_set_drvdata Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-27 07:10 +0200
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2017-07-27 05:20 +0200 |
| Subject | [PATCH] staging: greybus: Remove unnecessary platform_set_drvdata |
| Message-ID | <u7Hvb-Kv-7@gated-at.bofh.it> |
Unnecessary platform_set_drvdata() has been removed since the driver core clears the driver data to NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL. The Coccinelle semantic patch used to make this change is as follows: //<smpl> @@ struct platform_device *pdev; @@ - platform_set_drvdata(pdev, NULL); //</smpl> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> --- drivers/staging/greybus/arche-platform.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index eced2d2..358b260 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -607,7 +607,6 @@ static int arche_platform_remove(struct platform_device *pdev) device_remove_file(&pdev->dev, &dev_attr_state); device_for_each_child(&pdev->dev, NULL, arche_remove_child); arche_platform_poweroff_seq(arche_pdata); - platform_set_drvdata(pdev, NULL); if (usb3613_hub_mode_ctrl(false)) dev_warn(arche_pdata->dev, "failed to control hub device\n"); -- 2.7.4
[toc] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2017-07-27 07:10 +0200 |
| Subject | Re: [greybus-dev] [PATCH] staging: greybus: Remove unnecessary platform_set_drvdata |
| Message-ID | <u7JdF-1Tb-21@gated-at.bofh.it> |
| In reply to | #1697689 |
On 26-07-17, 23:19, Amitoj Kaur Chawla wrote: > Unnecessary platform_set_drvdata() has been removed since the driver > core clears the driver data to NULL after device release or on > probe failure. There is no need to manually clear the device > driver data to NULL. > > The Coccinelle semantic patch used to make this change is as follows: > //<smpl> > @@ > struct platform_device *pdev; > @@ > - platform_set_drvdata(pdev, NULL); > //</smpl> > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> > --- > drivers/staging/greybus/arche-platform.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c > index eced2d2..358b260 100644 > --- a/drivers/staging/greybus/arche-platform.c > +++ b/drivers/staging/greybus/arche-platform.c > @@ -607,7 +607,6 @@ static int arche_platform_remove(struct platform_device *pdev) > device_remove_file(&pdev->dev, &dev_attr_state); > device_for_each_child(&pdev->dev, NULL, arche_remove_child); > arche_platform_poweroff_seq(arche_pdata); > - platform_set_drvdata(pdev, NULL); > > if (usb3613_hub_mode_ctrl(false)) > dev_warn(arche_pdata->dev, "failed to control hub device\n"); Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- viresh
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web