Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1697657 > unrolled thread

[PATCH 0/3] Add larbid init routine for mediatek's gen1 smi larb driver

Started by<honghui.zhang@mediatek.com>
First post2017-07-27 04:10 +0200
Last post2017-07-28 03:00 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] Add larbid init routine for mediatek's gen1 smi larb driver <honghui.zhang@mediatek.com> - 2017-07-27 04:10 +0200
    [PATCH 3/3] arm: dts: mediatek: add larbid property for larb <honghui.zhang@mediatek.com> - 2017-07-27 04:10 +0200
    [PATCH 2/3] dt-bindings: mediatek: add descriptions for larbid <honghui.zhang@mediatek.com> - 2017-07-27 04:10 +0200
    Re: [PATCH 0/3] Add larbid init routine for mediatek's gen1 smi larb  driver Joerg Roedel <joro@8bytes.org> - 2017-07-27 15:00 +0200
      Re: [PATCH 0/3] Add larbid init routine for mediatek's gen1 smi  larb driver Honghui Zhang <honghui.zhang@mediatek.com> - 2017-07-28 03:00 +0200

#1697657 — [PATCH 0/3] Add larbid init routine for mediatek's gen1 smi larb driver

From<honghui.zhang@mediatek.com>
Date2017-07-27 04:10 +0200
Subject[PATCH 0/3] Add larbid init routine for mediatek's gen1 smi larb driver
Message-ID<u7Gpr-8rh-3@gated-at.bofh.it>
From: Honghui Zhang <honghui.zhang@mediatek.com>

Mediatek's gen1 smi need the hardware larbid to identify the offset for
the register which controls whether enable iommu for this larb.
In the commit 3c8f4ad85c4b ("memory/mediatek: add support for mt2701"),
the larbid was used without properly initialized. This patchset fixed
that.

Honghui Zhang (3):
  memory: mtk-smi: add larbid init routine
  dt-bindings: mediatek: add descriptions for larbid
  arm: dts: mediatek: add larbid property for larb

 .../bindings/memory-controllers/mediatek,smi-larb.txt     | 15 +++++++++++++++
 arch/arm/boot/dts/mt2701.dtsi                             |  3 +++
 drivers/memory/mtk-smi.c                                  |  9 +++++++++
 3 files changed, 27 insertions(+)

-- 
2.6.4

[toc] | [next] | [standalone]

#1697658 — [PATCH 3/3] arm: dts: mediatek: add larbid property for larb

From<honghui.zhang@mediatek.com>
Date2017-07-27 04:10 +0200
Subject[PATCH 3/3] arm: dts: mediatek: add larbid property for larb
Message-ID<u7Gpr-8rh-5@gated-at.bofh.it>
In reply to#1697657
From: Honghui Zhang <honghui.zhang@mediatek.com>

Add mediatek's hardware id information for smi larb.

Signed-off-by: Honghui Zhang <honghui.zhang@mediatek.com>
---
 arch/arm/boot/dts/mt2701.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
index f1efdc6..2cddbec 100644
--- a/arch/arm/boot/dts/mt2701.dtsi
+++ b/arch/arm/boot/dts/mt2701.dtsi
@@ -533,6 +533,7 @@
 		compatible = "mediatek,mt2701-smi-larb";
 		reg = <0 0x14010000 0 0x1000>;
 		mediatek,smi = <&smi_common>;
+		mediatek,larbid = <0>;
 		clocks = <&mmsys CLK_MM_SMI_LARB0>,
 			 <&mmsys CLK_MM_SMI_LARB0>;
 		clock-names = "apb", "smi";
@@ -549,6 +550,7 @@
 		compatible = "mediatek,mt2701-smi-larb";
 		reg = <0 0x15001000 0 0x1000>;
 		mediatek,smi = <&smi_common>;
+		mediatek,larbid = <2>;
 		clocks = <&imgsys CLK_IMG_SMI_COMM>,
 			 <&imgsys CLK_IMG_SMI_COMM>;
 		clock-names = "apb", "smi";
@@ -579,6 +581,7 @@
 		compatible = "mediatek,mt2701-smi-larb";
 		reg = <0 0x16010000 0 0x1000>;
 		mediatek,smi = <&smi_common>;
+		mediatek,larbid = <1>;
 		clocks = <&vdecsys CLK_VDEC_CKGEN>,
 			 <&vdecsys CLK_VDEC_LARB>;
 		clock-names = "apb", "smi";
-- 
2.6.4

[toc] | [prev] | [next] | [standalone]

#1697659 — [PATCH 2/3] dt-bindings: mediatek: add descriptions for larbid

From<honghui.zhang@mediatek.com>
Date2017-07-27 04:10 +0200
Subject[PATCH 2/3] dt-bindings: mediatek: add descriptions for larbid
Message-ID<u7Gps-8rh-7@gated-at.bofh.it>
In reply to#1697657
From: Honghui Zhang <honghui.zhang@mediatek.com>

This patch add larbid descritptions for mediatek's gen1 smi larb hardware.

Signed-off-by: Honghui Zhang <honghui.zhang@mediatek.com>
---
 .../bindings/memory-controllers/mediatek,smi-larb.txt     | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt
index 21277a5..d1b115c 100644
--- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt
+++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt
@@ -15,6 +15,9 @@ Required properties:
 	    the register.
   - "smi" : It's the clock for transfer data and command.
 
+Required property for mt2701:
+- mediatek,larbid :the hardware id of this larb.
+
 Example:
 	larb1: larb@16010000 {
 		compatible = "mediatek,mt8173-smi-larb";
@@ -25,3 +28,15 @@ Example:
 			 <&vdecsys CLK_VDEC_LARB_CKEN>;
 		clock-names = "apb", "smi";
 	};
+
+Example for mt2701:
+	larb0: larb@14010000 {
+		compatible = "mediatek,mt2701-smi-larb";
+		reg = <0 0x14010000 0 0x1000>;
+		mediatek,smi = <&smi_common>;
+		mediatek,larbid = <0>;
+		clocks = <&mmsys CLK_MM_SMI_LARB0>,
+			 <&mmsys CLK_MM_SMI_LARB0>;
+		clock-names = "apb", "smi";
+		power-domains = <&scpsys MT2701_POWER_DOMAIN_DISP>;
+	};
-- 
2.6.4

[toc] | [prev] | [next] | [standalone]

#1697955 — Re: [PATCH 0/3] Add larbid init routine for mediatek's gen1 smi larb driver

FromJoerg Roedel <joro@8bytes.org>
Date2017-07-27 15:00 +0200
SubjectRe: [PATCH 0/3] Add larbid init routine for mediatek's gen1 smi larb driver
Message-ID<u7Qyt-6dA-5@gated-at.bofh.it>
In reply to#1697657
On Thu, Jul 27, 2017 at 10:01:09AM +0800, honghui.zhang@mediatek.com wrote:
> From: Honghui Zhang <honghui.zhang@mediatek.com>
> 
> Mediatek's gen1 smi need the hardware larbid to identify the offset for
> the register which controls whether enable iommu for this larb.
> In the commit 3c8f4ad85c4b ("memory/mediatek: add support for mt2701"),
> the larbid was used without properly initialized. This patchset fixed
> that.
> 
> Honghui Zhang (3):
>   memory: mtk-smi: add larbid init routine
>   dt-bindings: mediatek: add descriptions for larbid
>   arm: dts: mediatek: add larbid property for larb

What are these patches based on? They don't apply to v4.13-rc2.



	Joerg

[toc] | [prev] | [next] | [standalone]

#1698392 — Re: [PATCH 0/3] Add larbid init routine for mediatek's gen1 smi larb driver

FromHonghui Zhang <honghui.zhang@mediatek.com>
Date2017-07-28 03:00 +0200
SubjectRe: [PATCH 0/3] Add larbid init routine for mediatek's gen1 smi larb driver
Message-ID<u81Nf-4Zl-3@gated-at.bofh.it>
In reply to#1697955
On Thu, 2017-07-27 at 14:58 +0200, Joerg Roedel wrote:
> On Thu, Jul 27, 2017 at 10:01:09AM +0800, honghui.zhang@mediatek.com wrote:
> > From: Honghui Zhang <honghui.zhang@mediatek.com>
> > 
> > Mediatek's gen1 smi need the hardware larbid to identify the offset for
> > the register which controls whether enable iommu for this larb.
> > In the commit 3c8f4ad85c4b ("memory/mediatek: add support for mt2701"),
> > the larbid was used without properly initialized. This patchset fixed
> > that.
> > 
> > Honghui Zhang (3):
> >   memory: mtk-smi: add larbid init routine
> >   dt-bindings: mediatek: add descriptions for larbid
> >   arm: dts: mediatek: add larbid property for larb
> 
> What are these patches based on? They don't apply to v4.13-rc2.
> 
> 

Hi, Joerg,
	this patchset was base on the patch v2 version
memory: mtk-smi: Use of_device_get_match_data helper[1],
and it's base on 4.13-rc1

[1] https://patchwork.kernel.org/patch/9864719

thanks
> 
> 	Joerg
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web