Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1697553 > unrolled thread

[PATCH] btrfs: Remove extra parentheses from condition in copy_items()

Back to article view | Back to linux.kernel

Contents

  [PATCH] btrfs: Remove extra parentheses from condition in copy_items() Matthias Kaehlcke <mka@chromium.org> - 2017-07-26 22:50 +0200
    Re: [PATCH] btrfs: Remove extra parentheses from condition in  copy_items() Christoph Hellwig <hch@infradead.org> - 2017-07-27 12:10 +0200

#1697553 — [PATCH] btrfs: Remove extra parentheses from condition in copy_items()

There is no need for the extra pair of parentheses, remove it. This
fixes the following warning when building with clang:

fs/btrfs/tree-log.c:3694:10: warning: equality comparison with extraneous
  parentheses [-Wparentheses-equality]
                if ((i == (nr - 1)))
                     ~~^~~~~~~~~~~

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 fs/btrfs/tree-log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index f20ef211a73d..b92408a3f834 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -3691,7 +3691,7 @@ static noinline int copy_items(struct btrfs_trans_handle *trans,
 
 		src_offset = btrfs_item_ptr_offset(src, start_slot + i);
 
-		if ((i == (nr - 1)))
+		if (i == (nr - 1))
 			last_key = ins_keys[i];
 
 		if (ins_keys[i].type == BTRFS_INODE_ITEM_KEY) {
-- 
2.14.0.rc0.400.g1c36432dff-goog

[toc] | [next] | [standalone]

#1697864 — Re: [PATCH] btrfs: Remove extra parentheses from condition in copy_items()

> -		if ((i == (nr - 1)))
> +		if (i == (nr - 1))

Please remove the other set of redundant parentheses as well if you
change that line.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web