Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695462 > unrolled thread

[PATCH] kselftest/timers: fix build failure

Back to article view | Back to linux.kernel

Contents

  [PATCH] kselftest/timers: fix build failure Santosh Sivaraj <santosh@fossix.org> - 2017-07-25 10:00 +0200
    Re: [PATCH] kselftest/timers: fix build failure Miroslav Lichvar <mlichvar@redhat.com> - 2017-07-25 14:50 +0200
      [PATCH v2] kselftest/timers: fix build failure Santosh Sivaraj <santosh@fossix.org> - 2017-07-25 15:40 +0200

#1695462 — [PATCH] kselftest/timers: fix build failure

"message" parameter was not passed to ksft_exit_skip.

Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
---
 tools/testing/selftests/timers/freq-step.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/timers/freq-step.c b/tools/testing/selftests/timers/freq-step.c
index e8c6183..bda9744 100644
--- a/tools/testing/selftests/timers/freq-step.c
+++ b/tools/testing/selftests/timers/freq-step.c
@@ -231,7 +231,7 @@ static void init_test(void)
 
 	if (precision > MAX_PRECISION) {
 		printf("[SKIP]\n");
-		ksft_exit_skip();
+		ksft_exit_skip("[SKIP]\n");
 	}
 
 	printf("[OK]\n");
-- 
2.9.4

[toc] | [next] | [standalone]

#1695699

On Tue, Jul 25, 2017 at 01:20:37PM +0530, Santosh Sivaraj wrote:
> "message" parameter was not passed to ksft_exit_skip.

It looks like this was a bad merge of 76739256 and 54f57baa, which
added the new parameter to ksft_exit_skip().

> @@ -231,7 +231,7 @@ static void init_test(void)
>  
>  	if (precision > MAX_PRECISION) {
>  		printf("[SKIP]\n");
> -		ksft_exit_skip();
> +		ksft_exit_skip("[SKIP]\n");

To avoid printing "skip" multiple times, I'd suggest to change the
argument of ksft_exit_skip to NULL.

Thanks,

-- 
Miroslav Lichvar

[toc] | [prev] | [next] | [standalone]

#1695730 — [PATCH v2] kselftest/timers: fix build failure

Pass missing parameter to ksft_exit_skip.

Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
---
V2 update: Pass NULL as suggested by Miroslav Lichvar

 tools/testing/selftests/timers/freq-step.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/timers/freq-step.c b/tools/testing/selftests/timers/freq-step.c
index e8c6183..deff065 100644
--- a/tools/testing/selftests/timers/freq-step.c
+++ b/tools/testing/selftests/timers/freq-step.c
@@ -231,7 +231,7 @@ static void init_test(void)
 
 	if (precision > MAX_PRECISION) {
 		printf("[SKIP]\n");
-		ksft_exit_skip();
+		ksft_exit_skip(NULL);
 	}
 
 	printf("[OK]\n");
-- 
2.9.4

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web