Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693829 > unrolled thread

[PATCH] drm: tegra: add CONFIG_OF dependency

Started byArnd Bergmann <arnd@arndb.de>
First post2017-07-21 18:20 +0200
Last post2017-07-25 14:00 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] drm: tegra: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-21 18:20 +0200
    Re: [PATCH] drm: tegra: add CONFIG_OF dependency Jon Hunter <jonathanh@nvidia.com> - 2017-07-25 10:30 +0200
      Re: [PATCH] drm: tegra: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-25 14:00 +0200

#1693829 — [PATCH] drm: tegra: add CONFIG_OF dependency

FromArnd Bergmann <arnd@arndb.de>
Date2017-07-21 18:20 +0200
Subject[PATCH] drm: tegra: add CONFIG_OF dependency
Message-ID<u5IOJ-73n-15@gated-at.bofh.it>
Without CONFIG_OF, we can run into a build error:

drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
  .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                    pinconf_generic_params
drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?

This adds an explicit dependency.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/tegra/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
index 2db29d67193d..dc58ab140151 100644
--- a/drivers/gpu/drm/tegra/Kconfig
+++ b/drivers/gpu/drm/tegra/Kconfig
@@ -3,6 +3,7 @@ config DRM_TEGRA
 	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
 	depends on COMMON_CLK
 	depends on DRM
+	depends on OF
 	select DRM_KMS_HELPER
 	select DRM_MIPI_DSI
 	select DRM_PANEL
-- 
2.9.0

[toc] | [next] | [standalone]

#1695490

FromJon Hunter <jonathanh@nvidia.com>
Date2017-07-25 10:30 +0200
Message-ID<u73o6-oR-23@gated-at.bofh.it>
In reply to#1693829
On 21/07/17 17:13, Arnd Bergmann wrote:
> Without CONFIG_OF, we can run into a build error:
> 
> drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>   .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                     pinconf_generic_params
> drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
> 
> This adds an explicit dependency.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/tegra/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
> index 2db29d67193d..dc58ab140151 100644
> --- a/drivers/gpu/drm/tegra/Kconfig
> +++ b/drivers/gpu/drm/tegra/Kconfig
> @@ -3,6 +3,7 @@ config DRM_TEGRA
>  	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>  	depends on COMMON_CLK
>  	depends on DRM
> +	depends on OF
>  	select DRM_KMS_HELPER
>  	select DRM_MIPI_DSI
>  	select DRM_PANEL

Thanks Arnd. I am curious if it can still fail if PINCTRL is not
selected in whatever config you are using?

That said ...

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic

[toc] | [prev] | [next] | [standalone]

#1695656

FromArnd Bergmann <arnd@arndb.de>
Date2017-07-25 14:00 +0200
Message-ID<u76Fl-2je-27@gated-at.bofh.it>
In reply to#1695490
On Tue, Jul 25, 2017 at 10:25 AM, Jon Hunter <jonathanh@nvidia.com> wrote:
>
> On 21/07/17 17:13, Arnd Bergmann wrote:
>> Without CONFIG_OF, we can run into a build error:
>>
>> drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>>   .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>>                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>                     pinconf_generic_params
>> drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>>
>> This adds an explicit dependency.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  drivers/gpu/drm/tegra/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
>> index 2db29d67193d..dc58ab140151 100644
>> --- a/drivers/gpu/drm/tegra/Kconfig
>> +++ b/drivers/gpu/drm/tegra/Kconfig
>> @@ -3,6 +3,7 @@ config DRM_TEGRA
>>       depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>>       depends on COMMON_CLK
>>       depends on DRM
>> +     depends on OF
>>       select DRM_KMS_HELPER
>>       select DRM_MIPI_DSI
>>       select DRM_PANEL
>
> Thanks Arnd. I am curious if it can still fail if PINCTRL is not
> selected in whatever config you are using?

I have not run into other those problems in many randconfig builds.
Looking at the driver now, I see it has an "#ifdef CONFIG_GENERIC_PINCONF"
to handle that case.

        Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web