Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1695515 > unrolled thread

[PATCH 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for rk3328 in dts

Started byRocky Hao <rocky.hao@rock-chips.com>
First post2017-07-25 11:10 +0200
Last post2017-07-25 11:20 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for rk3328 in dts Rocky Hao <rocky.hao@rock-chips.com> - 2017-07-25 11:10 +0200
    [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible Rocky Hao <rocky.hao@rock-chips.com> - 2017-07-25 11:10 +0200
      Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible Heiko Stübner <heiko@sntech.de> - 2017-07-27 08:40 +0200
        Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC  compatible "rocky.hao" <rocky.hao@rock-chips.com> - 2017-07-27 08:50 +0200
    [PATCH 3/5] arm64: dts: rockchip: add tsadc node for rk3328 SoC Rocky Hao <rocky.hao@rock-chips.com> - 2017-07-25 11:10 +0200
    [PATCH 5/5] arm64: dts: rockchip: Enable tsadc module on RK3328 eavluation board Rocky Hao <rocky.hao@rock-chips.com> - 2017-07-25 11:20 +0200

#1695515 — [PATCH 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for rk3328 in dts

FromRocky Hao <rocky.hao@rock-chips.com>
Date2017-07-25 11:10 +0200
Subject[PATCH 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for rk3328 in dts
Message-ID<u740N-So-7@gated-at.bofh.it>
This series patches add the tsadc support in thermal driver and in devicetree for rk3328.
Also add thermal control with Intelligent Power Allocation (IPA) policy by default.  Please
refer to https://developer.arm.com/open-source/intelligent-power-allocation for more information
about IPA.


Rocky Hao (5):
  dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible
  thermal: rockchip: Support the RK3328 SOC in thermal driver
  arm64: dts: rockchip: add tsadc node for rk3328 SoC
  arm64: dts: rockchip: add thermal nodes for rk3328 SoC
  arm64: dts: rockchip: Enable tsadc module on RK3328 eavluation board

 .../bindings/thermal/rockchip-thermal.txt          |  1 +
 arch/arm64/boot/dts/rockchip/rk3328-evb.dts        |  4 ++
 arch/arm64/boot/dts/rockchip/rk3328.dtsi           | 63 +++++++++++++++++++++
 drivers/thermal/rockchip_thermal.c                 | 65 ++++++++++++++++++++++
 4 files changed, 133 insertions(+)

-- 
1.9.1

[toc] | [next] | [standalone]


#1695518 — [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible

FromRocky Hao <rocky.hao@rock-chips.com>
Date2017-07-25 11:10 +0200
Subject[PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible
Message-ID<u740O-So-31@gated-at.bofh.it>
In reply to#1695515
attempt to new compatible for thermal founding on RK3328 SoC.

Change-Id: Ie6f6d7b4e545891a0035851a923c0412f584140c
Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>
---
 Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
index 43003aec94bd..e3a6234fb1ac 100644
--- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
@@ -4,6 +4,7 @@ Required properties:
 - compatible : should be "rockchip,<name>-tsadc"
    "rockchip,rk3228-tsadc": found on RK3228 SoCs
    "rockchip,rk3288-tsadc": found on RK3288 SoCs
+   "rockchip,rk3328-tsadc": found on RK3328 SoCs
    "rockchip,rk3368-tsadc": found on RK3368 SoCs
    "rockchip,rk3399-tsadc": found on RK3399 SoCs
 - reg : physical base address of the controller and length of memory mapped
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]


#1697749 — Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible

FromHeiko Stübner <heiko@sntech.de>
Date2017-07-27 08:40 +0200
SubjectRe: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible
Message-ID<u7KCK-2Dt-27@gated-at.bofh.it>
In reply to#1695518
Hi Rocky,

Am Dienstag, 25. Juli 2017, 17:09:44 CEST schrieb Rocky Hao:
> attempt to new compatible for thermal founding on RK3328 SoC.
> 
> Change-Id: Ie6f6d7b4e545891a0035851a923c0412f584140c
> Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>

generally looks good but you should not have gerrit Change-Ids in patches
for mainline. This is true for all patches in this series.


Heiko

> ---
>  Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt index
> 43003aec94bd..e3a6234fb1ac 100644
> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> @@ -4,6 +4,7 @@ Required properties:
>  - compatible : should be "rockchip,<name>-tsadc"
>     "rockchip,rk3228-tsadc": found on RK3228 SoCs
>     "rockchip,rk3288-tsadc": found on RK3288 SoCs
> +   "rockchip,rk3328-tsadc": found on RK3328 SoCs
>     "rockchip,rk3368-tsadc": found on RK3368 SoCs
>     "rockchip,rk3399-tsadc": found on RK3399 SoCs
>  - reg : physical base address of the controller and length of memory mapped

[toc] | [prev] | [next] | [standalone]


#1697750 — Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible

From"rocky.hao" <rocky.hao@rock-chips.com>
Date2017-07-27 08:50 +0200
SubjectRe: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible
Message-ID<u7KMp-2GF-1@gated-at.bofh.it>
In reply to#1697749
Hi Heiko,
Thank you for the quick reply. I will remove the gerrit Change-Ids in my 
v2 patches.

Thanks again,
Rocky

在 2017/7/27 14:36, Heiko Stübner 写道:
> Hi Rocky,
> 
> Am Dienstag, 25. Juli 2017, 17:09:44 CEST schrieb Rocky Hao:
>> attempt to new compatible for thermal founding on RK3328 SoC.
>>
>> Change-Id: Ie6f6d7b4e545891a0035851a923c0412f584140c
>> Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>
> 
> generally looks good but you should not have gerrit Change-Ids in patches
> for mainline. This is true for all patches in this series.
> 
> 
> Heiko
> 
>> ---
>>   Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>> b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt index
>> 43003aec94bd..e3a6234fb1ac 100644
>> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>> @@ -4,6 +4,7 @@ Required properties:
>>   - compatible : should be "rockchip,<name>-tsadc"
>>      "rockchip,rk3228-tsadc": found on RK3228 SoCs
>>      "rockchip,rk3288-tsadc": found on RK3288 SoCs
>> +   "rockchip,rk3328-tsadc": found on RK3328 SoCs
>>      "rockchip,rk3368-tsadc": found on RK3368 SoCs
>>      "rockchip,rk3399-tsadc": found on RK3399 SoCs
>>   - reg : physical base address of the controller and length of memory mapped
> 
> 
> 
> 
> 

[toc] | [prev] | [next] | [standalone]


#1695521 — [PATCH 3/5] arm64: dts: rockchip: add tsadc node for rk3328 SoC

FromRocky Hao <rocky.hao@rock-chips.com>
Date2017-07-25 11:10 +0200
Subject[PATCH 3/5] arm64: dts: rockchip: add tsadc node for rk3328 SoC
Message-ID<u740O-So-39@gated-at.bofh.it>
In reply to#1695515
add tsadc needed main information for rk3328 SoC.
50000Hz is the max clock rate supported by tsadc module.

Change-Id: I2429c24edccd4c797e2f4577151be76372adfbe5
Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>
---
 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index db4b2708084d..186fb93fdffd 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -308,6 +308,26 @@
 		interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
 	};
 
+	tsadc: tsadc@ff250000 {
+		compatible = "rockchip,rk3328-tsadc";
+		reg = <0x0 0xff250000 0x0 0x100>;
+		interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH 0>;
+		rockchip,grf = <&grf>;
+		clocks = <&cru SCLK_TSADC>, <&cru PCLK_TSADC>;
+		clock-names = "tsadc", "apb_pclk";
+		assigned-clocks = <&cru SCLK_TSADC>;
+		assigned-clock-rates = <50000>;
+		resets = <&cru SRST_TSADC>;
+		reset-names = "tsadc-apb";
+		pinctrl-names = "init", "default", "sleep";
+		pinctrl-0 = <&otp_gpio>;
+		pinctrl-1 = <&otp_out>;
+		pinctrl-2 = <&otp_gpio>;
+		#thermal-sensor-cells = <1>;
+		rockchip,hw-tshut-temp = <100000>;
+		status = "disabled";
+	};
+
 	saradc: adc@ff280000 {
 		compatible = "rockchip,rk3328-saradc", "rockchip,rk3399-saradc";
 		reg = <0x0 0xff280000 0x0 0x100>;
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]


#1695534 — [PATCH 5/5] arm64: dts: rockchip: Enable tsadc module on RK3328 eavluation board

FromRocky Hao <rocky.hao@rock-chips.com>
Date2017-07-25 11:20 +0200
Subject[PATCH 5/5] arm64: dts: rockchip: Enable tsadc module on RK3328 eavluation board
Message-ID<u74aw-VK-45@gated-at.bofh.it>
In reply to#1695515
enable tsadc module on RK3328 eavluation board

Change-Id: Ieb45a02b90dae3fbefe7d2b571b3961412d866ad
Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>
---
 arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts
index 8c61d91bf89b..e7db0dc97ce0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts
@@ -52,6 +52,10 @@
 	};
 };
 
+&tsadc {
+	status = "okay";
+};
+
 &uart2 {
 	status = "okay";
 };
-- 
1.9.1

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web