Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1694206 > unrolled thread

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

Started byAndy Shevchenko <andy.shevchenko@gmail.com>
First post2017-07-23 00:10 +0200
Last post2017-07-23 00:10 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-23 00:10 +0200

#1694206 — Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-07-23 00:10 +0200
SubjectRe: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created
Message-ID<u6aKZ-7z4-3@gated-at.bofh.it>
On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Avoid hogging chip select GPIOs just because they are listed for the
> master. They might be mulitplexed and, if no slave device is attached,
> used for different purposes. Moreover, this strategy avoids having to
> allocate a cs_gpiods structure.
>
> Tested on the IOT2000 where the second SPI bus is connected to an
> Arduino-compatible connector and multiplexed between SPI, GPIO and PWM
> usage.

Sorry for late reply, this patch makes impossible to use GPIO
descriptors. Now it's broken in two ways as I can see.
I fixed one, and is right now hunting another problem.

P.S. Perhaps no need to revert, just heads up.

(That's why would be better to have GPIO descriptors everywhere in
this driver and tested)

-- 
With Best Regards,
Andy Shevchenko

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web