Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692787 > unrolled thread
| Started by | Jeffy Chen <jeffy.chen@rock-chips.com> |
|---|---|
| First post | 2017-07-20 13:00 +0200 |
| Last post | 2017-07-24 19:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v6] Bluetooth: btusb: Fix memory leak in play_deferred Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-07-20 13:00 +0200
Re: [PATCH v6] Bluetooth: btusb: Fix memory leak in play_deferred Marcel Holtmann <marcel@holtmann.org> - 2017-07-22 08:50 +0200
Re: [PATCH v6] Bluetooth: btusb: Fix memory leak in play_deferred Oliver Neukum <oneukum@suse.com> - 2017-07-24 13:00 +0200
Re: [PATCH v6] Bluetooth: btusb: Fix memory leak in play_deferred Marcel Holtmann <marcel@holtmann.org> - 2017-07-24 19:00 +0200
| From | Jeffy Chen <jeffy.chen@rock-chips.com> |
|---|---|
| Date | 2017-07-20 13:00 +0200 |
| Subject | [PATCH v6] Bluetooth: btusb: Fix memory leak in play_deferred |
| Message-ID | <u5hlv-6cX-1@gated-at.bofh.it> |
Currently we are calling usb_submit_urb directly to submit deferred tx
urbs after unanchor them.
So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb
and cause memory leak:
unreferenced object 0xffffffc0ce0fa400 (size 256):
...
backtrace:
[<ffffffc00034a9a8>] __save_stack_trace+0x48/0x6c
[<ffffffc00034b088>] create_object+0x138/0x254
[<ffffffc0009d5504>] kmemleak_alloc+0x58/0x8c
[<ffffffc000345f78>] __kmalloc+0x1d4/0x2a0
[<ffffffc0006765bc>] usb_alloc_urb+0x30/0x60
[<ffffffbffc128598>] alloc_ctrl_urb+0x38/0x120 [btusb]
[<ffffffbffc129e7c>] btusb_send_frame+0x64/0xf8 [btusb]
Put those urbs in tx_anchor to avoid the leak, and also fix the error
handling.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v6:
Don't print error msg when dropping urbs, since we already log it when
failed to submit.
Changes in v5:
Fix compile warning reported by "kbuild test robot":
drivers/bluetooth/btusb.c:3288:3: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
This 'err' would be set in the send loop, and would be used in the
cleanup rest urb code outside the loop.
Changes in v4:
Drop the rest deferred urbs when error happens.
Changes in v3:
Put the deferred urbs in tx_anchor.
Changes in v2:
Call usb_free_urb instead of reusing submit_tx_urb.
drivers/bluetooth/btusb.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 0d533b2..fa3de4f 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3266,13 +3266,28 @@ static void play_deferred(struct btusb_data *data)
int err;
while ((urb = usb_get_from_anchor(&data->deferred))) {
+ usb_anchor_urb(urb, &data->tx_anchor);
+
err = usb_submit_urb(urb, GFP_ATOMIC);
- if (err < 0)
+ if (err < 0) {
+ if (err != -EPERM && err != -ENODEV)
+ BT_ERR("%s urb %p submission failed (%d)",
+ data->hdev->name, urb, -err);
+ kfree(urb->setup_packet);
+ usb_unanchor_urb(urb);
+ usb_free_urb(urb);
break;
+ }
data->tx_in_flight++;
+ usb_free_urb(urb);
+ }
+
+ /* Cleanup the rest deferred urbs. */
+ while ((urb = usb_get_from_anchor(&data->deferred))) {
+ kfree(urb->setup_packet);
+ usb_free_urb(urb);
}
- usb_scuttle_anchored_urbs(&data->deferred);
}
static int btusb_resume(struct usb_interface *intf)
--
2.1.4
[toc] | [next] | [standalone]
| From | Marcel Holtmann <marcel@holtmann.org> |
|---|---|
| Date | 2017-07-22 08:50 +0200 |
| Message-ID | <u5WoF-6X1-11@gated-at.bofh.it> |
| In reply to | #1692787 |
Hi Oliver,
> Currently we are calling usb_submit_urb directly to submit deferred tx
> urbs after unanchor them.
>
> So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb
> and cause memory leak:
> unreferenced object 0xffffffc0ce0fa400 (size 256):
> ...
> backtrace:
> [<ffffffc00034a9a8>] __save_stack_trace+0x48/0x6c
> [<ffffffc00034b088>] create_object+0x138/0x254
> [<ffffffc0009d5504>] kmemleak_alloc+0x58/0x8c
> [<ffffffc000345f78>] __kmalloc+0x1d4/0x2a0
> [<ffffffc0006765bc>] usb_alloc_urb+0x30/0x60
> [<ffffffbffc128598>] alloc_ctrl_urb+0x38/0x120 [btusb]
> [<ffffffbffc129e7c>] btusb_send_frame+0x64/0xf8 [btusb]
>
> Put those urbs in tx_anchor to avoid the leak, and also fix the error
> handling.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
> Changes in v6:
> Don't print error msg when dropping urbs, since we already log it when
> failed to submit.
>
> Changes in v5:
> Fix compile warning reported by "kbuild test robot":
> drivers/bluetooth/btusb.c:3288:3: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
> This 'err' would be set in the send loop, and would be used in the
> cleanup rest urb code outside the loop.
>
> Changes in v4:
> Drop the rest deferred urbs when error happens.
>
> Changes in v3:
> Put the deferred urbs in tx_anchor.
>
> Changes in v2:
> Call usb_free_urb instead of reusing submit_tx_urb.
>
> drivers/bluetooth/btusb.c | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 0d533b2..fa3de4f 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -3266,13 +3266,28 @@ static void play_deferred(struct btusb_data *data)
> int err;
>
> while ((urb = usb_get_from_anchor(&data->deferred))) {
> + usb_anchor_urb(urb, &data->tx_anchor);
> +
> err = usb_submit_urb(urb, GFP_ATOMIC);
> - if (err < 0)
> + if (err < 0) {
> + if (err != -EPERM && err != -ENODEV)
> + BT_ERR("%s urb %p submission failed (%d)",
> + data->hdev->name, urb, -err);
> + kfree(urb->setup_packet);
> + usb_unanchor_urb(urb);
> + usb_free_urb(urb);
> break;
> + }
>
> data->tx_in_flight++;
> + usb_free_urb(urb);
> + }
> +
> + /* Cleanup the rest deferred urbs. */
> + while ((urb = usb_get_from_anchor(&data->deferred))) {
> + kfree(urb->setup_packet);
> + usb_free_urb(urb);
> }
> - usb_scuttle_anchored_urbs(&data->deferred);
> }
can I get a reviewed-by from you on this version of the patch.
Regards
Marcel
[toc] | [prev] | [next] | [standalone]
| From | Oliver Neukum <oneukum@suse.com> |
|---|---|
| Date | 2017-07-24 13:00 +0200 |
| Message-ID | <u6JfI-3F7-19@gated-at.bofh.it> |
| In reply to | #1692787 |
Am Donnerstag, den 20.07.2017, 18:53 +0800 schrieb Jeffy Chen: > Currently we are calling usb_submit_urb directly to submit deferred tx > urbs after unanchor them. > > So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb > and cause memory leak: > unreferenced object 0xffffffc0ce0fa400 (size 256): > ... > backtrace: > [<ffffffc00034a9a8>] __save_stack_trace+0x48/0x6c > [<ffffffc00034b088>] create_object+0x138/0x254 > [<ffffffc0009d5504>] kmemleak_alloc+0x58/0x8c > [<ffffffc000345f78>] __kmalloc+0x1d4/0x2a0 > [<ffffffc0006765bc>] usb_alloc_urb+0x30/0x60 > [<ffffffbffc128598>] alloc_ctrl_urb+0x38/0x120 [btusb] > [<ffffffbffc129e7c>] btusb_send_frame+0x64/0xf8 [btusb] > > Put those urbs in tx_anchor to avoid the leak, and also fix the error > handling. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> Reviewed-by: Oliver Neukum <oneukum@suse.com>
[toc] | [prev] | [next] | [standalone]
| From | Marcel Holtmann <marcel@holtmann.org> |
|---|---|
| Date | 2017-07-24 19:00 +0200 |
| Message-ID | <u6OS6-7yA-25@gated-at.bofh.it> |
| In reply to | #1692787 |
Hi Jeffy, > Currently we are calling usb_submit_urb directly to submit deferred tx > urbs after unanchor them. > > So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb > and cause memory leak: > unreferenced object 0xffffffc0ce0fa400 (size 256): > ... > backtrace: > [<ffffffc00034a9a8>] __save_stack_trace+0x48/0x6c > [<ffffffc00034b088>] create_object+0x138/0x254 > [<ffffffc0009d5504>] kmemleak_alloc+0x58/0x8c > [<ffffffc000345f78>] __kmalloc+0x1d4/0x2a0 > [<ffffffc0006765bc>] usb_alloc_urb+0x30/0x60 > [<ffffffbffc128598>] alloc_ctrl_urb+0x38/0x120 [btusb] > [<ffffffbffc129e7c>] btusb_send_frame+0x64/0xf8 [btusb] > > Put those urbs in tx_anchor to avoid the leak, and also fix the error > handling. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > --- > > Changes in v6: > Don't print error msg when dropping urbs, since we already log it when > failed to submit. > > Changes in v5: > Fix compile warning reported by "kbuild test robot": > drivers/bluetooth/btusb.c:3288:3: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] > This 'err' would be set in the send loop, and would be used in the > cleanup rest urb code outside the loop. > > Changes in v4: > Drop the rest deferred urbs when error happens. > > Changes in v3: > Put the deferred urbs in tx_anchor. > > Changes in v2: > Call usb_free_urb instead of reusing submit_tx_urb. > > drivers/bluetooth/btusb.c | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web