Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1694475 > unrolled thread
| Started by | Martin Kepplinger <martink@posteo.de> |
|---|---|
| First post | 2017-07-24 08:50 +0200 |
| Last post | 2017-07-24 10:40 +0200 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: vboxvideo: Kconfig: Fix typos in help text Martin Kepplinger <martink@posteo.de> - 2017-07-24 08:50 +0200
Re: [PATCH] staging: vboxvideo: Kconfig: Fix typos in help text Hans de Goede <hdegoede@redhat.com> - 2017-07-24 09:50 +0200
Re: [PATCH] staging: vboxvideo: Kconfig: Fix typos in help text Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-24 10:20 +0200
[PATCH v2] staging: vboxvideo: Kconfig: Fix typos in help text Martin Kepplinger <martink@posteo.de> - 2017-07-24 10:30 +0200
[PATCH v3] staging: vboxvideo: Kconfig: Fix typos in help text Martin Kepplinger <martink@posteo.de> - 2017-07-24 10:40 +0200
Re: [PATCH v3] staging: vboxvideo: Kconfig: Fix typos in help text Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-24 10:40 +0200
| From | Martin Kepplinger <martink@posteo.de> |
|---|---|
| Date | 2017-07-24 08:50 +0200 |
| Subject | [PATCH] staging: vboxvideo: Kconfig: Fix typos in help text |
| Message-ID | <u6FlL-1fV-3@gated-at.bofh.it> |
This fixes typos in vboxvideo's help text. Signed-off-by: Martin Kepplinger <martink@posteo.de> --- drivers/staging/vboxvideo/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig index a52746f9a670..2b058d573cf1 100644 --- a/drivers/staging/vboxvideo/Kconfig +++ b/drivers/staging/vboxvideo/Kconfig @@ -6,7 +6,7 @@ config DRM_VBOXVIDEO This is a KMS driver for the virtual Graphics Card used in Virtual Box virtual machines. - Although it is possible to builtin this module, it is advised + Although it is possible to build in this module, it is advised to build this driver as a module, so that it can be updated - independently of the kernel. Select M to built this driver as a + independently of the kernel. Select M to build this driver as a module and add support for these devices via drm/kms interfaces. -- 2.11.0
[toc] | [next] | [standalone]
| From | Hans de Goede <hdegoede@redhat.com> |
|---|---|
| Date | 2017-07-24 09:50 +0200 |
| Message-ID | <u6GhP-1Ow-5@gated-at.bofh.it> |
| In reply to | #1694475 |
Hi, On 24-07-17 08:45, Martin Kepplinger wrote: > This fixes typos in vboxvideo's help text. > > Signed-off-by: Martin Kepplinger <martink@posteo.de> Looks good to me: Acked-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/staging/vboxvideo/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig > index a52746f9a670..2b058d573cf1 100644 > --- a/drivers/staging/vboxvideo/Kconfig > +++ b/drivers/staging/vboxvideo/Kconfig > @@ -6,7 +6,7 @@ config DRM_VBOXVIDEO > This is a KMS driver for the virtual Graphics Card used in > Virtual Box virtual machines. > > - Although it is possible to builtin this module, it is advised > + Although it is possible to build in this module, it is advised > to build this driver as a module, so that it can be updated > - independently of the kernel. Select M to built this driver as a > + independently of the kernel. Select M to build this driver as a > module and add support for these devices via drm/kms interfaces. >
[toc] | [prev] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-07-24 10:20 +0200 |
| Message-ID | <u6GKR-2eZ-15@gated-at.bofh.it> |
| In reply to | #1694475 |
On Mon, Jul 24, 2017 at 08:45:16AM +0200, Martin Kepplinger wrote: > This fixes typos in vboxvideo's help text. > > Signed-off-by: Martin Kepplinger <martink@posteo.de> > --- > drivers/staging/vboxvideo/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig > index a52746f9a670..2b058d573cf1 100644 > --- a/drivers/staging/vboxvideo/Kconfig > +++ b/drivers/staging/vboxvideo/Kconfig > @@ -6,7 +6,7 @@ config DRM_VBOXVIDEO > This is a KMS driver for the virtual Graphics Card used in > Virtual Box virtual machines. > > - Although it is possible to builtin this module, it is advised > + Although it is possible to build in this module, it is advised I feel like this is unclear. Perhaps say something like: Although it is possible to build this driver built-in to the kernel, it is advised ... regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Martin Kepplinger <martink@posteo.de> |
|---|---|
| Date | 2017-07-24 10:30 +0200 |
| Subject | [PATCH v2] staging: vboxvideo: Kconfig: Fix typos in help text |
| Message-ID | <u6GUz-2i4-13@gated-at.bofh.it> |
| In reply to | #1694533 |
This fixes typos in vboxvideo's help text. Most notably, "to builtin
this module" becomes "to build this driver built-in to the kernel".
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
Thanks Dan. I actually also had the feeling that even though it's better,
it's not as clear as it could be. It's either a module or built-in; not both.
revision history
----------------
v2: Say "to build this driver built-in to the kernel" instead of "build in
this module".
drivers/staging/vboxvideo/Kconfig | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
index a52746f9a670..b8df8f60823a 100644
--- a/drivers/staging/vboxvideo/Kconfig
+++ b/drivers/staging/vboxvideo/Kconfig
@@ -6,7 +6,8 @@ config DRM_VBOXVIDEO
This is a KMS driver for the virtual Graphics Card used in
Virtual Box virtual machines.
- Although it is possible to builtin this module, it is advised
- to build this driver as a module, so that it can be updated
- independently of the kernel. Select M to built this driver as a
- module and add support for these devices via drm/kms interfaces.
+ Although it is possible to build this driver built-in to the
+ kernel, it is advised to build this driver as a module, so that
+ it can be updated independently of the kernel. Select M to build
+ this driver as a module and add support for these devices via
+ drm/kms interfaces.
--
2.11.0
[toc] | [prev] | [next] | [standalone]
| From | Martin Kepplinger <martink@posteo.de> |
|---|---|
| Date | 2017-07-24 10:40 +0200 |
| Subject | [PATCH v3] staging: vboxvideo: Kconfig: Fix typos in help text |
| Message-ID | <u6H4e-2mn-5@gated-at.bofh.it> |
| In reply to | #1694538 |
This fixes typos in vboxvideo's help text. Most notably, "to builtin
this module" becomes "to build this driver built-in to the kernel".
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
revision history
----------------
v3: Avoid a repetition of "this driver".
v2: Say "to build this driver built-in to the kernel" instead of "build in
this module". - Thanks Dan.
drivers/staging/vboxvideo/Kconfig | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
index a52746f9a670..3200b6895178 100644
--- a/drivers/staging/vboxvideo/Kconfig
+++ b/drivers/staging/vboxvideo/Kconfig
@@ -6,7 +6,8 @@ config DRM_VBOXVIDEO
This is a KMS driver for the virtual Graphics Card used in
Virtual Box virtual machines.
- Although it is possible to builtin this module, it is advised
- to build this driver as a module, so that it can be updated
- independently of the kernel. Select M to built this driver as a
- module and add support for these devices via drm/kms interfaces.
+ Although it is possible to build this driver built-in to the
+ kernel, it is advised to build it as a module, so that it can
+ be updated independently of the kernel. Select M to build this
+ driver as a module and add support for these devices via drm/kms
+ interfaces.
--
2.11.0
[toc] | [prev] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-07-24 10:40 +0200 |
| Subject | Re: [PATCH v3] staging: vboxvideo: Kconfig: Fix typos in help text |
| Message-ID | <u6H4e-2mn-13@gated-at.bofh.it> |
| In reply to | #1694539 |
Looks good. Thanks. regards, dan carpenter
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web