Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692096 > unrolled thread

RE: [PATCH 3.18 36/68] Handle mismatched open calls

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  RE: [PATCH 3.18 36/68] Handle mismatched open calls Pavel Shilovskiy <pshilov@microsoft.com> - 2017-07-19 20:40 +0200
    Re: [PATCH 3.18 36/68] Handle mismatched open calls Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-22 15:20 +0200

#1692096 — RE: [PATCH 3.18 36/68] Handle mismatched open calls

[Multipart message — attachments visible in raw view] — view raw

2017-07-14 9:43 Ben Hutchings <ben@decadent.org.uk>:
> On Fri, 2017-05-05 at 11:32 -0700, Greg Kroah-Hartman wrote:
> > 3.18-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Sachin Prabhu <sprabhu@redhat.com>
> > 
> > commit 38bd49064a1ecb67baad33598e3d824448ab11ec upstream.
> [...]
> > --- a/fs/cifs/smb2ops.c
> > +++ b/fs/cifs/smb2ops.c
> > @@ -1461,6 +1461,8 @@ struct smb_version_operations smb21_oper
> >  	.clear_stats = smb2_clear_stats,
> >  	.print_stats = smb2_print_stats,
> >  	.is_oplock_break = smb2_is_valid_oplock_break,
> > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> >  	.downgrade_oplock = smb2_downgrade_oplock,
> >  	.need_neg = smb2_need_neg,
> >  	.negotiate = smb2_negotiate,
> > @@ -1542,6 +1544,8 @@ struct smb_version_operations smb30_oper
> >  	.print_stats = smb2_print_stats,
> >  	.dump_share_caps = smb2_dump_share_caps,
> >  	.is_oplock_break = smb2_is_valid_oplock_break,
> > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> >  	.downgrade_oplock = smb2_downgrade_oplock,
> >  	.need_neg = smb2_need_neg,
> >  	.negotiate = smb2_negotiate,
> [...]
> 
> This doesn't look right.  handle_cancelled_mid should be initialised once in each of the 3 smb_version_operations structures, shouldn't it?
>
> Ben.

Yes, you are right. Thanks for pointing it out.

Greg, I provided the patch to fix the above bug (see the attachment). Could you please look at it and apply to the 3.18.x kernel if it is suitable?

Best regards,
Pavel Shilovsky

[toc] | [next] | [standalone]

#1694156

On Wed, Jul 19, 2017 at 06:39:13PM +0000, Pavel Shilovskiy wrote:
> 2017-07-14 9:43 Ben Hutchings <ben@decadent.org.uk>:
> > On Fri, 2017-05-05 at 11:32 -0700, Greg Kroah-Hartman wrote:
> > > 3.18-stable review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > From: Sachin Prabhu <sprabhu@redhat.com>
> > > 
> > > commit 38bd49064a1ecb67baad33598e3d824448ab11ec upstream.
> > [...]
> > > --- a/fs/cifs/smb2ops.c
> > > +++ b/fs/cifs/smb2ops.c
> > > @@ -1461,6 +1461,8 @@ struct smb_version_operations smb21_oper
> > >  	.clear_stats = smb2_clear_stats,
> > >  	.print_stats = smb2_print_stats,
> > >  	.is_oplock_break = smb2_is_valid_oplock_break,
> > > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> > > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> > >  	.downgrade_oplock = smb2_downgrade_oplock,
> > >  	.need_neg = smb2_need_neg,
> > >  	.negotiate = smb2_negotiate,
> > > @@ -1542,6 +1544,8 @@ struct smb_version_operations smb30_oper
> > >  	.print_stats = smb2_print_stats,
> > >  	.dump_share_caps = smb2_dump_share_caps,
> > >  	.is_oplock_break = smb2_is_valid_oplock_break,
> > > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> > > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> > >  	.downgrade_oplock = smb2_downgrade_oplock,
> > >  	.need_neg = smb2_need_neg,
> > >  	.negotiate = smb2_negotiate,
> > [...]
> > 
> > This doesn't look right.  handle_cancelled_mid should be initialised once in each of the 3 smb_version_operations structures, shouldn't it?
> >
> > Ben.
> 
> Yes, you are right. Thanks for pointing it out.
> 
> Greg, I provided the patch to fix the above bug (see the attachment).
> Could you please look at it and apply to the 3.18.x kernel if it is
> suitable?

Looks good, now queued up, thanks.

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web