Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1693240 > unrolled thread
| Started by | Loc Ho <lho@apm.com> |
|---|---|
| First post | 2017-07-20 23:40 +0200 |
| Last post | 2017-07-21 08:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v5 1/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ Loc Ho <lho@apm.com> - 2017-07-20 23:40 +0200
Re: [PATCH v5 1/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ Borislav Petkov <bp@suse.de> - 2017-07-21 08:10 +0200
| From | Loc Ho <lho@apm.com> |
|---|---|
| Date | 2017-07-20 23:40 +0200 |
| Subject | [PATCH v5 1/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ |
| Message-ID | <u5rkR-4n6-3@gated-at.bofh.it> |
This patch allows APEI generic error source table with external
IRQ to share a single IRQ.
Co-authored-by: Tuan Phan <tphan@apm.com>
Signed-off-by: Loc Ho <lho@apm.com>
---
drivers/acpi/apei/ghes.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index d661d45..eed09fc 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
generic->header.source_id);
goto err_edac_unreg;
}
- rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
+ rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
+ "GHES IRQ", ghes);
if (rc) {
pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
generic->header.source_id);
--
1.8.3.1
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@suse.de> |
|---|---|
| Date | 2017-07-21 08:10 +0200 |
| Subject | Re: [PATCH v5 1/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ |
| Message-ID | <u5ziq-174-9@gated-at.bofh.it> |
| In reply to | #1693240 |
On Thu, Jul 20, 2017 at 02:36:03PM -0700, Loc Ho wrote:
> This patch allows APEI generic error source table with external
"This patch" in a commit message is tautologically redundant.
> IRQ to share a single IRQ.
Because? More background please.
> Co-authored-by: Tuan Phan <tphan@apm.com>
I guess an invented tag is fine. What you can also do is say in free
text in the commit message that Tuan has helped.
> Signed-off-by: Loc Ho <lho@apm.com>
> ---
...
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web