Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1693336 > unrolled thread
| Started by | Wang Xibo <wang.xibo@zte.com.cn> |
|---|---|
| First post | 2017-07-21 04:10 +0200 |
| Last post | 2017-07-21 15:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] GFS2: fix code parameter error in inode_go_lock Wang Xibo <wang.xibo@zte.com.cn> - 2017-07-21 04:10 +0200
Re: [PATCH] GFS2: fix code parameter error in inode_go_lock Bob Peterson <rpeterso@redhat.com> - 2017-07-21 15:30 +0200
| From | Wang Xibo <wang.xibo@zte.com.cn> |
|---|---|
| Date | 2017-07-21 04:10 +0200 |
| Subject | [PATCH] GFS2: fix code parameter error in inode_go_lock |
| Message-ID | <u5vya-7aa-11@gated-at.bofh.it> |
In inode_go_lock() function, the parameter order of list_add() is error.
According to the define of list_add(), the first parameter is new entry
and the second is the list head, so ip->i_trunc_list should be the
first parameter and the sdp->sd_trunc_list should be second.
Signed-off-by: Wang Xibo<wang.xibo@zte.com.cn>
Signed-off-by: Xiao Likun<xiao.likun@zte.com.cn>
---
fs/gfs2/glops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
index 5e69636..28c203a 100644
--- a/fs/gfs2/glops.c
+++ b/fs/gfs2/glops.c
@@ -470,7 +470,7 @@ static int inode_go_lock(struct gfs2_holder *gh)
(gh->gh_state == LM_ST_EXCLUSIVE)) {
spin_lock(&sdp->sd_trunc_lock);
if (list_empty(&ip->i_trunc_list))
- list_add(&sdp->sd_trunc_list, &ip->i_trunc_list);
+ list_add(&ip->i_trunc_list, &sdp->sd_trunc_list);
spin_unlock(&sdp->sd_trunc_lock);
wake_up(&sdp->sd_quota_wait);
return 1;
--
1.8.3.1
[toc] | [next] | [standalone]
| From | Bob Peterson <rpeterso@redhat.com> |
|---|---|
| Date | 2017-07-21 15:30 +0200 |
| Message-ID | <u5Gae-5lR-5@gated-at.bofh.it> |
| In reply to | #1693336 |
----- Original Message -----
| In inode_go_lock() function, the parameter order of list_add() is error.
| According to the define of list_add(), the first parameter is new entry
| and the second is the list head, so ip->i_trunc_list should be the
| first parameter and the sdp->sd_trunc_list should be second.
|
| Signed-off-by: Wang Xibo<wang.xibo@zte.com.cn>
| Signed-off-by: Xiao Likun<xiao.likun@zte.com.cn>
| ---
| fs/gfs2/glops.c | 2 +-
| 1 file changed, 1 insertion(+), 1 deletion(-)
|
| diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
| index 5e69636..28c203a 100644
| --- a/fs/gfs2/glops.c
| +++ b/fs/gfs2/glops.c
| @@ -470,7 +470,7 @@ static int inode_go_lock(struct gfs2_holder *gh)
| (gh->gh_state == LM_ST_EXCLUSIVE)) {
| spin_lock(&sdp->sd_trunc_lock);
| if (list_empty(&ip->i_trunc_list))
| - list_add(&sdp->sd_trunc_list, &ip->i_trunc_list);
| + list_add(&ip->i_trunc_list, &sdp->sd_trunc_list);
| spin_unlock(&sdp->sd_trunc_lock);
| wake_up(&sdp->sd_quota_wait);
| return 1;
| --
| 1.8.3.1
|
|
|
Hi,
Good catch! This is now applied to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=e7cb550d79fba5876616ed33ccafafc4e2bd7e2e
Regards,
Bob Peterson
Red Hat File Systems
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web