Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1693066 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-07-20 18:00 +0200 |
| Last post | 2017-07-20 21:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 10/12] [v2] ARM: s3c24xx: make H1940BT depend on RFKILL Arnd Bergmann <arnd@arndb.de> - 2017-07-20 18:00 +0200
Re: [PATCH 10/12] [v2] ARM: s3c24xx: make H1940BT depend on RFKILL Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-20 21:40 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-07-20 18:00 +0200 |
| Subject | [PATCH 10/12] [v2] ARM: s3c24xx: make H1940BT depend on RFKILL |
| Message-ID | <u5m1R-11d-57@gated-at.bofh.it> |
Bluetooth is only supported when network support is part of the kernel, so it is a bit pointless to build the hi1940-bt support without networking. If we try anyway, we get a Kconfig warning: warning: (TOSA_BT && H1940BT) selects RFKILL which has unmet direct dependencies (NET) This turns the 'select' into 'depends on' as Krzysztof suggested when I first sent a fix. Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> Link: https://patchwork.kernel.org/patch/8164161/ Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- v1 was sent in Jan 2016, and instead added a dependency on CONFIG_NET --- arch/arm/mach-s3c24xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index 648c519c7593..7da0165334ae 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -237,7 +237,7 @@ config ARCH_H1940 config H1940BT tristate "Control the state of H1940 bluetooth chip" depends on ARCH_H1940 - select RFKILL + depends on RFKILL help This is a simple driver that is able to control the state of built in bluetooth chip on h1940. -- 2.9.0
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2017-07-20 21:40 +0200 |
| Message-ID | <u5psJ-3ei-7@gated-at.bofh.it> |
| In reply to | #1693066 |
On Thu, Jul 20, 2017 at 05:53:43PM +0200, Arnd Bergmann wrote: > Bluetooth is only supported when network support is part of the kernel, > so it is a bit pointless to build the hi1940-bt support without networking. > If we try anyway, we get a Kconfig warning: > > warning: (TOSA_BT && H1940BT) selects RFKILL which has unmet direct dependencies (NET) > > This turns the 'select' into 'depends on' as Krzysztof suggested when > I first sent a fix. > > Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> > Link: https://patchwork.kernel.org/patch/8164161/ > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > v1 was sent in Jan 2016, and instead added a dependency on CONFIG_NET > --- > arch/arm/mach-s3c24xx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied. Best regards, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web