Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692433 > unrolled thread

[RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options

Started byKrzysztof Kozlowski <krzk@kernel.org>
First post2017-07-20 07:10 +0200
Last post2017-07-20 21:40 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-20 07:10 +0200
    Re: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options Sam Ravnborg <sam@ravnborg.org> - 2017-07-20 14:40 +0200
      Re: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-20 20:20 +0200
        Re: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig  options David Miller <davem@davemloft.net> - 2017-07-20 21:40 +0200

#1692433 — [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options

FromKrzysztof Kozlowski <krzk@kernel.org>
Date2017-07-20 07:10 +0200
Subject[RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options
Message-ID<u5bSP-2zR-29@gated-at.bofh.it>
Remove old, dead Kconfig options (in order appearing in this commit):
 - EXPERIMENTAL is gone since v3.9;
 - INET_LRO: commit 7bbf3cae65b6 ("ipv4: Remove inet_lro library");
 - AUTOFS_FS: commit 561c5cf9236a ("staging: Remove autofs3");
 - RCU_CPU_STALL_DETECTOR: commit a00e0d714fbd ("rcu: Remove conditional
   compilation for RCU CPU stall warnings");
 - USB_DEVICE_CLASS: commit 007bab91324e ("USB: remove
   CONFIG_USB_DEVICE_CLASS");
 - SYSCTL_SYSCALL_CHECK: commit 7c60c48f58a7 ("sysctl: Improve the
   sysctl sanity checks");

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: David S. Miller <davem@davemloft.net>
---
 arch/sparc/configs/sparc32_defconfig | 4 ----
 arch/sparc/configs/sparc64_defconfig | 4 ----
 2 files changed, 8 deletions(-)

diff --git a/arch/sparc/configs/sparc32_defconfig b/arch/sparc/configs/sparc32_defconfig
index c74d3701ad68..207a43a2d8b3 100644
--- a/arch/sparc/configs/sparc32_defconfig
+++ b/arch/sparc/configs/sparc32_defconfig
@@ -1,4 +1,3 @@
-CONFIG_EXPERIMENTAL=y
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
 CONFIG_LOG_BUF_SHIFT=14
@@ -23,7 +22,6 @@ CONFIG_IP_PNP_DHCP=y
 CONFIG_INET_AH=y
 CONFIG_INET_ESP=y
 CONFIG_INET_IPCOMP=y
-# CONFIG_INET_LRO is not set
 CONFIG_INET6_AH=m
 CONFIG_INET6_ESP=m
 CONFIG_INET6_IPCOMP=m
@@ -69,7 +67,6 @@ CONFIG_EXT2_FS=y
 CONFIG_EXT2_FS_XATTR=y
 CONFIG_EXT2_FS_POSIX_ACL=y
 CONFIG_EXT2_FS_SECURITY=y
-CONFIG_AUTOFS_FS=m
 CONFIG_AUTOFS4_FS=m
 CONFIG_ISO9660_FS=m
 CONFIG_PROC_KCORE=y
@@ -82,7 +79,6 @@ CONFIG_NLS=y
 CONFIG_DEBUG_KERNEL=y
 CONFIG_DETECT_HUNG_TASK=y
 # CONFIG_SCHED_DEBUG is not set
-# CONFIG_RCU_CPU_STALL_DETECTOR is not set
 CONFIG_KGDB=y
 CONFIG_KGDB_TESTS=y
 CONFIG_CRYPTO_NULL=m
diff --git a/arch/sparc/configs/sparc64_defconfig b/arch/sparc/configs/sparc64_defconfig
index b2e650d1764f..ca8609d7292f 100644
--- a/arch/sparc/configs/sparc64_defconfig
+++ b/arch/sparc/configs/sparc64_defconfig
@@ -1,5 +1,4 @@
 CONFIG_64BIT=y
-CONFIG_EXPERIMENTAL=y
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
@@ -184,7 +183,6 @@ CONFIG_HID_TOPSEED=y
 CONFIG_HID_THRUSTMASTER=y
 CONFIG_HID_ZEROPLUS=y
 CONFIG_USB=y
-# CONFIG_USB_DEVICE_CLASS is not set
 CONFIG_USB_EHCI_HCD=m
 # CONFIG_USB_EHCI_TT_NEWSCHED is not set
 CONFIG_USB_OHCI_HCD=y
@@ -210,8 +208,6 @@ CONFIG_LOCKUP_DETECTOR=y
 CONFIG_DETECT_HUNG_TASK=y
 # CONFIG_SCHED_DEBUG is not set
 CONFIG_SCHEDSTATS=y
-# CONFIG_RCU_CPU_STALL_DETECTOR is not set
-CONFIG_SYSCTL_SYSCALL_CHECK=y
 CONFIG_BLK_DEV_IO_TRACE=y
 CONFIG_UPROBE_EVENTS=y
 CONFIG_KEYS=y
-- 
2.7.4

[toc] | [next] | [standalone]

#1692886

FromSam Ravnborg <sam@ravnborg.org>
Date2017-07-20 14:40 +0200
Message-ID<u5iUi-7pn-23@gated-at.bofh.it>
In reply to#1692433
On Thu, Jul 20, 2017 at 07:00:55AM +0200, Krzysztof Kozlowski wrote:
> Remove old, dead Kconfig options (in order appearing in this commit):
>  - EXPERIMENTAL is gone since v3.9;
>  - INET_LRO: commit 7bbf3cae65b6 ("ipv4: Remove inet_lro library");
>  - AUTOFS_FS: commit 561c5cf9236a ("staging: Remove autofs3");
>  - RCU_CPU_STALL_DETECTOR: commit a00e0d714fbd ("rcu: Remove conditional
>    compilation for RCU CPU stall warnings");
>  - USB_DEVICE_CLASS: commit 007bab91324e ("USB: remove
>    CONFIG_USB_DEVICE_CLASS");
>  - SYSCTL_SYSCALL_CHECK: commit 7c60c48f58a7 ("sysctl: Improve the
>    sysctl sanity checks");
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: David S. Miller <davem@davemloft.net>

Hi Krzysztof.

This looks like a manually edited defconfig.
A better approch would be to do:
$ make ARCH=sparc64 sparc64_defconfig
$ make ARCH=sparc64 savedefconfig

And then to check the generated defconfig.
Same for sparc32.

This is more or less how the defconfig filws are generated in the first place.


Diffstat when I do the above:
defconfig |   62 ++++++++++++++++----------------------------------------------
 1 file changed, 16 insertions(+), 46 deletions(-)


	Sam

[toc] | [prev] | [next] | [standalone]

#1693154

FromKrzysztof Kozlowski <krzk@kernel.org>
Date2017-07-20 20:20 +0200
Message-ID<u5odj-2wG-3@gated-at.bofh.it>
In reply to#1692886
On Thu, Jul 20, 2017 at 02:36:33PM +0200, Sam Ravnborg wrote:
> On Thu, Jul 20, 2017 at 07:00:55AM +0200, Krzysztof Kozlowski wrote:
> > Remove old, dead Kconfig options (in order appearing in this commit):
> >  - EXPERIMENTAL is gone since v3.9;
> >  - INET_LRO: commit 7bbf3cae65b6 ("ipv4: Remove inet_lro library");
> >  - AUTOFS_FS: commit 561c5cf9236a ("staging: Remove autofs3");
> >  - RCU_CPU_STALL_DETECTOR: commit a00e0d714fbd ("rcu: Remove conditional
> >    compilation for RCU CPU stall warnings");
> >  - USB_DEVICE_CLASS: commit 007bab91324e ("USB: remove
> >    CONFIG_USB_DEVICE_CLASS");
> >  - SYSCTL_SYSCALL_CHECK: commit 7c60c48f58a7 ("sysctl: Improve the
> >    sysctl sanity checks");
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: David S. Miller <davem@davemloft.net>
> 
> Hi Krzysztof.
> 
> This looks like a manually edited defconfig.
> A better approch would be to do:
> $ make ARCH=sparc64 sparc64_defconfig
> $ make ARCH=sparc64 savedefconfig
> 
> And then to check the generated defconfig.
> Same for sparc32.

Actually this was generated with sed instead of defconfig on purpose -
as part of my bigger cleanup starting from ARM [1]. In case of
defconfigs for my platform we wanted to preserve the explanation why
things are disappearing, not only to savedefconfig. Indeed this brought
up that few items from savedefconfig would be gone but should be
replaced with different (new) items.

Anyway this way you have a full control and explanation why things are
being changed. After this you can always run defconfig to reorganize and
clean up.

[1] https://www.linux-mips.org/archives/linux-mips/2017-06/msg00255.html

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1693188 — Re: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options

FromDavid Miller <davem@davemloft.net>
Date2017-07-20 21:40 +0200
SubjectRe: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options
Message-ID<u5psJ-3ei-1@gated-at.bofh.it>
In reply to#1693154
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Thu, 20 Jul 2017 20:11:24 +0200

> On Thu, Jul 20, 2017 at 02:36:33PM +0200, Sam Ravnborg wrote:
>> On Thu, Jul 20, 2017 at 07:00:55AM +0200, Krzysztof Kozlowski wrote:
>> > Remove old, dead Kconfig options (in order appearing in this commit):
>> >  - EXPERIMENTAL is gone since v3.9;
>> >  - INET_LRO: commit 7bbf3cae65b6 ("ipv4: Remove inet_lro library");
>> >  - AUTOFS_FS: commit 561c5cf9236a ("staging: Remove autofs3");
>> >  - RCU_CPU_STALL_DETECTOR: commit a00e0d714fbd ("rcu: Remove conditional
>> >    compilation for RCU CPU stall warnings");
>> >  - USB_DEVICE_CLASS: commit 007bab91324e ("USB: remove
>> >    CONFIG_USB_DEVICE_CLASS");
>> >  - SYSCTL_SYSCALL_CHECK: commit 7c60c48f58a7 ("sysctl: Improve the
>> >    sysctl sanity checks");
>> > 
>> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> > Acked-by: David S. Miller <davem@davemloft.net>
>> 
>> Hi Krzysztof.
>> 
>> This looks like a manually edited defconfig.
>> A better approch would be to do:
>> $ make ARCH=sparc64 sparc64_defconfig
>> $ make ARCH=sparc64 savedefconfig
>> 
>> And then to check the generated defconfig.
>> Same for sparc32.
> 
> Actually this was generated with sed instead of defconfig on purpose -
> as part of my bigger cleanup starting from ARM [1]. In case of
> defconfigs for my platform we wanted to preserve the explanation why
> things are disappearing, not only to savedefconfig. Indeed this brought
> up that few items from savedefconfig would be gone but should be
> replaced with different (new) items.
> 
> Anyway this way you have a full control and explanation why things are
> being changed. After this you can always run defconfig to reorganize and
> clean up.
> 
> [1] https://www.linux-mips.org/archives/linux-mips/2017-06/msg00255.html

Yeah I guess this is OK for now.  But we should do a tool based regen at
some point soon.

Applied, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web