Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692372 > unrolled thread

linux-next: build failure after merge of the userns tree

Back to article view | Back to linux.kernel

Contents

  linux-next: build failure after merge of the userns tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-07-20 05:30 +0200
    Re: linux-next: build failure after merge of the userns tree ebiederm@xmission.com (Eric W. Biederman) - 2017-07-20 14:30 +0200

#1692372 — linux-next: build failure after merge of the userns tree

Hi Eric,

After merging the userns tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

kernel/pid_namespace.c: In function 'create_pid_namespace':
kernel/pid_namespace.c:105:7: error: too many arguments to function 'in_userns'
  if (!in_userns(parent_pid_ns->user_ns, user_ns))
       ^
In file included from kernel/pid_namespace.c:13:0:
include/linux/user_namespace.h:148:20: note: declared here
 static inline bool in_userns(const struct user_namespace *target_ns)
                    ^

Caused by commit

  1f1b28d80cd9 ("userns,pidns: Verify the userns for new pid namespaces")

I have used the userns tree from next-20170719 for today.

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1692869

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Eric,
>
> After merging the userns tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> kernel/pid_namespace.c: In function 'create_pid_namespace':
> kernel/pid_namespace.c:105:7: error: too many arguments to function 'in_userns'
>   if (!in_userns(parent_pid_ns->user_ns, user_ns))
>        ^
> In file included from kernel/pid_namespace.c:13:0:
> include/linux/user_namespace.h:148:20: note: declared here
>  static inline bool in_userns(const struct user_namespace *target_ns)
>                     ^
>
> Caused by commit
>
>   1f1b28d80cd9 ("userns,pidns: Verify the userns for new pid namespaces")
>
> I have used the userns tree from next-20170719 for today.

*scratches my head*

Yes.  That isn't a powerpc specific bug.

This has been in my for-testing branch forever.  I thought this had
received plenty of build testing but apparently not.

I will get this sorted out.

Thank you very much.

Eric

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web